mbox series

[v10,0/3] crypto: hisilicon - supports device isolation feature

Message ID 20221119074817.12063-1-yekai13@huawei.com
Headers show
Series crypto: hisilicon - supports device isolation feature | expand

Message

yekai (A) Nov. 19, 2022, 7:48 a.m. UTC
1、Add the uacce hardware error isolation interface. Hardware error 
   thresholds can be configured by sysfs node. User can get the hardware
   isolated state by sysfs node.
2、Defining the isolation strategy for uacce device by uacce sysfs node. 
   If the number of hardware errors exceeds the configured value, the 
   uacce device will not be available in user space.
3、The ACC VF device use the PF device isolation strategy.
   
changes v1->v2:
	- deleted dev_to_uacce api.
	- add vfs node doc. 
	- move uacce->ref to driver.
changes v2->v3:
	- deleted some redundant code.
	- use qm state instead of reference count.
	- add null pointer check.
	- isolate_strategy_read() instead of a copy.
changes v3->v4:
	- modify a comment
changes v4->v5:
	- use bool instead of atomic.
	- isolation frequency instead of isolation command.
changes v5->v6:
	- add is_visible in uacce.
	- add the description of the isolation strategy file node.
changes v6->v7
	- add an example for isolate_strategy in Documentation.
changes v7->v8
	- update the correct date.
changes v8->v9
    - move isolation strategy from qm to uacce.
changes v9->v10
	- Go back to the v8 version of the solution.
	- Modify some code according to suggestions.

Kai Ye (3):
  uacce: supports device isolation feature
  Documentation: add the device isolation feature sysfs nodes for uacce
  crypto: hisilicon/qm - define the device isolation strategy

 Documentation/ABI/testing/sysfs-driver-uacce |  18 ++
 drivers/crypto/hisilicon/qm.c                | 169 +++++++++++++++++--
 drivers/misc/uacce/uacce.c                   |  50 ++++++
 include/linux/hisi_acc_qm.h                  |  15 ++
 include/linux/uacce.h                        |  12 ++
 5 files changed, 249 insertions(+), 15 deletions(-)

Comments

yekai (A) Dec. 9, 2022, 6:15 a.m. UTC | #1
On 2022/11/25 16:49, yekai (A) wrote:
>
> On 2022/11/19 15:48, Kai Ye wrote:
>> 1、Add the uacce hardware error isolation interface. Hardware error 
>>    thresholds can be configured by sysfs node. User can get the hardware
>>    isolated state by sysfs node.
>> 2、Defining the isolation strategy for uacce device by uacce sysfs node. 
>>    If the number of hardware errors exceeds the configured value, the 
>>    uacce device will not be available in user space.
>> 3、The ACC VF device use the PF device isolation strategy.
>>    
>> changes v1->v2:
>> 	- deleted dev_to_uacce api.
>> 	- add vfs node doc. 
>> 	- move uacce->ref to driver.
>> changes v2->v3:
>> 	- deleted some redundant code.
>> 	- use qm state instead of reference count.
>> 	- add null pointer check.
>> 	- isolate_strategy_read() instead of a copy.
>> changes v3->v4:
>> 	- modify a comment
>> changes v4->v5:
>> 	- use bool instead of atomic.
>> 	- isolation frequency instead of isolation command.
>> changes v5->v6:
>> 	- add is_visible in uacce.
>> 	- add the description of the isolation strategy file node.
>> changes v6->v7
>> 	- add an example for isolate_strategy in Documentation.
>> changes v7->v8
>> 	- update the correct date.
>> changes v8->v9
>>     - move isolation strategy from qm to uacce.
>> changes v9->v10
>> 	- Go back to the v8 version of the solution.
>> 	- Modify some code according to suggestions.
>>
>> Kai Ye (3):
>>   uacce: supports device isolation feature
>>   Documentation: add the device isolation feature sysfs nodes for uacce
>>   crypto: hisilicon/qm - define the device isolation strategy
>>
>>  Documentation/ABI/testing/sysfs-driver-uacce |  18 ++
>>  drivers/crypto/hisilicon/qm.c                | 169 +++++++++++++++++--
>>  drivers/misc/uacce/uacce.c                   |  50 ++++++
>>  include/linux/hisi_acc_qm.h                  |  15 ++
>>  include/linux/uacce.h                        |  12 ++
>>  5 files changed, 249 insertions(+), 15 deletions(-)
>>
> Hi Grek
>
> Just a friendly ping.
>
> Thanks
> Kai

Hi Greg KH

Could you help me to apply this patchset v10?

thanks
Kai
Greg KH Dec. 9, 2022, 3:32 p.m. UTC | #2
On Fri, Dec 09, 2022 at 02:15:07PM +0800, yekai (A) wrote:
> 
> 
> On 2022/11/25 16:49, yekai (A) wrote:
> >
> > On 2022/11/19 15:48, Kai Ye wrote:
> >> 1、Add the uacce hardware error isolation interface. Hardware error 
> >>    thresholds can be configured by sysfs node. User can get the hardware
> >>    isolated state by sysfs node.
> >> 2、Defining the isolation strategy for uacce device by uacce sysfs node. 
> >>    If the number of hardware errors exceeds the configured value, the 
> >>    uacce device will not be available in user space.
> >> 3、The ACC VF device use the PF device isolation strategy.
> >>    
> >> changes v1->v2:
> >> 	- deleted dev_to_uacce api.
> >> 	- add vfs node doc. 
> >> 	- move uacce->ref to driver.
> >> changes v2->v3:
> >> 	- deleted some redundant code.
> >> 	- use qm state instead of reference count.
> >> 	- add null pointer check.
> >> 	- isolate_strategy_read() instead of a copy.
> >> changes v3->v4:
> >> 	- modify a comment
> >> changes v4->v5:
> >> 	- use bool instead of atomic.
> >> 	- isolation frequency instead of isolation command.
> >> changes v5->v6:
> >> 	- add is_visible in uacce.
> >> 	- add the description of the isolation strategy file node.
> >> changes v6->v7
> >> 	- add an example for isolate_strategy in Documentation.
> >> changes v7->v8
> >> 	- update the correct date.
> >> changes v8->v9
> >>     - move isolation strategy from qm to uacce.
> >> changes v9->v10
> >> 	- Go back to the v8 version of the solution.
> >> 	- Modify some code according to suggestions.
> >>
> >> Kai Ye (3):
> >>   uacce: supports device isolation feature
> >>   Documentation: add the device isolation feature sysfs nodes for uacce
> >>   crypto: hisilicon/qm - define the device isolation strategy
> >>
> >>  Documentation/ABI/testing/sysfs-driver-uacce |  18 ++
> >>  drivers/crypto/hisilicon/qm.c                | 169 +++++++++++++++++--
> >>  drivers/misc/uacce/uacce.c                   |  50 ++++++
> >>  include/linux/hisi_acc_qm.h                  |  15 ++
> >>  include/linux/uacce.h                        |  12 ++
> >>  5 files changed, 249 insertions(+), 15 deletions(-)
> >>
> > Hi Grek
> >
> > Just a friendly ping.
> >
> > Thanks
> > Kai
> 
> Hi Greg KH
> 
> Could you help me to apply this patchset v10?

Sorry, it needs review from the crypto maintainers before I can take it.

Also, it looks to be too late for 6.2-rc1 at this point in time.

thanks,

greg k-h
Herbert Xu Dec. 11, 2022, 6:16 a.m. UTC | #3
On Sat, Nov 19, 2022 at 07:48:17AM +0000, Kai Ye wrote:
> Define the device isolation strategy by the device driver. The
> user configures a hardware error threshold value by uacce interface.
> If the number of hardware errors exceeds the value of setting error
> threshold in one hour. The device will not be available in user space.
> The VF device use the PF device isolation strategy. All the hardware
> errors are processed by PF driver.
> 
> Signed-off-by: Kai Ye <yekai13@huawei.com>
> ---
>  drivers/crypto/hisilicon/qm.c | 169 +++++++++++++++++++++++++++++++---
>  include/linux/hisi_acc_qm.h   |  15 +++
>  2 files changed, 169 insertions(+), 15 deletions(-)

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
yekai (A) Jan. 10, 2023, 11:57 a.m. UTC | #4
On 2022/12/11 14:16, Herbert Xu wrote:
> On Sat, Nov 19, 2022 at 07:48:17AM +0000, Kai Ye wrote:
>> Define the device isolation strategy by the device driver. The
>> user configures a hardware error threshold value by uacce interface.
>> If the number of hardware errors exceeds the value of setting error
>> threshold in one hour. The device will not be available in user space.
>> The VF device use the PF device isolation strategy. All the hardware
>> errors are processed by PF driver.
>>
>> Signed-off-by: Kai Ye <yekai13@huawei.com>
>> ---
>>  drivers/crypto/hisilicon/qm.c | 169 +++++++++++++++++++++++++++++++---
>>  include/linux/hisi_acc_qm.h   |  15 +++
>>  2 files changed, 169 insertions(+), 15 deletions(-)
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Hi Greg KH

Could you help me to apply this patchset v10?

thanks
Kai
Greg KH Jan. 20, 2023, 11:06 a.m. UTC | #5
On Fri, Jan 20, 2023 at 10:13:50AM +0800, yekai (A) wrote:
> 
> 
> On 2023/1/12 17:26, yekai (A) wrote:
> >
> >
> >
> > On 2022/12/11 14:16, Herbert Xu wrote:
> >> On Sat, Nov 19, 2022 at 07:48:17AM +0000, Kai Ye wrote:
> >>> Define the device isolation strategy by the device driver. The
> >>> user configures a hardware error threshold value by uacce interface.
> >>> If the number of hardware errors exceeds the value of setting error
> >>> threshold in one hour. The device will not be available in user space.
> >>> The VF device use the PF device isolation strategy. All the hardware
> >>> errors are processed by PF driver.
> >>>
> >>> Signed-off-by: Kai Ye <yekai13@huawei.com>
> >>> ---
> >>>  drivers/crypto/hisilicon/qm.c | 169 +++++++++++++++++++++++++++++++---
> >>>  include/linux/hisi_acc_qm.h   |  15 +++
> >>>  2 files changed, 169 insertions(+), 15 deletions(-)
> >> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
> >
> > Hi Greg KH
> >
> >  
> >
> > Could you help me to apply this patchset v10?
> >
> >  
> >
> > thanks
> >
> > Kai
> >
> >
> Hi Greg KH
> 
> Just a friendly ping. 
> Could you help me to apply this patchset v10?  Your prompt reply is much appreciated.

Sorry for the delay, I missed the crypto maintainer's review.  now
queued up.

greg k-h