mbox series

[v3,0/2] crypto: qat - Remove x86 dependency on QAT drivers

Message ID 20220617095945.437601-1-yoan.picchi@arm.com
Headers show
Series crypto: qat - Remove x86 dependency on QAT drivers | expand

Message

Yoan Picchi June 17, 2022, 9:59 a.m. UTC
The QAT acceleration card can be very helpfull for some tasks like dealing
with IPSEC but it is currently restricted to be used only on x86 machine.
Looking at the code we didn't see any reasons why those drivers might not
work on other architectures. We've successfully built all of them on x86,
arm64, arm32, mips64, powerpc64, riscv64 and sparc64.

We also have tested the driver with an Intel Corporation C62x Chipset
QuickAssist Technology (rev 04) PCIe card on an arm64 server. After the numa
patch, it works with the AF_ALG crypto userland interface, allowing us to
encrypt some data with cbc for instance. We've also successfully created some
VF, bound them to DPDK, and used the card this way, thus showing some real
life usecases of x86 do work on arm64 too.

Changelog v1 ... v2:
- Add COMPILE_TEST to Kconfig

Changelog v2 ... v3:
- Add the Crypto tag to the commit header

Andre Przywara (1):
  crypto: qat - replace get_current_node() with numa_node_id()

Yoan Picchi (1):
  crypto: qat - Removes the x86 dependency on the QAT drivers

 drivers/crypto/qat/Kconfig                     | 14 +++++++-------
 drivers/crypto/qat/qat_common/adf_common_drv.h |  5 -----
 drivers/crypto/qat/qat_common/qat_algs.c       |  4 ++--
 drivers/crypto/qat/qat_common/qat_asym_algs.c  |  4 ++--
 4 files changed, 11 insertions(+), 16 deletions(-)

Comments

Herbert Xu June 24, 2022, 9:15 a.m. UTC | #1
On Fri, Jun 17, 2022 at 09:59:43AM +0000, Yoan Picchi wrote:
> The QAT acceleration card can be very helpfull for some tasks like dealing
> with IPSEC but it is currently restricted to be used only on x86 machine.
> Looking at the code we didn't see any reasons why those drivers might not
> work on other architectures. We've successfully built all of them on x86,
> arm64, arm32, mips64, powerpc64, riscv64 and sparc64.
> 
> We also have tested the driver with an Intel Corporation C62x Chipset
> QuickAssist Technology (rev 04) PCIe card on an arm64 server. After the numa
> patch, it works with the AF_ALG crypto userland interface, allowing us to
> encrypt some data with cbc for instance. We've also successfully created some
> VF, bound them to DPDK, and used the card this way, thus showing some real
> life usecases of x86 do work on arm64 too.
> 
> Changelog v1 ... v2:
> - Add COMPILE_TEST to Kconfig
> 
> Changelog v2 ... v3:
> - Add the Crypto tag to the commit header
> 
> Andre Przywara (1):
>   crypto: qat - replace get_current_node() with numa_node_id()
> 
> Yoan Picchi (1):
>   crypto: qat - Removes the x86 dependency on the QAT drivers
> 
>  drivers/crypto/qat/Kconfig                     | 14 +++++++-------
>  drivers/crypto/qat/qat_common/adf_common_drv.h |  5 -----
>  drivers/crypto/qat/qat_common/qat_algs.c       |  4 ++--
>  drivers/crypto/qat/qat_common/qat_asym_algs.c  |  4 ++--
>  4 files changed, 11 insertions(+), 16 deletions(-)

All applied.  Thanks.