From patchwork Thu Mar 3 23:01:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shameerali Kolothum Thodi X-Patchwork-Id: 547929 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2030C433EF for ; Thu, 3 Mar 2022 23:01:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233186AbiCCXCi (ORCPT ); Thu, 3 Mar 2022 18:02:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbiCCXCi (ORCPT ); Thu, 3 Mar 2022 18:02:38 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13FFEF11B0; Thu, 3 Mar 2022 15:01:51 -0800 (PST) Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4K8mfq4JNgz67M1q; Fri, 4 Mar 2022 07:00:35 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 00:01:48 +0100 Received: from A2006125610.china.huawei.com (10.47.82.4) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 23:01:41 +0000 From: Shameer Kolothum To: , , CC: , , , , , , , , , , Subject: [PATCH v8 0/9] vfio/hisilicon: add ACC live migration driver Date: Thu, 3 Mar 2022 23:01:22 +0000 Message-ID: <20220303230131.2103-1-shameerali.kolothum.thodi@huawei.com> X-Mailer: git-send-email 2.12.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.47.82.4] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi, This series attempts to add vfio live migration support for HiSilicon ACC VF devices based on the new v2 migration protocol definition and mlx5 v9 series discussed here[0]. v7 --> v8  - Dropped PRE_COPY support and early compatibility checking based on the discussion here[1].  - Addressed comments from John, Jason & Alex (Thanks!). This is sanity tested on a HiSilicon platform using the Qemu branch provided here[2]. Please take a look and let me know your feedback. Thanks, Shameer [0] https://lore.kernel.org/kvm/20220224142024.147653-1-yishaih@nvidia.com/ [1] https://lore.kernel.org/kvm/20220302133159.3c803f56.alex.williamson@redhat.com/ [2] https://github.com/jgunthorpe/qemu/commits/vfio_migration_v2 v6 --> v7  -Renamed MIG_PRECOPY ioctl name and struct name. Updated ioctl descriptions   regarding ioctl validity (patch #7). - Adressed comments from Jason and Alex on PRE_COPY read() and ioctl() fns (patch #9). - Moved only VF PCI ids to pci_ids.h(patch #3). v5 --> v6 -Report PRE_COPY support and use that for early compatibility check between src and dst devices. -For generic PRE_COPY support, included patch #7 from Jason(Thanks!). -Addressed comments from Alex(Thanks!). -Added the QM state register update to QM driver(patch #8) since that is being used in migration driver to decide whether the device is ready to save the state. RFCv4 --> v5 - Dropped RFC tag as v2 migration APIs are more stable now. - Addressed review comments from Jason and Alex (Thanks!). v3 --> RFCv4 -Based on migration v2 protocol and mlx5 v7 series. -Added RFC tag again as migration v2 protocol is still under discussion. -Added new patch #6 to retrieve the PF QM data. -PRE_COPY compatibility check is now done after the migration data  transfer. This is not ideal and needs discussion. RFC v2 --> v3  -Dropped RFC tag as the vfio_pci_core subsystem framework is now   part of 5.15-rc1.  -Added override methods for vfio_device_ops read/write/mmap calls   to limit the access within the functional register space.  -Patches 1 to 3 are code refactoring to move the common ACC QM   definitions and header around. RFCv1 --> RFCv2  -Adds a new vendor-specific vfio_pci driver(hisi-acc-vfio-pci)   for HiSilicon ACC VF devices based on the new vfio-pci-core   framework proposal.  -Since HiSilicon ACC VF device MMIO space contains both the   functional register space and migration control register space,   override the vfio_device_ops ioctl method to report only the   functional space to VMs.  -For a successful migration, we still need access to VF dev   functional register space mainly to read the status registers.   But accessing these while the Guest vCPUs are running may leave   a security hole. To avoid any potential security issues, we   map/unmap the MMIO regions on a need basis and is safe to do so.   (Please see hisi_acc_vf_ioremap/unmap() fns in patch #4).    -Dropped debugfs support for now.  -Uses common QM functions for mailbox access(patch #3). Longfang Liu (3): crypto: hisilicon/qm: Move few definitions to common header crypto: hisilicon/qm: Set the VF QM state register hisi_acc_vfio_pci: Add support for VFIO live migration Shameer Kolothum (6): crypto: hisilicon/qm: Move the QM header to include/linux hisi_acc_qm: Move VF PCI device IDs to common header hisi_acc_vfio_pci: add new vfio_pci driver for HiSilicon ACC devices hisi_acc_vfio_pci: Restrict access to VF dev BAR2 migration region hisi_acc_vfio_pci: Add helper to retrieve the struct pci_driver hisi_acc_vfio_pci: Use its own PCI reset_done error handler drivers/crypto/hisilicon/hpre/hpre.h | 2 +- drivers/crypto/hisilicon/hpre/hpre_main.c | 19 +- drivers/crypto/hisilicon/qm.c | 68 +- drivers/crypto/hisilicon/sec2/sec.h | 2 +- drivers/crypto/hisilicon/sec2/sec_main.c | 21 +- drivers/crypto/hisilicon/sgl.c | 2 +- drivers/crypto/hisilicon/zip/zip.h | 2 +- drivers/crypto/hisilicon/zip/zip_main.c | 17 +- drivers/vfio/pci/Kconfig | 2 + drivers/vfio/pci/Makefile | 2 + drivers/vfio/pci/hisilicon/Kconfig | 17 + drivers/vfio/pci/hisilicon/Makefile | 4 + .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 1319 +++++++++++++++++ .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h | 116 ++ .../qm.h => include/linux/hisi_acc_qm.h | 49 + include/linux/pci_ids.h | 3 + 16 files changed, 1579 insertions(+), 66 deletions(-) create mode 100644 drivers/vfio/pci/hisilicon/Kconfig create mode 100644 drivers/vfio/pci/hisilicon/Makefile create mode 100644 drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c create mode 100644 drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.h rename drivers/crypto/hisilicon/qm.h => include/linux/hisi_acc_qm.h (87%) Reviewed-by: Jason Gunthorpe