mbox series

[0/7] Add support for AEAD algorithms in Qualcomm Crypto Engine driver

Message ID 20210225182716.1402449-1-thara.gopinath@linaro.org
Headers show
Series Add support for AEAD algorithms in Qualcomm Crypto Engine driver | expand

Message

Thara Gopinath Feb. 25, 2021, 6:27 p.m. UTC 
Enable support for AEAD algorithms in Qualcomm CE driver.  The first three
patches in this series are cleanups and add a few missing pieces required
to add support for AEAD algorithms.  Patch 4 introduces supported AEAD
transformations on Qualcomm CE.  Patches 5 and 6 implements the h/w
infrastructure needed to enable and run the AEAD transformations on
Qualcomm CE.  Patch 7 adds support to queue fallback algorithms in case of
unsupported special inputs.

This series is dependant on https://lkml.org/lkml/2021/2/11/1052.

Thara Gopinath (7):
  crypto: qce: common: Add MAC failed error checking
  crypto: qce: common: Make result dump optional
  crypto: qce: Add mode for rfc4309
  crypto: qce: Add support for AEAD algorithms
  crypto: qce: common: Clean up qce_auth_cfg
  crypto: qce: common: Add support for AEAD algorithms
  crypto: qce: aead: Schedule fallback algorithm

 drivers/crypto/Kconfig      |  15 +
 drivers/crypto/qce/Makefile |   1 +
 drivers/crypto/qce/aead.c   | 817 ++++++++++++++++++++++++++++++++++++
 drivers/crypto/qce/aead.h   |  56 +++
 drivers/crypto/qce/common.c | 198 ++++++++-
 drivers/crypto/qce/common.h |   9 +-
 drivers/crypto/qce/core.c   |   4 +
 7 files changed, 1077 insertions(+), 23 deletions(-)
 create mode 100644 drivers/crypto/qce/aead.c
 create mode 100644 drivers/crypto/qce/aead.h

-- 
2.25.1

Comments

Herbert Xu March 4, 2021, 5:30 a.m. UTC | #1 
On Thu, Feb 25, 2021 at 01:27:09PM -0500, Thara Gopinath wrote:
> Enable support for AEAD algorithms in Qualcomm CE driver.  The first three

> patches in this series are cleanups and add a few missing pieces required

> to add support for AEAD algorithms.  Patch 4 introduces supported AEAD

> transformations on Qualcomm CE.  Patches 5 and 6 implements the h/w

> infrastructure needed to enable and run the AEAD transformations on

> Qualcomm CE.  Patch 7 adds support to queue fallback algorithms in case of

> unsupported special inputs.

> 

> This series is dependant on https://lkml.org/lkml/2021/2/11/1052.


Did this patch series pass the fuzz tests?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thara Gopinath March 4, 2021, 6:41 p.m. UTC | #2 
On Thu, 4 Mar 2021 at 00:30, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Feb 25, 2021 at 01:27:09PM -0500, Thara Gopinath wrote:
> > Enable support for AEAD algorithms in Qualcomm CE driver.  The first three
> > patches in this series are cleanups and add a few missing pieces required
> > to add support for AEAD algorithms.  Patch 4 introduces supported AEAD
> > transformations on Qualcomm CE.  Patches 5 and 6 implements the h/w
> > infrastructure needed to enable and run the AEAD transformations on
> > Qualcomm CE.  Patch 7 adds support to queue fallback algorithms in case of
> > unsupported special inputs.
> >
> > This series is dependant on https://lkml.org/lkml/2021/2/11/1052.
>
> Did this patch series pass the fuzz tests?

Hi Herbert,

Yes it did. The last patch adds fallback for unsupported cases and
this will make it pass the fuzz tests.

>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Herbert Xu March 12, 2021, 1:02 p.m. UTC | #3 
On Thu, Mar 04, 2021 at 01:41:15PM -0500, Thara Gopinath wrote:
>

> Yes it did. The last patch adds fallback for unsupported cases and

> this will make it pass the fuzz tests.


Please include this information in the next round.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thara Gopinath March 17, 2021, 2:08 a.m. UTC | #4 
On 3/12/21 8:02 AM, Herbert Xu wrote:
> On Thu, Mar 04, 2021 at 01:41:15PM -0500, Thara Gopinath wrote:

>>

>> Yes it did. The last patch adds fallback for unsupported cases and

>> this will make it pass the fuzz tests.

> 

> Please include this information in the next round.


I will. Thanks!
> 

> Thanks,

> 


-- 
Warm Regards
Thara