From patchwork Tue Jun 18 09:32:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 167121 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3973206ilk; Tue, 18 Jun 2019 02:32:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqy2bf+7ujAm4uBqXncUQT8w1/iDA6m2eWJPzfcmP1JxtckwRmzbwpRiYPID5dwfsrRCnKGW X-Received: by 2002:a63:dc02:: with SMTP id s2mr1805451pgg.286.1560850342833; Tue, 18 Jun 2019 02:32:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560850342; cv=none; d=google.com; s=arc-20160816; b=rFeuK4/Cmnh77XlhgOQqWt5NNO3qSvlKkg9oVLpoDQb/YyXiKexrQOMX+r0KKI4OAE vssOOhKs53tk6xHpanbANj+dEFUr2humrJlBjVVk3krztjxMSzkaaI9IFO4AEpOd99e2 KlLPUo+13V1GWSYReIwsAQnXe+cJ5VwvzKAm5rgglJsZejEoXS3EmtX7CdojN6YbuP5n p+ycuy+YfiEov7mhKzIBMyVydODs0+NPzLkA51rmDEkXuCMWbYAcm0YHQrg4KBhluNNs HSjYgz653dHoO+PC8nQV4N9U9+AqYIKYFT6O2ubNQJL8Yy8Zs42bpSII4LDLXW8lSWNx 8wiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=uIJtJFYthGUMX8rdgQmg7yAqt6VRngy7cSWmscVewUM=; b=YKgbuiH6qMWVDM4QEeGNT70UD5TaI9rz/7cm2s+ZWNGYZyjBDiyW3Fz+xFnFJjr2Al bYkjgqN1+/lM8NaW6Yjg2a9kvmxr3+3NJnEp2/Jh+NB7wzCAB+7nehj6Nu9Fv3YGsMEf KLOKHnRCMPfX0RyUTZAqUVEUKMoBlXFiOMaBcePfKLt45/0NEaO0T8FOhKuAiuaTs0Gn SWmWoz35X4Hmxt2K3BuFaDI5I2RhrtkULdiRLkIB2Mp8ajxWaBeP7Na7BwUZYXyyInCZ db4jdilaLwXpGsVbl1RHH/b/QBo6i1PtokCLxvhABg5FIw+A9UhRaWJO7x8HkbgAg3Ex InbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eUkJi2E1; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9si12421836pgs.364.2019.06.18.02.32.22; Tue, 18 Jun 2019 02:32:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eUkJi2E1; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729259AbfFRJcW (ORCPT + 3 others); Tue, 18 Jun 2019 05:32:22 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36298 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbfFRJcV (ORCPT ); Tue, 18 Jun 2019 05:32:21 -0400 Received: by mail-wm1-f66.google.com with SMTP id u8so2437101wmm.1 for ; Tue, 18 Jun 2019 02:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uIJtJFYthGUMX8rdgQmg7yAqt6VRngy7cSWmscVewUM=; b=eUkJi2E1vjoyNXX3PV3H7C8LZYQJbd3nR64Y5MWfpCwUbeZxpsHB8edKWBz6M9dp7M ic8Ujhx0Hu77yCpuw51OZ81spve5EWDVc9SsPnch0rrCbHAXybZlZb+8R2p9SMG+yzFU s7KsVCJz6r+c8ly9X334WNq9MTFVCgpFiBrluTQfl9xpdWapX0CQW1y6zmnWYkhGYIRB IMKzhWHe/HVJpxUegqx/+JK4Lk1B6f3eQJKsHmpMJnLbkeRxELn/GqitT8l5rW0PsVSz WGRXj0xvInRC7SAuNnhWcUY6Xndy2F/VAxQ79dekzHfGy4uqUQlzdbUGnvTJAtOcssUB 4Cwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uIJtJFYthGUMX8rdgQmg7yAqt6VRngy7cSWmscVewUM=; b=VbmrieiF+0V6Xbt/HTBTOzrYCvWI0O/VY2gIsascZuyJ+5FN2nd5Za5EAEirVpIgyn ASvDkCh+PDO6fjwxXDVZdBOHNtn3sVesgoj23GhIV0uDfAJKkJnv7Tjh9vRRVJNwH0Ux 0aQgb2TOF6eqs56KzwbEf9gZqJTC162iF4rHMUJReorYF1c3bIImRvE0ZsN8LV3dIMHk 68fVw3aofc+fpT53Pe+5TZlFXAMqx9R40M7PtUrihGkwjeN94MVSQCVI5jWHSEB4gyRO YRANGf90vj9iS/OcPvrbMPsQM0h12Ux+fshm1RQoMaun975P2L/V70Yr3piC75ApFlzt cuwQ== X-Gm-Message-State: APjAAAWbyLoha2nMWhBT6gd6ePgEyooruGvQN+62pAWyWn2NOkddqdn1 n0fgYUgyTwP0/KcCLyrZJpxBNg== X-Received: by 2002:a1c:b146:: with SMTP id a67mr2574538wmf.124.1560850339781; Tue, 18 Jun 2019 02:32:19 -0700 (PDT) Received: from sudo.home ([2a01:cb1d:112:6f00:c97b:2293:609c:ae03]) by smtp.gmail.com with ESMTPSA id y1sm1517104wma.32.2019.06.18.02.32.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jun 2019 02:32:18 -0700 (PDT) From: Ard Biesheuvel To: netdev@vger.kernel.org Cc: Ard Biesheuvel , Eric Biggers , linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, edumazet@google.com, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, jbaron@akamai.com, cpaasch@apple.com, David.Laight@aculab.com, ycheng@google.com Subject: [PATCH 0/2] net: fastopen: follow-up tweaks for SipHash switch Date: Tue, 18 Jun 2019 11:32:05 +0200 Message-Id: <20190618093207.13436-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org A pair of tweaks for issues spotted by Eric Biggers. Patch #1 is mostly cosmetic, since the error check it adds is unreachable in practice, and the other changes are syntactic cleanups. Patch #2 adds endian swabbing of the SipHash output for big endian systems so that the in-memory representation is the same as on little endian systems. cc: Eric Biggers cc: linux-crypto@vger.kernel.org cc: herbert@gondor.apana.org.au cc: edumazet@google.com cc: davem@davemloft.net cc: kuznet@ms2.inr.ac.ru cc: yoshfuji@linux-ipv6.org cc: jbaron@akamai.com cc: cpaasch@apple.com cc: David.Laight@aculab.com cc: ycheng@google.com Ard Biesheuvel (2): net: fastopen: make key handling more robust against future changes net: fastopen: use endianness agnostic representation of the cookie include/linux/tcp.h | 2 +- include/net/tcp.h | 5 +-- net/ipv4/tcp_fastopen.c | 34 +++++++++++--------- 3 files changed, 23 insertions(+), 18 deletions(-) -- 2.17.1