mbox series

[v3,0/4] crypto: fix crct10dif for ARM and arm64

Message ID 20190127091655.6262-1-ard.biesheuvel@linaro.org
Headers show
Series crypto: fix crct10dif for ARM and arm64 | expand

Message

Ard Biesheuvel Jan. 27, 2019, 9:16 a.m. UTC 
Fix the issues in both NEON implementations of the CRC-T10DIF routines,
that were reported by Eric's new testing code.

v3:
- fix commit log to state 'at least 16 bytes' not 'more than 16 bytes' (#1-#2)
- add Eric's R-b to all patches

v2:
- keep alignment specifiers where possible (#1)
- clarify/fix commit log (#2)
- add fixes/cc-stable/etc tags
- add patches that drop the now unreacheable code (#3 - #4)

Ard Biesheuvel (4):
  crypto: arm/crct10dif - revert to C code for short inputs
  crypto: arm64/crct10dif - revert to C code for short inputs
  crypto: arm/crct10dif - remove dead code
  crypto: arm64/crct10dif - remove dead code

 arch/arm/crypto/crct10dif-ce-core.S   | 27 +++++---------------
 arch/arm/crypto/crct10dif-ce-glue.c   | 23 +++++------------
 arch/arm64/crypto/crct10dif-ce-core.S | 11 --------
 arch/arm64/crypto/crct10dif-ce-glue.c | 25 +++++-------------
 4 files changed, 19 insertions(+), 67 deletions(-)

-- 
2.20.1

Comments

Herbert Xu Feb. 1, 2019, 6:52 a.m. UTC | #1 
On Sun, Jan 27, 2019 at 10:16:51AM +0100, Ard Biesheuvel wrote:
> Fix the issues in both NEON implementations of the CRC-T10DIF routines,

> that were reported by Eric's new testing code.

> 

> v3:

> - fix commit log to state 'at least 16 bytes' not 'more than 16 bytes' (#1-#2)

> - add Eric's R-b to all patches

> 

> v2:

> - keep alignment specifiers where possible (#1)

> - clarify/fix commit log (#2)

> - add fixes/cc-stable/etc tags

> - add patches that drop the now unreacheable code (#3 - #4)

> 

> Ard Biesheuvel (4):

>   crypto: arm/crct10dif - revert to C code for short inputs

>   crypto: arm64/crct10dif - revert to C code for short inputs

>   crypto: arm/crct10dif - remove dead code

>   crypto: arm64/crct10dif - remove dead code

> 

>  arch/arm/crypto/crct10dif-ce-core.S   | 27 +++++---------------

>  arch/arm/crypto/crct10dif-ce-glue.c   | 23 +++++------------

>  arch/arm64/crypto/crct10dif-ce-core.S | 11 --------

>  arch/arm64/crypto/crct10dif-ce-glue.c | 25 +++++-------------

>  4 files changed, 19 insertions(+), 67 deletions(-)


All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt