From patchwork Thu Nov 9 09:16:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 118403 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp6340632qgn; Thu, 9 Nov 2017 01:11:04 -0800 (PST) X-Google-Smtp-Source: ABhQp+S8zVt6nSsmzFcfDj5cpnfBYKRTswKQzIWJ7+t5eNkUgxWhi7NFrLhfG+b4IE+5+H4p6kTO X-Received: by 10.84.235.198 with SMTP id m6mr3129731plt.153.1510218663935; Thu, 09 Nov 2017 01:11:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510218663; cv=none; d=google.com; s=arc-20160816; b=Mv4IE2u6/ZeSIYuvIQ46EYjfY16TmmYZo9sq+hy7qDxnIZRO1q8Bl5UHeFxSgcbmHm OkH0Td9/x9QsM55+5cMlgL9NRc54VUxEYRWA2/1Az6gCUiFIhn0xpiiQ25Mwifxn+mkI JH44vOT6ufFlNFSXSeKGge5cUEHW2BRJvIBvCuOdMlT1amsH7pcH6amzRYU++1Mf6ev2 5JzthKbWLGB4AIx+hoeEmSHw8b9k1TC7dGYMGx2E7qFPs/q0C9nDuofzCuixMey8rnLs Oh5HcRy0yRN8bwPHvFkMNNhlnDfXLjOZ0EMV44p4yVKvEwyGRzfZNzuFiKAxBroSsNdx D5eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=iWUwRnbnO1jGsx1mjem2Wb97S71wU80epHTi+Hpig00=; b=VG7OgYBIJ2vuam/3A/N441YSlNBzdPcRbxXPlR9hWURU4ylicj6iYJuAHAcGcKT4t1 /0cWJssdfpW2KIYwkyPmDf/P0gvXZQ/0/s8Tkd9DjNXliaeASNAUhVj5MIVbl4WBnHL3 GhGrwuzApe/d5Hs93kN2Fwy8jJDll234aLESbFTQy3ybZfk5CkH2gjsUqW2/eMHcVHpL VMck6TH7oBiJhZEfmlRWeWQGr2G6l1993xBOFpCtFgZKKH1rYzdyx6yqY4/U0KOQjlpl P5RCUJ05J1/46ar2YmBSD1xl85vOalibCVfAde5tn3A9Dn+omK4j20wjOgfwVNldEwNE tHrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i187si6219163pfe.137.2017.11.09.01.11.03; Thu, 09 Nov 2017 01:11:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753906AbdKIJLB (ORCPT + 1 other); Thu, 9 Nov 2017 04:11:01 -0500 Received: from foss.arm.com ([217.140.101.70]:43574 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753894AbdKIJK4 (ORCPT ); Thu, 9 Nov 2017 04:10:56 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 547AD1435; Thu, 9 Nov 2017 01:10:56 -0800 (PST) Received: from sugar.kfn.arm.com (unknown [10.45.48.162]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DC693F246; Thu, 9 Nov 2017 01:10:54 -0800 (PST) From: Gilad Ben-Yossef To: Greg Kroah-Hartman Cc: Ofir Drang , linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 00/10] staging: ccree: fixes and cleanups Date: Thu, 9 Nov 2017 09:16:08 +0000 Message-Id: <1510218980-3549-1-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.7.4 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org This is another batch of ccree fixes & cleanups. The first patch is a bug fix. All others are pure readability and coding style fixes. Changes from v1: - Fix several coding style issues pointed out by Dan Carpenter. - Added two more patches of similar issues that surfaced during the review. Gilad Ben-Yossef (10): staging: ccree: fix leak of import() after init() staging: ccree: make long func call sites readable staging: ccree: simplify AEAD using local var staging: ccree: simplify buf mgr using local vars staging: ccree: fold common code into function staging: ccree: simplify pm manager using local var staging: ccree: remove unneeded cast staging: ccree: remove compare to none zero staging: ccree: remove braces for single statement staging: ccree: remove unused cc_base parameter drivers/staging/ccree/ssi_aead.c | 60 ++-- drivers/staging/ccree/ssi_buffer_mgr.c | 553 ++++++++++++++------------------ drivers/staging/ccree/ssi_buffer_mgr.h | 49 ++- drivers/staging/ccree/ssi_cipher.c | 39 ++- drivers/staging/ccree/ssi_driver.c | 51 ++- drivers/staging/ccree/ssi_driver.h | 2 +- drivers/staging/ccree/ssi_hash.c | 201 ++++++------ drivers/staging/ccree/ssi_ivgen.c | 4 +- drivers/staging/ccree/ssi_pm.c | 46 ++- drivers/staging/ccree/ssi_pm.h | 12 +- drivers/staging/ccree/ssi_request_mgr.c | 29 +- drivers/staging/ccree/ssi_request_mgr.h | 6 +- drivers/staging/ccree/ssi_sram_mgr.c | 13 +- drivers/staging/ccree/ssi_sram_mgr.h | 6 +- 14 files changed, 502 insertions(+), 569 deletions(-) -- 2.7.4 Reviewed-by: Dan Carpenter