| Message ID | 1506935008-14240-1-git-send-email-gilad@benyossef.com |
|---|---|
| Headers | show |
| Series | staging: ccree: logging related coding style fixes | expand |
On Mon, 2017-10-02 at 10:03 +0100, Gilad Ben-Yossef wrote: > Introduce a DEV macro to retrieve struct device from private > data structure in preparation to replacing custom logging > macros with proper dev_dbg and friends which require struct > device. [] > diff --git a/drivers/staging/ccree/ssi_driver.h b/drivers/staging/ccree/ssi_driver.h [] > @@ -103,6 +103,8 @@ > #define SSI_LOG_DEBUG(format, ...) do {} while (0) > #endif > > +#define DEV(drvdata) ((&(drvdata)->plat_dev->dev)) The name seems not particularly descriptive. It seems a longer name would not be too bad. Perhaps static inline struct device *drvdata_to_dev(struct ssi_drvdata *drvdata) { return &drvdata->plat_dev->dev; }
The following patch set cleans up some code and builds upon this to replace ccree custom logging macros with the generic device dev_* facilities, handles the resulting fallout and further simplifies logging handling in some OOM error handling code path exposed by checkpatch following the change. Patch set based upon commit 1cd5929ab675 ("staging: greybus: light: remove unnecessary error check") in the staging-next tree. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Gilad Ben-Yossef (4): staging: ccree: remove sysfs if of deleted code staging: ccree: simplify access to struct device staging: ccree: move to generic device log infra staging: ccree: simplify OOM handling drivers/staging/ccree/ssi_aead.c | 237 +++++++++++-------- drivers/staging/ccree/ssi_buffer_mgr.c | 408 +++++++++++++++----------------- drivers/staging/ccree/ssi_buffer_mgr.h | 5 +- drivers/staging/ccree/ssi_cipher.c | 158 ++++++------- drivers/staging/ccree/ssi_driver.c | 163 ++++++------- drivers/staging/ccree/ssi_driver.h | 14 +- drivers/staging/ccree/ssi_fips.c | 12 +- drivers/staging/ccree/ssi_hash.c | 374 ++++++++++++++--------------- drivers/staging/ccree/ssi_ivgen.c | 18 +- drivers/staging/ccree/ssi_pm.c | 30 +-- drivers/staging/ccree/ssi_request_mgr.c | 107 +++++---- drivers/staging/ccree/ssi_sram_mgr.c | 30 +-- drivers/staging/ccree/ssi_sysfs.c | 269 +-------------------- 13 files changed, 771 insertions(+), 1054 deletions(-) -- 2.7.4