[BlueZ,v2,04/10] build: drop %.rules make rule

Message ID	20240216-hook-fixup-v2-4-a6b192d1a6ad@gmail.com
State	New
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 409E21487F6 for <linux-bluetooth@vger.kernel.org>; Fri, 16 Feb 2024 23:11:11 +0000 (UTC) From: Emil Velikov via B4 Relay <devnull+emil.l.velikov.gmail.com@kernel.org> Date: Fri, 16 Feb 2024 23:11:08 +0000 Subject: [PATCH BlueZ v2 04/10] build: drop %.rules make rule Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240216-hook-fixup-v2-4-a6b192d1a6ad@gmail.com> References: <20240216-hook-fixup-v2-0-a6b192d1a6ad@gmail.com> In-Reply-To: <20240216-hook-fixup-v2-0-a6b192d1a6ad@gmail.com> To: linux-bluetooth@vger.kernel.org Reply-To: <emil.l.velikov@gmail.com>
Series	Handful of build fixes and cleanups \| expand [BlueZ,v2,00/10] Handful of build fixes and cleanups [BlueZ,v2,01/10] build: rework {install-data,uninstall}-hook [BlueZ,v2,02/10] build: install obexd (dbus,systemd} services as needed [BlueZ,v2,03/10] build: handle relative libexecdir instances [BlueZ,v2,04/10] build: drop %.rules make rule [BlueZ,v2,05/10] build: simplify coverage handling [BlueZ,v2,06/10] build: drop explicit -fPIC from obexd CFLAGS [BlueZ,v2,07/10] gitignore: add org.bluez.obex.service [BlueZ,v2,08/10] build: obexd: remove duplicate include -I$(builddir)/lib [BlueZ,v2,09/10] gitignore: ignore all manual pages [BlueZ,v2,10/10] build: move public headers to sub-folder

Message ID

20240216-hook-fixup-v2-4-a6b192d1a6ad@gmail.com

State

New

Headers

From: Emil Velikov via B4 Relay <devnull+emil.l.velikov.gmail.com@kernel.org>
Date: Fri, 16 Feb 2024 23:11:08 +0000
Subject: [PATCH BlueZ v2 04/10] build: drop %.rules make rule
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240216-hook-fixup-v2-4-a6b192d1a6ad@gmail.com>
References: <20240216-hook-fixup-v2-0-a6b192d1a6ad@gmail.com>
In-Reply-To: <20240216-hook-fixup-v2-0-a6b192d1a6ad@gmail.com>
To: linux-bluetooth@vger.kernel.org
Reply-To: <emil.l.velikov@gmail.com>

Series

Handful of build fixes and cleanups | expand

Commit Message

Emil Velikov via B4 Relay Feb. 16, 2024, 11:11 p.m. UTC

From: Emil Velikov <emil.l.velikov@gmail.com>

There's a single file, so we can drop the makefile rule and rename it
accordingly.
---
 .gitignore                                | 2 +-
 Makefile.am                               | 8 +-------
 tools/{hid2hci.rules => 97-hid2hci.rules} | 0
 3 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/.gitignore b/.gitignore
index c5d7f90ab..a5954658a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -37,7 +37,7 @@  lib/bluez.pc
 lib/bluetooth
 src/builtin.h
 src/bluetoothd
-tools/97-hid2hci.rules
+tools/hid2hci.rules
 
 profiles/cups/bluetooth
 profiles/iap/iapd
diff --git a/Makefile.am b/Makefile.am
index 5717c3dac..2d43493aa 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -429,11 +429,9 @@  if HID2HCI
 rulesdir = $(UDEV_DIR)/rules.d
 
 rules_DATA = tools/97-hid2hci.rules
-
-CLEANFILES += $(rules_DATA)
 endif
 
-EXTRA_DIST += tools/hid2hci.rules
+EXTRA_DIST += tools/97-hid2hci.rules
 
 if TEST
 testdir = $(pkglibdir)/test
@@ -758,10 +756,6 @@  endif
 src/builtin.h: src/genbuiltin $(builtin_sources)
 	$(AM_V_GEN)$(srcdir)/src/genbuiltin $(builtin_modules) > $@
 
-tools/%.rules:
-	$(AM_V_at)$(MKDIR_P) tools
-	$(AM_V_GEN)cp $(srcdir)/$(subst 97-,,$@) $@
-
 $(lib_libbluetooth_la_OBJECTS): $(local_headers)
 
 lib/bluetooth/%.h: lib/%.h
diff --git a/tools/hid2hci.rules b/tools/97-hid2hci.rules
similarity index 100%
rename from tools/hid2hci.rules
rename to tools/97-hid2hci.rules

[BlueZ,v2,04/10] build: drop %.rules make rule

Commit Message

Patch