mbox series

[BlueZ,0/2] shared/bass: Introduce Add Source opcode handler

Message ID 20230623074657.16618-1-iulia.tanasescu@nxp.com
Headers show
Series shared/bass: Introduce Add Source opcode handler | expand

Message

Iulia Tanasescu June 23, 2023, 7:46 a.m. UTC 
This patch series adds the BASS control point handler
for the Add Source operation.

If instructed by a Client through the Add Source opcode,
the BASS Server attempts to synchronize to a Broadcast
Source, by opening a btio channel.

The BT_IO_OPT_ISO_BC_ADDR btio option has been added,
to allow binding a socket to a broadcast address.

The BASS adapter_probe callback has been implemented,
in order to automatically configure BASS into the adapter
database. The adapter bdaddr is also stored along with the
BASS database configuration, and this address will be used
as the source address when binding the btio channel.

Iulia Tanasescu (2):
  btio: Add option for binding iso broadcast address
  shared/bass: Introduce Add Source opcode handler

 Makefile.am           |   2 +-
 btio/btio.c           |  56 +++++-
 btio/btio.h           |   3 +-
 profiles/audio/bass.c |  26 ++-
 src/shared/bass.c     | 424 ++++++++++++++++++++++++++++++++++++++++--
 src/shared/bass.h     |  14 +-
 unit/test-bass.c      |   2 +-
 7 files changed, 498 insertions(+), 29 deletions(-)


base-commit: 37042ca9c6ddcdbbb0899b3d62238935cd53f443

Comments

Luiz Augusto von Dentz June 26, 2023, 8:04 p.m. UTC | #1 
Hi Iulia,

On Fri, Jun 23, 2023 at 12:51 AM Iulia Tanasescu
<iulia.tanasescu@nxp.com> wrote:
>
> This patch series adds the BASS control point handler
> for the Add Source operation.
>
> If instructed by a Client through the Add Source opcode,
> the BASS Server attempts to synchronize to a Broadcast
> Source, by opening a btio channel.
>
> The BT_IO_OPT_ISO_BC_ADDR btio option has been added,
> to allow binding a socket to a broadcast address.

Im having second thoughts on this, Im not sure if it is a good idea to
introduce BT_IO_OPT_ISO_BC_ADDR, there are already options to set the
address and address type, perhaps we should add what is missing e.g.
num of bis, etc. At least on iso-test the logic I used was that if a
destination is given for listen then it must be a broadcast address.

> The BASS adapter_probe callback has been implemented,
> in order to automatically configure BASS into the adapter
> database. The adapter bdaddr is also stored along with the
> BASS database configuration, and this address will be used
> as the source address when binding the btio channel.
>
> Iulia Tanasescu (2):
>   btio: Add option for binding iso broadcast address
>   shared/bass: Introduce Add Source opcode handler
>
>  Makefile.am           |   2 +-
>  btio/btio.c           |  56 +++++-
>  btio/btio.h           |   3 +-
>  profiles/audio/bass.c |  26 ++-
>  src/shared/bass.c     | 424 ++++++++++++++++++++++++++++++++++++++++--
>  src/shared/bass.h     |  14 +-
>  unit/test-bass.c      |   2 +-
>  7 files changed, 498 insertions(+), 29 deletions(-)
>
>
> base-commit: 37042ca9c6ddcdbbb0899b3d62238935cd53f443
> --
> 2.34.1
>