mbox series

[BlueZ,v3,0/3] audio/avrcp: Determine Absolute Volume support from feature category 2

Message ID 20230311003826.454858-1-marijn.suijten@somainline.org
Headers show
Series audio/avrcp: Determine Absolute Volume support from feature category 2 | expand

Message

Marijn Suijten March 11, 2023, 12:38 a.m. UTC 
Changes since v2:

- New patch to guard target-less SetAbsoluteVolume calls with main.conf
  config;
- New patch to more strictly require category-2 _and_ peer CT/TG 1.4;
- Use main.conf to relax 1.4 version constraint for TGs registering
  AbsVol notifications;

v2: https://marc.info/?l=linux-bluetooth&m=163519566912788&w=2

I'd rather revert 179ccb936 ("avrcp: Set volume if volume changed event
is registered") entirely, paired with additional checks in common
codepaths for controller and target not being NULL when sending and
receiving control messages respectively (which then don't need to be
double-checked in the AbsVol codepaths for example).

Marijn Suijten (3):
  audio/avrcp: Guard SetAbsoluteVolume without target behind config
    value
  audio/avrcp: Only allow absolute volume call/event on category-2 peers
  audio/avrcp: Determine Absolute Volume support from feature category 2

 profiles/audio/avrcp.c | 53 ++++++++++++++++++++++++++++++++++++------
 src/btd.h              |  6 +++++
 src/main.c             | 21 +++++++++++++++++
 src/main.conf          | 12 ++++++++++
 4 files changed, 85 insertions(+), 7 deletions(-)

--
2.39.2