mbox series

[BlueZ,v2,0/9] properties_changed: check for NULL iterator

Message ID 20220923145602.25872-1-ceggers@arri.de
Headers show
Series properties_changed: check for NULL iterator | expand

Message

Christian Eggers Sept. 23, 2022, 2:55 p.m. UTC 
v2:
----
- 7/9: don't call memcpy(x, NULL, 0) [Scan Build]
- 9/9: shorten GIT summary [GitLint]

Christian Eggers (9):
  advertising: parse_secondary: fix loop condition
  advertising: parse_secondary: fix mask value
  advertising: parse_secondary: check for NULL iterator
  advertising: parse_min_interval: reset min_interval if iter is NULL
  advertising: parse_[min|max]_interval: reset value if iter is NULL
  advertising: parse_tx_power: reset value if iter is NULL
  client/gatt: proxy_property_changed: check for NULL iterator
  gatt: proxy_property_changed: check for NULL iterator
  battery: provided_battery_property_changed_cb: check iterator

 client/gatt.c       | 17 ++++++++++-------
 src/advertising.c   | 22 +++++++++++++++++-----
 src/battery.c       | 10 ++++++----
 src/gatt-database.c | 20 +++++++++++---------
 4 files changed, 44 insertions(+), 25 deletions(-)

Comments

Luiz Augusto von Dentz Sept. 23, 2022, 7:18 p.m. UTC | #1 
Hi Christian,

On Fri, Sep 23, 2022 at 8:02 AM Christian Eggers <ceggers@arri.de> wrote:

Perhaps you should rephrase to mention the NULL iter is actually the
result of invalidate properties.

> v2:
> ----
> - 7/9: don't call memcpy(x, NULL, 0) [Scan Build]
> - 9/9: shorten GIT summary [GitLint]
>
> Christian Eggers (9):
>   advertising: parse_secondary: fix loop condition
>   advertising: parse_secondary: fix mask value
>   advertising: parse_secondary: check for NULL iterator
>   advertising: parse_min_interval: reset min_interval if iter is NULL
>   advertising: parse_[min|max]_interval: reset value if iter is NULL
>   advertising: parse_tx_power: reset value if iter is NULL
>   client/gatt: proxy_property_changed: check for NULL iterator
>   gatt: proxy_property_changed: check for NULL iterator
>   battery: provided_battery_property_changed_cb: check iterator
>
>  client/gatt.c       | 17 ++++++++++-------
>  src/advertising.c   | 22 +++++++++++++++++-----
>  src/battery.c       | 10 ++++++----
>  src/gatt-database.c | 20 +++++++++++---------
>  4 files changed, 44 insertions(+), 25 deletions(-)
>
> --
> 2.35.3
>
patchwork-bot+bluetooth@kernel.org Sept. 23, 2022, 8:50 p.m. UTC | #2 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 23 Sep 2022 16:55:53 +0200 you wrote:
> v2:
> ----
> - 7/9: don't call memcpy(x, NULL, 0) [Scan Build]
> - 9/9: shorten GIT summary [GitLint]
> 
> Christian Eggers (9):
>   advertising: parse_secondary: fix loop condition
>   advertising: parse_secondary: fix mask value
>   advertising: parse_secondary: check for NULL iterator
>   advertising: parse_min_interval: reset min_interval if iter is NULL
>   advertising: parse_[min|max]_interval: reset value if iter is NULL
>   advertising: parse_tx_power: reset value if iter is NULL
>   client/gatt: proxy_property_changed: check for NULL iterator
>   gatt: proxy_property_changed: check for NULL iterator
>   battery: provided_battery_property_changed_cb: check iterator
> 
> [...]

Here is the summary with links:
  - [BlueZ,v2,1/9] advertising: parse_secondary: fix loop condition
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=47821c473102
  - [BlueZ,v2,2/9] advertising: parse_secondary: fix mask value
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2e4327816587
  - [BlueZ,v2,3/9] advertising: parse_secondary: check for NULL iterator
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=732eaa7ccf85
  - [BlueZ,v2,4/9] advertising: parse_min_interval: reset min_interval if iter is NULL
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=abfb3a807c39
  - [BlueZ,v2,5/9] advertising: parse_[min|max]_interval: reset value if iter is NULL
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a18d66862da1
  - [BlueZ,v2,6/9] advertising: parse_tx_power: reset value if iter is NULL
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=47346e5390bb
  - [BlueZ,v2,7/9] client/gatt: proxy_property_changed: check for NULL iterator
    (no matching commit)
  - [BlueZ,v2,8/9] gatt: proxy_property_changed: check for NULL iterator
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f5cbe08af22e
  - [BlueZ,v2,9/9] battery: provided_battery_property_changed_cb: check iterator
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=15895e401e1e

You are awesome, thank you!