mbox series

[BlueZ,v2,0/5] OOB Authentication improvements

Message ID 20210519182150.1680987-1-brian.gix@intel.com
Headers show
Series OOB Authentication improvements | expand

Message

Brian Gix May 19, 2021, 6:21 p.m. UTC 
This patch set fixes some minor bugs, and adds explicit support for all
currently supported Provisioning authentication methods.

v2: Added prov-acceptor queuing, and fixed whitespace issues

Brian Gix (5):
  mesh: Fix delivery of PB-ACK to acceptors
  nesh: Normalize endian of public/private ECC keys
  tools/mesh: Add all supported OOB methods to cfgclient
  test/mesh: Add support for testing more OOB auth
  mesh: Add single threading to prov-acp ob messaging

 mesh/pb-adv.c          |  1 -
 mesh/prov-acceptor.c   | 96 +++++++++++++++++++++++++++---------------
 mesh/prov-initiator.c  |  3 ++
 mesh/provision.h       |  1 +
 test/agent.py          | 23 ++++++++++
 tools/mesh-cfgclient.c | 32 +++++++++++---
 6 files changed, 116 insertions(+), 40 deletions(-)

Comments

Brian Gix May 19, 2021, 6:33 p.m. UTC | #1 
On Wed, 2021-05-19 at 11:30 -0700, Tedd Ho-Jeong An wrote:
> Hi Brian,

> 

> On Wed, 2021-05-19 at 11:21 -0700, Brian Gix wrote:

> > Rwmove unneeded initialization that prevented the Acceptor roll of ever

> 

> Normally checkpatch.pl is good at catching a typo but it couldn't catch "Rwmove".


Thanks Tedd -- If no other issues are found, I will fix when it is applied.

> > recognizing a valid PB-ACK.

> > ---

> >  mesh/pb-adv.c | 1 -

> >  1 file changed, 1 deletion(-)

> > 

> > diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c

> > index c74dae79f..83f922aa8 100644

> > --- a/mesh/pb-adv.c

> > +++ b/mesh/pb-adv.c

> > @@ -358,7 +358,6 @@ static void pb_adv_packet(void *user_data, const uint8_t *pkt, uint16_t len)

> >  		first = !session->link_id;

> >  		session->link_id = link_id;

> >  		session->last_peer_trans_num = 0xFF;

> > -		session->local_acked = 0xFF;

> >  		session->peer_trans_num = 0x00;

> >  		session->local_trans_num = 0x7F;

> >  		session->opened = true;

> 

> Regards,

> Tedd

>