mbox series

[v2,00/12] net/Bluetooth: correct the use of print format

Message ID 1621576788-48092-1-git-send-email-yekai13@huawei.com
Headers show
Series net/Bluetooth: correct the use of print format | expand

Message

yekai (A) May 21, 2021, 5:59 a.m. UTC 
According to Documentation/core-api/printk-formats.rst,
Use the correct print format. 
1. Printing an unsigned int value should use %u instead of %d.
2. Printing an unsigned long value should use %lu instead of %ld.
Otherwise printk() might end up displaying negative numbers.

changes v1 -> v2:
	fix some style problems

Kai Ye (12):
  net/Bluetooth/bnep - use the correct print format
  net/Bluetooth/cmtp - use the correct print format
  net/Bluetooth/hidp - use the correct print format
  net/Bluetooth/rfcomm - use the correct print format
  net/Bluetooth/6lowpan - use the correct print format
  net/Bluetooth/a2mp - use the correct print format
  net/Bluetooth/amp - use the correct print format
  net/Bluetooth/hci - use the correct print format
  net/Bluetooth/mgmt - use the correct print format
  net/Bluetooth/msft - use the correct print format
  net/Bluetooth/sco - use the correct print format
  net/Bluetooth/smp - use the correct print format

 net/bluetooth/6lowpan.c     | 16 +++++------
 net/bluetooth/a2mp.c        | 24 ++++++++--------
 net/bluetooth/amp.c         |  6 ++--
 net/bluetooth/bnep/core.c   |  8 +++---
 net/bluetooth/cmtp/capi.c   | 22 +++++++--------
 net/bluetooth/hci_conn.c    |  8 +++---
 net/bluetooth/hci_core.c    | 48 ++++++++++++++++----------------
 net/bluetooth/hci_event.c   | 24 ++++++++--------
 net/bluetooth/hci_request.c |  8 +++---
 net/bluetooth/hci_sock.c    |  6 ++--
 net/bluetooth/hci_sysfs.c   |  2 +-
 net/bluetooth/hidp/core.c   |  6 ++--
 net/bluetooth/mgmt.c        | 16 +++++------
 net/bluetooth/mgmt_config.c |  4 +--
 net/bluetooth/msft.c        |  2 +-
 net/bluetooth/rfcomm/core.c | 68 ++++++++++++++++++++++-----------------------
 net/bluetooth/rfcomm/sock.c |  8 +++---
 net/bluetooth/rfcomm/tty.c  | 10 +++----
 net/bluetooth/sco.c         |  8 +++---
 net/bluetooth/smp.c         |  6 ++--
 20 files changed, 150 insertions(+), 150 deletions(-)

Comments

Marcel Holtmann June 2, 2021, 8:18 p.m. UTC | #1 
Hi Kai,

> According to Documentation/core-api/printk-formats.rst,

> Use the correct print format. 

> 1. Printing an unsigned int value should use %u instead of %d.

> 2. Printing an unsigned long value should use %lu instead of %ld.

> Otherwise printk() might end up displaying negative numbers.

> 

> changes v1 -> v2:

> 	fix some style problems

> 

> Kai Ye (12):

>  net/Bluetooth/bnep - use the correct print format

>  net/Bluetooth/cmtp - use the correct print format

>  net/Bluetooth/hidp - use the correct print format

>  net/Bluetooth/rfcomm - use the correct print format

>  net/Bluetooth/6lowpan - use the correct print format

>  net/Bluetooth/a2mp - use the correct print format

>  net/Bluetooth/amp - use the correct print format

>  net/Bluetooth/hci - use the correct print format

>  net/Bluetooth/mgmt - use the correct print format

>  net/Bluetooth/msft - use the correct print format

>  net/Bluetooth/sco - use the correct print format

>  net/Bluetooth/smp - use the correct print format


please fix the commit message to apply with expected style. Fixing up 12 patches manually is not something I am going to do.

Regards

Marcel