mbox series

[v3,0/5] Enable Bluetooth functinality for WCN6750

Message ID 1620322392-27148-1-git-send-email-gubbaven@codeaurora.org
Headers show
Series Enable Bluetooth functinality for WCN6750 | expand

Message

Venkata Lakshmi Narayana Gubba May 6, 2021, 5:33 p.m. UTC
These patches enables Bluetooth functinalties for new Qualcomm
Bluetooth SoC wcn6750.

Venkata Lakshmi Narayana Gubba (5):
  Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6750
  Bluetooth: btqca: Add support for firmware image with mbn type for
    WCN6750
  Bluetooth: btqca: Moved extracting rom version info to common place
  dt-bindings: net: bluetooth: Convert Qualcomm BT binding to DT schema
  dt-bindings: net: bluetooth: Add device tree bindings for QTI chip
    wcn6750

 .../devicetree/bindings/net/qualcomm-bluetooth.txt |  69 --------
 .../bindings/net/qualcomm-bluetooth.yaml           | 182 +++++++++++++++++++++
 drivers/bluetooth/btqca.c                          |  91 ++++++++---
 drivers/bluetooth/btqca.h                          |  14 +-
 drivers/bluetooth/hci_qca.c                        | 114 ++++++++++---
 5 files changed, 354 insertions(+), 116 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
 create mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml

Comments

Rob Herring May 7, 2021, 1:19 a.m. UTC | #1
On Thu, 06 May 2021 23:03:12 +0530, Venkata Lakshmi Narayana Gubba wrote:
> This patch enables regulators and gpios for the Qualcomm Bluetooth wcn6750
> controller.
> 
> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
> ---
>  .../bindings/net/qualcomm-bluetooth.yaml           | 71 ++++++++++++++++++++++
>  1 file changed, 71 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Marcel Holtmann May 7, 2021, 6:55 a.m. UTC | #2
Hi Venkata,

>> Converted Qualcomm Bluetooth binidings to DT schema.

>> 

>> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>

>> ---

>> .../devicetree/bindings/net/qualcomm-bluetooth.txt |  69 -------------

>> .../bindings/net/qualcomm-bluetooth.yaml           | 111 +++++++++++++++++++++

>> 2 files changed, 111 insertions(+), 69 deletions(-)

>> delete mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt

>> create mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml

> 

> 

>> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml

>> new file mode 100644

>> index 0000000..3f3ec4d

>> --- /dev/null

>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml

>> @@ -0,0 +1,111 @@

>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

>> +%YAML 1.2

>> +---

>> +$id: http://devicetree.org/schemas/net/qualcomm-bluetooth.yaml#

>> +$schema: http://devicetree.org/meta-schemas/core.yaml#

>> +

>> +title: Qualcomm Bluetooth Chips

>> +

>> +maintainers:

>> +  - Marcel Holtmann <marcel@holtmann.org>

> 

> This should be someone who cares about Qcom BT.


yes, please, assign this to someone that knows the hardware.

Rob, can we leave this out for now if there is no dedicated person?

Regards

Marcel
Rob Herring May 7, 2021, 5:19 p.m. UTC | #3
On Fri, May 7, 2021 at 1:55 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Venkata,
>
> >> Converted Qualcomm Bluetooth binidings to DT schema.
> >>
> >> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
> >> ---
> >> .../devicetree/bindings/net/qualcomm-bluetooth.txt |  69 -------------
> >> .../bindings/net/qualcomm-bluetooth.yaml           | 111 +++++++++++++++++++++
> >> 2 files changed, 111 insertions(+), 69 deletions(-)
> >> delete mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> >> create mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> >
> >
> >> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> >> new file mode 100644
> >> index 0000000..3f3ec4d
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> >> @@ -0,0 +1,111 @@
> >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/net/qualcomm-bluetooth.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Qualcomm Bluetooth Chips
> >> +
> >> +maintainers:
> >> +  - Marcel Holtmann <marcel@holtmann.org>
> >
> > This should be someone who cares about Qcom BT.
>
> yes, please, assign this to someone that knows the hardware.
>
> Rob, can we leave this out for now if there is no dedicated person?

No, it's required. It can be me if it comes to that. However, if no
one can be bothered to step up, then we should just remove it perhaps.
QCom is a big company, I'm sure they can find some name.

Rob
Marcel Holtmann May 13, 2021, 3:21 p.m. UTC | #4
Hi Rob,

>>>> Converted Qualcomm Bluetooth binidings to DT schema.
>>>> 
>>>> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
>>>> ---
>>>> .../devicetree/bindings/net/qualcomm-bluetooth.txt |  69 -------------
>>>> .../bindings/net/qualcomm-bluetooth.yaml           | 111 +++++++++++++++++++++
>>>> 2 files changed, 111 insertions(+), 69 deletions(-)
>>>> delete mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>> create mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>>> 
>>> 
>>>> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>>>> new file mode 100644
>>>> index 0000000..3f3ec4d
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>>>> @@ -0,0 +1,111 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/net/qualcomm-bluetooth.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Qualcomm Bluetooth Chips
>>>> +
>>>> +maintainers:
>>>> +  - Marcel Holtmann <marcel@holtmann.org>
>>> 
>>> This should be someone who cares about Qcom BT.
>> 
>> yes, please, assign this to someone that knows the hardware.
>> 
>> Rob, can we leave this out for now if there is no dedicated person?
> 
> No, it's required. It can be me if it comes to that. However, if no
> one can be bothered to step up, then we should just remove it perhaps.
> QCom is a big company, I'm sure they can find some name.

I hope so as well since my name is clearly the wrong one there. I have too little knowledge about that hardware and the platforms it is used in.

Regards

Marcel
Venkata Lakshmi Narayana Gubba May 18, 2021, 4:30 p.m. UTC | #5
Hi Marcel and Rob,

On 2021-05-13 20:51, Marcel Holtmann wrote:
> Hi Rob,

> 

>>>>> Converted Qualcomm Bluetooth binidings to DT schema.

>>>>> 

>>>>> Signed-off-by: Venkata Lakshmi Narayana Gubba 

>>>>> <gubbaven@codeaurora.org>

>>>>> ---

>>>>> .../devicetree/bindings/net/qualcomm-bluetooth.txt |  69 

>>>>> -------------

>>>>> .../bindings/net/qualcomm-bluetooth.yaml           | 111 

>>>>> +++++++++++++++++++++

>>>>> 2 files changed, 111 insertions(+), 69 deletions(-)

>>>>> delete mode 100644 

>>>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt

>>>>> create mode 100644 

>>>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml

>>>> 

>>>> 

>>>>> diff --git 

>>>>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml 

>>>>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml

>>>>> new file mode 100644

>>>>> index 0000000..3f3ec4d

>>>>> --- /dev/null

>>>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml

>>>>> @@ -0,0 +1,111 @@

>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

>>>>> +%YAML 1.2

>>>>> +---

>>>>> +$id: http://devicetree.org/schemas/net/qualcomm-bluetooth.yaml#

>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#

>>>>> +

>>>>> +title: Qualcomm Bluetooth Chips

>>>>> +

>>>>> +maintainers:

>>>>> +  - Marcel Holtmann <marcel@holtmann.org>

>>>> 

>>>> This should be someone who cares about Qcom BT.

>>> 

>>> yes, please, assign this to someone that knows the hardware.

>>> 

>>> Rob, can we leave this out for now if there is no dedicated person?

>> 

>> No, it's required. It can be me if it comes to that. However, if no

>> one can be bothered to step up, then we should just remove it perhaps.

>> QCom is a big company, I'm sure they can find some name.

> 

> I hope so as well since my name is clearly the wrong one there. I have

> too little knowledge about that hardware and the platforms it is used

> in.

> 

[Venkata]:
I will update maintainers names in next patchset.
> Regards

> 

> Marcel


Regards,
Venkata.