From patchwork Mon Aug 11 12:49:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 35204 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f72.google.com (mail-yh0-f72.google.com [209.85.213.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4277820540 for ; Mon, 11 Aug 2014 12:49:11 +0000 (UTC) Received: by mail-yh0-f72.google.com with SMTP id f73sf27997677yha.3 for ; Mon, 11 Aug 2014 05:49:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=aeuW61/I05TD3HyR90R4I1TSoOaTxR6gYHMLFmydR0Q=; b=R93HcPkdnoe6C+i7FG+ZWuXqaL1nlpAXTizSovKg7ySb2VnUi1MZo1s0LFQVtj4NCh QC02E17fLzxl+Cstx8Bsb96YZkO/9w8w6pSIiaXfOoocDj647z76uiA8usymAaQc1ihr CnDQtiTk+pggKoI0sOT+l0rOsqJEwsLyjl941Mon4Jsq9WaROhVLWSRXEOWNe+m8h6Of 9rCC08UNweSfSC7WesTaYAq7moBtos8W8GwOW+27PvO+gBCV283rRedCuEOnIzvjufXn Np3pSQHsQmccN98VZBhCB+ebw97I6+lFw5V91ZU/St/ZRcxTCQYDHV38cc7cOhhi8xV7 oKZw== X-Gm-Message-State: ALoCoQkocp6vAu4ZUDJAOr6pW5FDW/O0UXwozt6W0vFWtgrxkPHUANqcggFkI7G9nHKi2YpR9MA8 X-Received: by 10.236.31.68 with SMTP id l44mr13475233yha.29.1407761350962; Mon, 11 Aug 2014 05:49:10 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.108.230 with SMTP id j93ls1396863qgf.31.gmail; Mon, 11 Aug 2014 05:49:10 -0700 (PDT) X-Received: by 10.52.243.135 with SMTP id wy7mr4483vdc.82.1407761350821; Mon, 11 Aug 2014 05:49:10 -0700 (PDT) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id s5si6455535vcu.2.2014.08.11.05.49.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 11 Aug 2014 05:49:10 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id la4so11387667vcb.23 for ; Mon, 11 Aug 2014 05:49:10 -0700 (PDT) X-Received: by 10.52.61.136 with SMTP id p8mr18806312vdr.15.1407761350714; Mon, 11 Aug 2014 05:49:10 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp162099vcb; Mon, 11 Aug 2014 05:49:10 -0700 (PDT) X-Received: by 10.70.103.132 with SMTP id fw4mr23900827pdb.99.1407761349660; Mon, 11 Aug 2014 05:49:09 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s5si9796649pdd.91.2014.08.11.05.49.09 for ; Mon, 11 Aug 2014 05:49:09 -0700 (PDT) Received-SPF: none (google.com: linux-arm-msm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbaHKMtI (ORCPT + 4 others); Mon, 11 Aug 2014 08:49:08 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:47169 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbaHKMtH (ORCPT ); Mon, 11 Aug 2014 08:49:07 -0400 Received: by mail-oa0-f48.google.com with SMTP id m1so5951520oag.7 for ; Mon, 11 Aug 2014 05:49:06 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.175.138 with SMTP id ca10mr50396867oec.15.1407761346130; Mon, 11 Aug 2014 05:49:06 -0700 (PDT) Received: by 10.182.33.33 with HTTP; Mon, 11 Aug 2014 05:49:06 -0700 (PDT) In-Reply-To: References: Date: Mon, 11 Aug 2014 14:49:06 +0200 Message-ID: Subject: Re: Failure booting DragonBoard APQ8060 after mach-qcom introduction From: Linus Walleij To: Kumar Gala , "linux-arm-msm@vger.kernel.org" Cc: Bjorn Andersson Sender: linux-arm-msm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Mon, Aug 11, 2014 at 1:42 PM, Linus Walleij wrote: > On Mon, Aug 11, 2014 at 1:21 PM, Linus Walleij wrote: > >> The symptom is that not even earlyprints come up if I put some >> printascii() in start_kernel. > > Bah that was me not realizing that the defaults for DEBUG_UART_PHYS > and DEBUG_UART_VIRT has to be set up properly... now I get the > earlyprints. > > It seems to hang in the gsbi driver probe, off to debug. It appears that this oneliner gets the kernel booting again: The kernel hangs during disable/unprepare of the hclk for the GSBI. Turning off hclk's could be dangerous if there are vital system components using the hclk which does not yet have a reference taken in the kernel, due to missing drivers or similar. Any ideas? Yours, Linus Walleij Tested-by: Linus Walleij --- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c index 447458e696a9..1759a3c9140a 100644 --- a/drivers/soc/qcom/qcom_gsbi.c +++ b/drivers/soc/qcom/qcom_gsbi.c @@ -57,7 +57,7 @@ static int gsbi_probe(struct platform_device *pdev) /* make sure the gsbi control write is not reordered */ wmb(); - clk_disable_unprepare(hclk); + //clk_disable_unprepare(hclk); return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); }