From patchwork Mon Jan 28 06:41:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 156698 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3089685jaa; Sun, 27 Jan 2019 22:45:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN7esCF4dc3fi6PGONdapWQxqBF0O0Yvn0NAy72p1JEf2IuTcqDfJveYkh7lynlkv2MIPyv6 X-Received: by 2002:a63:cd4c:: with SMTP id a12mr19098541pgj.252.1548657915324; Sun, 27 Jan 2019 22:45:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548657915; cv=none; d=google.com; s=arc-20160816; b=KHVd7o19ZIq9gT/p3I0J8jowdRqtQeeiyplIlkOdMvansLm2KCDk8qBQYTPrFcnOrE r8cRcleY+owdwm8s4t4LzTbhwvoUkkscK6rSmXDwX5vkEETwceV88R23oFnCOmvMUibb KJnPgPIzJhqtDj7Qcl+XTC7T3MBgWppiK4Rsy6e2D0NJUPzWlNMXShD5WYSTrSykNY12 pXGTUwkyi0IUGIic1/cHFZ/ZWEca1DMd0VXEa2dyfMR3K2erIuQAQl3LrQnS4e/YsCfq u0gjuFsmSKQxr8jDprBSOljiXiUkMX84lmBWw2vvLjFOqsRltp1aVj/zQRbK+nDqxNw2 Fzaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=1aBBJ84u3ymAhFuzjAtS5nCyk99H9ZXfxJBF/z7RCfY=; b=Dwx4HSrtb0kJq/iujYTDJnvEotNcZwGKIH0S0ZoTKe70UI9YFApH1npagtAuzd0cDu zq2dOW+OdQqELa4FREd/LuR2k7wxom5QHTwD706rn+QEMQnkDVwVrq+fXD1D6qECzRQm /BhDf+6RqE3TAAtObJOIVZ7+BvtqWIcFnvndlTpTBTMmCf6W/t1SOOAWwG0B6mI1B/Nt IwGjDeqkez//kqSbVbpmCT7LuvJv/B5My0781fbOCM2Xl61uo5sKfLLiU3dCzsB9Agxh HQQVOv7OMBi4lxseg0yzk3Ojcs+xgEBr246PzRIzinoBPAcYdK+6coxFc9UG66QmxPho tSHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O7dXm3ea; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p23si31138323pgk.312.2019.01.27.22.45.15; Sun, 27 Jan 2019 22:45:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O7dXm3ea; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbfA1GpO (ORCPT + 15 others); Mon, 28 Jan 2019 01:45:14 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55540 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfA1GpO (ORCPT ); Mon, 28 Jan 2019 01:45:14 -0500 Received: by mail-wm1-f65.google.com with SMTP id y139so12579006wmc.5 for ; Sun, 27 Jan 2019 22:45:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=1aBBJ84u3ymAhFuzjAtS5nCyk99H9ZXfxJBF/z7RCfY=; b=O7dXm3eaXx+urbyXs+leF9FdeXesCvpiSRQYtQssVK5y81eDev8ECLB6fEhz3TVkpO 1dLIFdEmDcMPqHZ7NWGdvSV/c4dqHkysgoHIbfpafxi9Wse6czBAMQ1AA6v5s/uCpG5F L5izdCEmQBNXGUIDzg5EmQR74IvSLLdxnWUBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=1aBBJ84u3ymAhFuzjAtS5nCyk99H9ZXfxJBF/z7RCfY=; b=Y+jZbt0XJ4PUH3O1si9h47E7wXlvROp/fBPtNHCK6cpgGCD/bq5trlkU9CsbWVyaNR mlTYTFJRiQCnm3a/j/AJzJ9G3s7j0GuVatN/iE1Zs6JFfuh4kgb72/n+BSnemU+EftmB N8mDs7af/BcrPam91TO3NiNe2DdJoJMESs6w/WGN0mqhkqhc0CC2IAqoRvmxzEJDsx6h kJ9gTi4rPttILwvDzUwOIknWIM68hsyb0lxwQ6MwbG9c4qpU56sO/ng1EImqNelPoX4E i48FhUgksAeH5AsYI9Ib8xFKXDCtKumysTUJjsipivM6X/553QTvS3MeVCnummUUScsK RBlA== X-Gm-Message-State: AJcUukeUNPC+SdfPDh2sUggcTODOXl8D7P47B7WBy86S7FCwBHlQEwMz HjwPWJv8u7fc8QScmaVpKqZrnQ== X-Received: by 2002:a1c:2e43:: with SMTP id u64mr16048252wmu.52.1548657912682; Sun, 27 Jan 2019 22:45:12 -0800 (PST) Received: from localhost ([49.248.191.44]) by smtp.gmail.com with ESMTPSA id c15sm52708620wml.27.2019.01.27.22.45.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Jan 2019 22:45:12 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, viresh.kumar@linaro.org, edubezval@gmail.com, swboyd@chromium.org, dianders@chromium.org, mka@chromium.org, "Rafael J. Wysocki" , Anson Huang , Shawn Guo , Bastian Stender , linux-pm@vger.kernel.org Subject: [PATCH v4 4/9] cpufreq: imx6q: Use auto-registration of thermal cooling device Date: Mon, 28 Jan 2019 12:11:29 +0530 Message-Id: <6e8ab1213d82b6de5294c0f579a24150aafaf558.1548654899.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to automatically register as a thermal cooling device. This allows removal of boiler plate code from the driver. Signed-off-by: Amit Kucheria --- drivers/cpufreq/imx6q-cpufreq.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) -- 2.17.1 Reviewed-by: Daniel Lezcano diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c index 9fedf627e000..9935df234fa1 100644 --- a/drivers/cpufreq/imx6q-cpufreq.c +++ b/drivers/cpufreq/imx6q-cpufreq.c @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include @@ -52,7 +51,6 @@ static struct clk_bulk_data clks[] = { }; static struct device *cpu_dev; -static struct thermal_cooling_device *cdev; static bool free_opp; static struct cpufreq_frequency_table *freq_table; static unsigned int max_freq; @@ -193,16 +191,6 @@ static int imx6q_set_target(struct cpufreq_policy *policy, unsigned int index) return 0; } -static void imx6q_cpufreq_ready(struct cpufreq_policy *policy) -{ - cdev = of_cpufreq_cooling_register(policy); - - if (!cdev) - dev_err(cpu_dev, - "running cpufreq without cooling device: %ld\n", - PTR_ERR(cdev)); -} - static int imx6q_cpufreq_init(struct cpufreq_policy *policy) { int ret; @@ -214,22 +202,14 @@ static int imx6q_cpufreq_init(struct cpufreq_policy *policy) return ret; } -static int imx6q_cpufreq_exit(struct cpufreq_policy *policy) -{ - cpufreq_cooling_unregister(cdev); - - return 0; -} - static struct cpufreq_driver imx6q_cpufreq_driver = { - .flags = CPUFREQ_NEED_INITIAL_FREQ_CHECK, + .flags = CPUFREQ_NEED_INITIAL_FREQ_CHECK | + CPUFREQ_AUTO_REGISTER_COOLING_DEV, .verify = cpufreq_generic_frequency_table_verify, .target_index = imx6q_set_target, .get = cpufreq_generic_get, .init = imx6q_cpufreq_init, - .exit = imx6q_cpufreq_exit, .name = "imx6q-cpufreq", - .ready = imx6q_cpufreq_ready, .attr = cpufreq_generic_attr, .suspend = cpufreq_generic_suspend, };