From patchwork Mon Feb 22 10:03:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 62551 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp1131476lbl; Mon, 22 Feb 2016 02:03:28 -0800 (PST) X-Received: by 10.66.226.238 with SMTP id rv14mr36907844pac.41.1456135408062; Mon, 22 Feb 2016 02:03:28 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i68si38788240pfi.222.2016.02.22.02.03.27; Mon, 22 Feb 2016 02:03:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960AbcBVKD0 (ORCPT + 7 others); Mon, 22 Feb 2016 05:03:26 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37650 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753260AbcBVKDY (ORCPT ); Mon, 22 Feb 2016 05:03:24 -0500 Received: by mail-wm0-f41.google.com with SMTP id g62so155587817wme.0 for ; Mon, 22 Feb 2016 02:03:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=OnGkf1eG5Sft/wPtsspHAcgfSV98IC+FS5KPguG8jvU=; b=GBiyQx9M4nQchu1i4igI6KdWQPXwKPRR9ZSO1KfXPYOzDeoyd1rJjV71ZSoaC6lvTP FwCklY2xNANTW98IZTOg30j2+QmQiqxJW6gywJaSeZRJ+xjElqc7aawJdvs91cZMjqI2 HaW67CDcVnvvEyuGp9NNzXy0zggPgrwf7vat0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=OnGkf1eG5Sft/wPtsspHAcgfSV98IC+FS5KPguG8jvU=; b=h3nYRW4Zi6LYsabmg2cbqo71EV5DInmeiPbJE2iYiT//iJpaSnCOK2sHUXRM2/744O RMbwlHVBh0mLQG1v8HJZmphO/2SRBO1cWqf4ZxmnPxQTqV8DOG6ejMp/hpvBXwlC5j2X Rc6fpjF9v4GyuY8E/n+Lraa7aowHy5q/NSuiYrEnl4IUHaoDBx6MDwEBBNWXtLlrGe+5 0k9mEQzyR6nOKN5il53T3eI9rNKXpdteByASXMTGriYDG+fmx6MfWKYdIXbUW6GJNrM7 nNyaaDrW+//B32CCvfi/lfc678OFZDhoP1jp0PzSlXw5JJf9Dva6MUYspAjv8qyCu6QH f63A== X-Gm-Message-State: AG10YOQUwV+VSfEXX67tF2Z4wWKFqu58RXKivSS+oFQo63G8V1LJAn44q3TjwgXCBBrzzRiV X-Received: by 10.28.48.137 with SMTP id w131mr11846441wmw.73.1456135403772; Mon, 22 Feb 2016 02:03:23 -0800 (PST) Received: from [192.168.1.22] (host-92-17-247-99.as13285.net. [92.17.247.99]) by smtp.googlemail.com with ESMTPSA id r10sm23900460wjz.24.2016.02.22.02.03.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Feb 2016 02:03:23 -0800 (PST) Subject: Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT To: Bjorn Andersson , Peter Chen , Greg Kroah-Hartman References: <1456119133-16114-1-git-send-email-bjorn.andersson@linaro.org> Cc: linux-usb@vger.kernel.org, linux-arm-msm , linux-kernel@vger.kernel.org From: Srinivas Kandagatla Message-ID: <56CADCE9.9090305@linaro.org> Date: Mon, 22 Feb 2016 10:03:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456119133-16114-1-git-send-email-bjorn.andersson@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 22/02/16 05:32, Bjorn Andersson wrote: > On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set > to be able to do DMA allocations, so use the of_dma_configure() helper > to populate the dma properties and assign an appropriate dma_ops. > > Signed-off-by: Bjorn Andersson > --- > drivers/usb/chipidea/core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 7404064b9bbc..047b9d4e67aa 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -62,6 +62,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -834,6 +835,9 @@ struct platform_device *ci_hdrc_add_device(struct device *dev, > pdev->dev.dma_parms = dev->dma_parms; > dma_set_coherent_mask(&pdev->dev, dev->coherent_dma_mask); > > + if (IS_ENABLED(CONFIG_OF) && dev->of_node) > + of_dma_configure(&pdev->dev, dev->of_node); > + Would we hit the same issue if we are on non Device tree platforms like ACPI or platform device style itself? > ret = platform_device_add_resources(pdev, res, nres); > if (ret) > goto err; > I think this is the side effect of commit 1dccb598df549d892b6450c261da54cdd7af44b4(arm64: simplify dma_get_ops) None of the drivers call of_dma_configure() explicitly, which makes me feel that we are doing something wrong. TBH, this should be handled in more generic way rather than driver like this having an explicit call to of_dma_configure(). On the other hand, I think we could also solve the issue by using correct device(parent device) while allocating dma/dma-pool. ------------------------>cut<----------------------------- ------------------------>cut<----------------------------- --srini -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Signed-off-by: Peter Chen diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 6e53c24..0293ed5 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -1844,13 +1844,13 @@ static int udc_start(struct ci_hdrc *ci) INIT_LIST_HEAD(&ci->gadget.ep_list); /* alloc resources */ - ci->qh_pool = dma_pool_create("ci_hw_qh", dev, + ci->qh_pool = dma_pool_create("ci_hw_qh", dev->parent, sizeof(struct ci_hw_qh), 64, CI_HDRC_PAGE_SIZE); if (ci->qh_pool == NULL) return -ENOMEM; - ci->td_pool = dma_pool_create("ci_hw_td", dev, + ci->td_pool = dma_pool_create("ci_hw_td", dev->parent, sizeof(struct ci_hw_td), 64, CI_HDRC_PAGE_SIZE); if (ci->td_pool == NULL) {