From patchwork Mon Apr 29 14:04:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 793466 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F291C76F1D for ; Mon, 29 Apr 2024 14:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714399705; cv=none; b=hSs5Y9t/Ll7qM2jQSJTrkbEX3crdviVXOEnCmMqizcWXTkh6gnxTGvzjKD3pnPmHpILfJKa8K5D4uwrbni4Iz5isAQirrKEWPofmGs4CeG0llGnlgC/6j3h2Gs04xY5a0eMoGA6ffUKli18PQ2y1OG4/xVafrr6OQZZBC2vJVig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714399705; c=relaxed/simple; bh=U0UEVvgtP+Df0Luov+wIMPnlM4UAENUSvdQsvkRwh3U=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=YnDW6bzxKaqSK/t+luyxesd4W+rrcXneVh9PDzrDqbmyRFY75cXZ2QjG2B5JeG8cov8cfXGlCD7m/vybGtXvr6VJHB1S+UaOjtpMze1dWTAY6sscvW2A3qU/xxc7lltBfTdsHFxKPWBYosefVOEM5MK2CacdTcvCm8WZYVKpQZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr; spf=pass smtp.mailfrom=freebox.fr; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b=XnZoY7Ur; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=freebox.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b="XnZoY7Ur" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2dd7e56009cso58925531fa.3 for ; Mon, 29 Apr 2024 07:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebox-fr.20230601.gappssmtp.com; s=20230601; t=1714399701; x=1715004501; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=oBy2kmpzdw0iu+shQSoNx7bJmznd+L61sp+luHwDb1k=; b=XnZoY7UrfY7IKb6dUZV1MTTYhYs6cAmzgnK3BP6aZ728GejOm392qZcXamjVbp4bND u1Au1ap9//OWnKQljLwOTwBXfmzbfkiUPxjzuCSG4eqSgdrXtM8GxmyLLczb0x/6doop rHG4CLLGNUVIzPyLyD9AlBTckuGeKPt87FTIPVm7bJ5q0sBQ9+wTaiIfk2Y4Dx3UflMB Z9wt4jSKq8IXnB9iTsabSHVLPYERdXpb8GNYKJDe7iieQQPfHKNo3JJ8kxoZY8f+aQYf SYJsMYVL7gStU4yfM4oNobQ4JEewkVJ5yXCi6CkumSm5pdUsKVUhYZp4lbikzliIqP37 9egw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714399701; x=1715004501; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oBy2kmpzdw0iu+shQSoNx7bJmznd+L61sp+luHwDb1k=; b=tVnQKySrEps1BR3lRI5iT2gOXL9wBAzEyPfENq1hlgKKXTsOQQC2QapNOH8tz4mFjT ooFls9MIE0k0Yi90vZ4Y9sUVCtuaeppA7ddfm9Ph1omMsIxpr74OeZ83F85Gw2zq6tSr drrtMnvrAbf7vSKFMcWF7X7uPYqdteS0NzxbX6QuhUegTxz1FJeIVfClC/cat1pP58kh SbA7MydO4mbnCaWOg2WoKLkoVshCaKq8tiSyOcJAgo5El+1JUZqJV7Ty4fXfmb5G/GM+ feu0nSJ8SXMbvcBliw1ByBDmzFnUYXss+12RRYMmyjQMaDfbgoFCrjKMmal4jansNOsw SXOg== X-Forwarded-Encrypted: i=1; AJvYcCUcW0tToFenk3Bb5RFmX0eeghtGvQ7h8uG0ZWXBxKuYLuBcPCBaR6GMs2q1vG52ned9HDmCo9YrCWn9JYI2YXkJ9Vc3WSQVpNayBKAWvg== X-Gm-Message-State: AOJu0YzAAA6FneuoJUZYRnOSi/lptO+wFlg0sQo7/H3mi0Fcqe9Bt/ob STtS2O6eSB+MFJNESriiuRCjsrL8yaLC+B5g67xBnlXrDkV4aBBVj/3J0Yf4DX8= X-Google-Smtp-Source: AGHT+IGx5tX+xy8iJXA69SZQR1U/gQ2YxMQre7YD8YVUOem41NsX4VFYFSkbO1iHvPCmEz4H+9316w== X-Received: by 2002:a2e:9b41:0:b0:2dc:bf5c:9648 with SMTP id o1-20020a2e9b41000000b002dcbf5c9648mr7245557ljj.19.1714399701145; Mon, 29 Apr 2024 07:08:21 -0700 (PDT) Received: from [192.168.108.81] (freebox.vlq16.iliad.fr. [213.36.7.13]) by smtp.gmail.com with ESMTPSA id h1-20020a5d6881000000b0034615862c64sm29585477wru.110.2024.04.29.07.08.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 07:08:20 -0700 (PDT) Message-ID: <54ac2295-36b4-49fc-9583-a10db8d9d5d6@freebox.fr> Date: Mon, 29 Apr 2024 16:04:51 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop From: Marc Gonzalez To: Kalle Valo , Jeff Johnson , ath10k Cc: wireless , DT , MSM , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson , Arnaud Vrac , Bjorn Andersson , Konrad Dybcio , Jami Kettunen , Jeffrey Hugo , Dmitry Baryshkov , Alexey Minnekhanov References: Content-Language: en-US In-Reply-To: The ath10k driver waits for an "MSA_READY" indicator to complete initialization. If the indicator is not received, then the device remains unusable. cf. ath10k_qmi_driver_event_work() Several msm8998-based devices are affected by this issue. Oddly, it seems safe to NOT wait for the indicator, and proceed immediately when QMI_EVENT_SERVER_ARRIVE. Jeff Johnson wrote: The feedback I received was "it might be ok to change all ath10k qmi to skip waiting for msa_ready", and it was pointed out that ath11k (and ath12k) do not wait for it. However with so many deployed devices, "might be ok" isn't a strong argument for changing the default behavior. Kalle Valo first suggested setting a bit in firmware-5.bin to trigger work-around in the driver. However, firmware-5.bin is parsed too late. So we are stuck with a DT property. Signed-off-by: Pierre-Hugues Husson Signed-off-by: Marc Gonzalez Reviewed-by: Bjorn Andersson Acked-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml index 9b3ef4bc37325..9070a41f7fc07 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml @@ -122,6 +122,11 @@ properties: Whether to skip executing an SCM call that reassigns the memory region ownership. + qcom,no-msa-ready-indicator: + type: boolean + description: + Don't wait for MSA_READY indicator to complete init. + qcom,smem-states: $ref: /schemas/types.yaml#/definitions/phandle-array description: State bits used by the AP to signal the WLAN Q6.