From patchwork Thu May 22 19:03:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 891973 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70DA4150997 for ; Thu, 22 May 2025 19:03:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747940624; cv=none; b=QBxciSKJoeDPuHgBVldQ/TeI1RDg7D5cI3BuKtbP9hK5QrhvYTp89G89DFvtyMl/+v4hmmu5YNTv7Tb0xcu0vketYV+YtdLGRtZ6fp7RQ3UwTTsbP6qzZns6WH0OI/RC0GTjdGdS4H8/n1OvzGZiWeCPzxj/JaTXrSsqIi4Raao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747940624; c=relaxed/simple; bh=zQxYeUAVHo+xt0jOkEWcT10mYuzzGMKBHrI/C8TQAuU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Tk/QnhbbFD6bx1JRMwkClX89kuAugZyfUWZeubKIwUvaxPyTXNB+89F1ywGYMMNPtzs+vdxaXGD6UI1Ua6gXR6hG0z3wwWTFznB39/WkXUzrDmT+TOVXBzP9qngdHHPHPjD20BlVRuqJU+8xUKdLkLe2s2llBuu4qtRcw4RKyOU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Qbu80mvU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Qbu80mvU" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54MIFBEL001723 for ; Thu, 22 May 2025 19:03:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4Qp7jh1itM43n3wIU7h6lhpLC0Hmbksbm37fexlcjaM=; b=Qbu80mvUioc4fmN7 UNATFhvrLnAQflx8F5+aZWsWGXYLV+fRJp6hQ/XNz50V1uvClGLyLRaCMpDyoPQ/ vbFpu05XVIJnp4YWRSj6x1sO0hBX9V8mo6KyttbVsuU1P6m65L/i6CBHa+StCfUz fwf7buYsIxa5GepOdVwhtU6saBm1Ii/JofAmgpDZtc5cczaNdchj4+3zMg/c70S3 z+8Tr4aHA+T34j4ZV+fo+PjcO25xdUqN+Be1EPX0Sx/nH9sdeaSKNOd8gO5QzODY Ax2dPnY+V+JLGe8i3qFaTG3QLuxcrxJ4Ud4vgQY56Wc73xOPU7LfIpLC6FeUuoRC jltO5g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46rwf6ybcm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 22 May 2025 19:03:41 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c5e2a31f75so256016485a.1 for ; Thu, 22 May 2025 12:03:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747940620; x=1748545420; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4Qp7jh1itM43n3wIU7h6lhpLC0Hmbksbm37fexlcjaM=; b=NtVsmaYPm0e7BAm0xAu4FegZppd2s10ittXedo2Yp9kHnz1OuHxHmVktH4gclZQ/qC OjqksWKPOatFLv4TBg165Ext12l6Xqgj0c09BWgb9kHwTMFnUOAelj3gAEQ/rva9cfE0 5L57JC15gxSJUwIVuxCgtjnnbrGEAKbL0D1Tne25io1PAa/SadmxDMW1eKOoAMdYrazQ fB+8xEqEaVm3ntrKIBMo7Kk23t9U9BDO2T23NfHvjKcTGawypIp/iBoKTVSCfyoVjvjr 4LA1YTu1OSJRTnJ0lazSkU/+1KLvoskxdtr2bOFCY0fZFLbgW5/5/j0QEPmZUA2bkZXa Wbkg== X-Forwarded-Encrypted: i=1; AJvYcCU6vScBnkhiOwHbrDTkcePFh3kQlvJngfe+z1ti/SyGqdws4fc9yIAxUdJ3zoiJqxf1k3ih38l6zDhLsQrn@vger.kernel.org X-Gm-Message-State: AOJu0Yx54hr2yVwq4YUQVhLnR8uKg3Saq+n6jIYhfnpuSXWKIob9XuZI VgcoBsU9FNfKDli8uJpOluc3nSxBhKlg9YnCkDts4mqjBbW4WP4San162rEgthmfz5J+hKxA6vW FxrUv6fwUM6JLL8nHGIKHchL89YTlVw24Zv7W/QeNixipQM+XyhPPftl/+o94r1FjlrR1dFAv05 Bn X-Gm-Gg: ASbGnct6kpCQM0AtIw2akX9OJMSpnRKni4wSMhnu18k6sboXyewUEGVLjZdVfjtzQZ1 QKyGIOIsGZfeKAdHNA1esQDrjOouX5WvEzycQGkNv4qOY7pnmYxy78CNBj9bk4dGCAbL1MDWDG8 6YI4jke6Y5yU4wgRMOgqxIfpd+V9NW57wITSEG1uRB8nGZLCLko5Uubf3jt6kvmhF3uh9HVFnRh IPeqSsHyj+t12sjQVrKPBTTPSlETwrMZU0Xn5y6YXHPpUzKwug6K+yVnYgVr8e+k97xlvWcxmWH VS2aSB7ZPsThq6mMMsjxYHUtWU67l5O16lLDMw62FURXeOv0EFe0XliJLJE3ijF92wuIs1l6Hw4 Bo8OMvWS/Tzgfj48vGc48djJi X-Received: by 2002:a05:620a:404f:b0:7c5:6140:734f with SMTP id af79cd13be357-7cd47f1dbe5mr3834189285a.18.1747940619843; Thu, 22 May 2025 12:03:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUWhtLxfwnjOCeFjmQwfRQz8WK84FyU9B8tUZnS1CJObKXZJplV3E2lQi6/zI5UpsVwRyzxQ== X-Received: by 2002:a05:620a:404f:b0:7c5:6140:734f with SMTP id af79cd13be357-7cd47f1dbe5mr3834183385a.18.1747940619425; Thu, 22 May 2025 12:03:39 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-550e703c2f3sm3482506e87.214.2025.05.22.12.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 12:03:38 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 22 May 2025 22:03:23 +0300 Subject: [PATCH v5 04/30] drm/msm/dpu: inline _setup_dsc_ops() Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250522-dpu-drop-features-v5-4-3b2085a07884@oss.qualcomm.com> References: <20250522-dpu-drop-features-v5-0-3b2085a07884@oss.qualcomm.com> In-Reply-To: <20250522-dpu-drop-features-v5-0-3b2085a07884@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Vinod Koul , Konrad Dybcio Cc: Neil Armstrong , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=V1gYZpITbFHVwsL98bgMq1gW9yj3xDgdHDTSQqGTqRI=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBoL3T8U24JiUoIwCb2cb4lL90avZ25jIcPH9tnQ pm8S/lgNBaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaC90/AAKCRCLPIo+Aiko 1acvB/4yq2iMOwDZTbHU9A2g9u3rON7AJ+oqYKcsLzdrCpqTzvxHncYO/qMgQbv0QsJMwTSYxC5 qMp4hIq+t2Vma1YyiZMXgae2tnodTMiA5QGfy3R4MejvdoPf2vWROyIJHaZ5q9+6jjwwT0vG1cw ujnxqFy6WnJ1DNSCDIp89Hk7XE0gDbL0iy27BeJ2c3606zZZ8LAy3Lktjcv5X6D4fDieCXVyShS i9aVgAfUUMGFrqfCKFIfzc/uKRWVh/zAL+dkAb/SN31YSaxd6MVJyIUcN1eE96bAGdwW33Ij1md FePu1u2uE8S3WXEciqH3O5qHHTxWbaGoPhQTRudDI7CJX+jk X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: kpTuXFLAIhtOtkIINukKdosUGwUv0ShF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIyMDE5MSBTYWx0ZWRfXz9zDu/2q8tY4 W2P3I2N5hSLcgoJZWHv9Mi9ITut1zyt+pNdO+iWLBrKasT5IS/eJxYfn5eQDl4vfvJbGfqJhy8w 75ZRY7gt0e9Tfvm0i//gwpAlo1LtTq/gzDtToCDYw05hM+crWHZTjsKnrEY1VoP/euXCbeoli8L JRL26XXTey0Z4qXCdYjLBBNhh2cHwNZZ+xsi8g9gBKfAKhtIB8Ols0oDr83ITqLfWZzJCGw5PcZ /0tZVVMEKJ6H3Qdl4vKqmmcjDulPCTYYQDDbFIzG98oovDGx29Es8kaoPVbIEO3+ZN89d8Qprid DbJTD1KyFiwnEtpCQ7Kzl+OhPo2U7hzeU6axd9+eigLxiEpe+tDF+YIF0Zo9aWaW027gJYacEjH N+9kAYhomKTP7xU+gKvUoqEvsEjBf7Gg8jYKoIzheGLsd/2WkN7irK2aQR/hhZSSJHzyqQGB X-Authority-Analysis: v=2.4 cv=fZOty1QF c=1 sm=1 tr=0 ts=682f750d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=aBwJmt2KlYBR8C_sNNsA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: kpTuXFLAIhtOtkIINukKdosUGwUv0ShF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-22_09,2025-05-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505220191 From: Dmitry Baryshkov Inline the _setup_dsc_ops() function, it makes it easier to handle different conditions involving DSC configuration. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c index cec6d4e8baec4d00282465cfd2885d365f835976..c7db917afd27e3daf1e8aad2ad671246bf6c8fbf 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c @@ -181,16 +181,6 @@ static void dpu_hw_dsc_bind_pingpong_blk( DPU_REG_WRITE(c, dsc_ctl_offset, mux_cfg); } -static void _setup_dsc_ops(struct dpu_hw_dsc_ops *ops, - unsigned long cap) -{ - ops->dsc_disable = dpu_hw_dsc_disable; - ops->dsc_config = dpu_hw_dsc_config; - ops->dsc_config_thresh = dpu_hw_dsc_config_thresh; - if (cap & BIT(DPU_DSC_OUTPUT_CTRL)) - ops->dsc_bind_pingpong_blk = dpu_hw_dsc_bind_pingpong_blk; -}; - /** * dpu_hw_dsc_init() - Initializes the DSC hw driver object. * @dev: Corresponding device for devres management @@ -213,7 +203,12 @@ struct dpu_hw_dsc *dpu_hw_dsc_init(struct drm_device *dev, c->idx = cfg->id; c->caps = cfg; - _setup_dsc_ops(&c->ops, c->caps->features); + + c->ops.dsc_disable = dpu_hw_dsc_disable; + c->ops.dsc_config = dpu_hw_dsc_config; + c->ops.dsc_config_thresh = dpu_hw_dsc_config_thresh; + if (c->caps->features & BIT(DPU_DSC_OUTPUT_CTRL)) + c->ops.dsc_bind_pingpong_blk = dpu_hw_dsc_bind_pingpong_blk; return c; }