| Message ID | 20250508-pcie-reset-slot-v4-1-7050093e2b50@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: Add support for resetting the slots in a platform specific way | expand |
On Thu, 2025-05-08 at 12:40 +0530, Manivannan Sadhasivam wrote: > A PCI device is just another peripheral in a system. So failure to > recover it, must not result in a kernel panic. So remove the TODO > which > is quite misleading. > > Signed-off-by: Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
On 5/8/2025 3:10 PM, Manivannan Sadhasivam wrote: > A PCI device is just another peripheral in a system. So failure to > recover it, must not result in a kernel panic. So remove the TODO which > is quite misleading. > Could you explain what the result would be if A PCI device failed to recovery from FATAL/NON_FATAL aer error or DPC event ? what else better choice we have as next step ? or just saying "failed" then go ahead ? Thanks, Ethan > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/pci/pcie/err.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c > index 31090770fffcc94e15ba6e89f649c6f84bfdf0d5..de6381c690f5c21f00021cdc7bde8d93a5c7db52 100644 > --- a/drivers/pci/pcie/err.c > +++ b/drivers/pci/pcie/err.c > @@ -271,7 +271,6 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev, > > pci_uevent_ers(bridge, PCI_ERS_RESULT_DISCONNECT); > > - /* TODO: Should kernel panic here? */ > pci_info(bridge, "device recovery failed\n"); > > return status; >
On Fri, May 09, 2025 at 02:11:00PM +0800, Ethan Zhao wrote: > > > On 5/8/2025 3:10 PM, Manivannan Sadhasivam wrote: > > A PCI device is just another peripheral in a system. So failure to > > recover it, must not result in a kernel panic. So remove the TODO which > > is quite misleading. > > > Could you explain what the result would be if A PCI device failed to > recovery from FATAL/NON_FATAL aer error or DPC event ? what else > better choice we have as next step ? or just saying "failed" then > go ahead ? > If the recovery is not possible (with device,bus,host reset), then there is nothing could be done. - Mani
diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c index 31090770fffcc94e15ba6e89f649c6f84bfdf0d5..de6381c690f5c21f00021cdc7bde8d93a5c7db52 100644 --- a/drivers/pci/pcie/err.c +++ b/drivers/pci/pcie/err.c @@ -271,7 +271,6 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev, pci_uevent_ers(bridge, PCI_ERS_RESULT_DISCONNECT); - /* TODO: Should kernel panic here? */ pci_info(bridge, "device recovery failed\n"); return status;
A PCI device is just another peripheral in a system. So failure to recover it, must not result in a kernel panic. So remove the TODO which is quite misleading. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/pci/pcie/err.c | 1 - 1 file changed, 1 deletion(-)