From patchwork Mon Mar 24 02:26:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 875834 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F26C717E473; Mon, 24 Mar 2025 02:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783298; cv=fail; b=IgjpdFxl+7q1b5l/mYRmZaUS9eGs1QsdqpdSWsLPqTXTJ7SEc8cHssJPFlpUZ9i0eT42jMGR0Pf6baQ0JFIXfWZSAJibVCzwa82qj0AN+HKgSOGdGaUmMuhMV5u4AxqMBYNjKc1w69x4+Ry6KjvKoE6Dibihqck2evk4GIb3gbQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783298; c=relaxed/simple; bh=pCZv3a4HKoCo6tTULZ/T7f7WdQ66pPWFRweWebAtzs4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=iSHSwTsPvvRARiDs6+BN4aJ83vivs6IbabLQTkw14W0A4Bky8xOxCEdMW5wP+K/6h1oiYzdQ5Td+M2pt++hhV09UtkuDhJ/pEFoQm+8v0fOsbFua+IO6lQhSgoEvChxxiuDyTfEpuxOdaFYmrfFtSSB2gLjeesRqVpBjjAnUfkI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=WLyvwy/S; arc=fail smtp.client-ip=40.107.21.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="WLyvwy/S" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AUUVZgP4OQxAswXYC189NgbCIi5Y39RDPEVl4A8ugCAhQc1bXradaiwr9/dzGX2wY9Kr+1npfNEja3Z127vdv3mhTF7YgzgK90TEHXf6grH3HdHoN4PQmfxU+fQnSDgpzRMN1CGWcNjsGTj+V8RMrmTR77aSbxHZoFSRQdsMEZUGuzNnGaj2hHGXoeqUIISzIs3YLia2lGo7risFfcZpGfP0ehiiEenS/gEsWmLKxgJxp32Ne510TM7z3URxLwYeDNE9qHnHcDMBLNxPm4+Z3YIjD11WcR31xq9cuO2fAOugOLHjp6QP5MCtw8HVFoaNW7SDWe0z8ZL6CcDeIaCvIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FEUv2j/WYz/0UQb2CW3Xs6/R7GSMOigLx14jpL/CkgM=; b=Y4Qpvfee18JIlw6LeyAwunNR6+YYv8g56i1X26QNy0YX/IuCALU5KxCfuiZpgAxnuM/DBrZjJbyiSXHxJU6GqPyY7sBFvG14/LUNOqKASx7QN10uxgrOZTSS4k76JdcQjwkMXrRfH6FhWU8mvAiXpP64ejFZZXgGe2L8SBhlz/xo36EAqHvbQx64AdFuW+/PHDownbsqu/CTkDQYco82eEzfTO5L54DLCwbKpmuORyMAK9KAX1knAc7LVHjCodet1JsXJWk9dbxWJMCQ8Csv4uXdgDEoAgMl3ktZ/uYilJ8L0dK8yO6u6UjoXzQGf9pzi6080GGUr9FOzswPylsqVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FEUv2j/WYz/0UQb2CW3Xs6/R7GSMOigLx14jpL/CkgM=; b=WLyvwy/SvAHUsf7DOPTp2FXnOCOzIHy2hGcjx0YqDYCxnUtGSQPK+oltOOThi8LysbnxHd+7VcWbtMHqdOPwxu61sFjiwKqyIi7weQ1uEtfCZGctuLqrGDLKTrAzozDOoZ9DK7gqjk8gWEZs3OPLhlitwwwtMX3fchDqrIwuu/5QRX8WD9Nan9ns3z0ntXs5v2ISBtud+QQL4dNdEI0WkX3HECsoBM0oiFl0G/kvwOuhOWEvRfmS4OuTtXal8c20S5lzI04PsDoa3uG+hFgtEDui5XHF/XCUpm6nQMlxJf5l/ymWnsa52NvPYyarh3kuJcB4A115Ux8hOJp4mvOjgg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7036.eurprd04.prod.outlook.com (2603:10a6:10:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 02:28:12 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 02:28:12 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 10:26:56 +0800 Subject: [PATCH 3/3] ASoC: codec: wcd9335: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v1-3-27afa472e331@nxp.com> References: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742783224; l=2351; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=w2kpHxzjhH5lUjvoGiVgliajpRhAKVQmnpgnfgKcfec=; b=cAGNjIfPTUMhCpIm+mGG29Y5M1UIfDYSN+SrEJSSkVz6KCJoFPCz/it6mQv89YFQUdWfJJgxo fPWTcDbkUwqDJzovc3BBRbZYE5i7iz9NHTOBedXOYeHnbmgkooSTeeg X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7036:EE_ X-MS-Office365-Filtering-Correlation-Id: 463e1f84-9e43-45b7-6f5b-08dd6a7b8676 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|7416014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?XWbh7ba+0kiR2wZbll74n68k7mV7wlM?= =?utf-8?q?W5L4ZxYzRT4+zJkzaSNwjyJSp3FBeJg5a/6I3GEcLtnpUtJ0dGFfiSjSors2P/05F?= =?utf-8?q?KKKCHoOHkiaKdteiPmHcFx3NdmVA4cSkwtks6iAaPoYRwYCesWdTyBZnjceduhprM?= =?utf-8?q?cdvXXmLVz2o245d70n752S32kHkFghaANSdeZlrbYhupXIy6h/PpBNDZMo7q3ZKtq?= =?utf-8?q?rqY2sf9dpcqzaI1FG+Mbw1rBjH/N5Ocyf2QmUhyLnx1NhUjSj9sXu/WukOO9X4UQ1?= =?utf-8?q?03ctfdDZTQj6cBdOzFrUj4LpVJybZlvX5j6nnQEd+F6veT6TurpVRcY9bSXvQWECE?= =?utf-8?q?NsVoszV+uxnJXJdTAf6oTmekdGGdVBxElMrJOuElAQGsxibRMKuKxG1IcmDPThvVB?= =?utf-8?q?cjik1tMbchLkEPQamcy2pcIv2TS9p80myPZjeGs8HjmEZkFqOR+i5nnBAekRltUjp?= =?utf-8?q?ugAVb6L0uqIJFXBvhfCBRSnzpNQ02yGmmxAp/UnCBF/mXIh6oinB9sDIyqlLCCglH?= =?utf-8?q?rjpNfKfeNnJyu1wAMd6GwvKD82meEmZUzecoZFFO6TlynexguGU0ae1QABd6CeaSS?= =?utf-8?q?kjjMXaj1SHlryPQ+FuyBImC7f/5M8+syRy7F2PNcvjVv3uouBhRuKxj7YhPVAyt7M?= =?utf-8?q?ZxvaM8/90bk/N3SeQLLZlwhVa3I1O/hJBe2mGhsTJPUEjjSe7lMvC/MIhJGGDCcNs?= =?utf-8?q?SZdn7xm4WQJFgeXhXw2Uv/HZqclRXnNX1jcoF9kXaaJHuSwTxf2f5aVsGbnuwmbFF?= =?utf-8?q?ZuvT5iIq+rHk44ojTba65WFtDBI1PFMGvM9dfSmVNs/kGVYaEJana6ClbrvxWJbtC?= =?utf-8?q?M3P3j5TRkgthee8ENArFD0M4I7Rkiu2UxG9tkW2TY/LPrMStKd9iFWbewGl6EOsfR?= =?utf-8?q?AewA92qazqCwoAt4KjpB2m2/A6qzyHOLixpZKW8ehtDStAH0WOTyBRcW6qXAebKjp?= =?utf-8?q?XkE7EQvF1im7uqzHARz/AV6+L2XKWMlFXVHtdHu/0RVg1s+QHG7YhxLOg7ZT0f61+?= =?utf-8?q?RugOQuiUicRo3g9GvKJGtSQbHxHGQxXGn/VyLmLRBLNXcYQVc9xbzEcaIRD/JH9Qc?= =?utf-8?q?w0lD2hdqEGHsSuk/muVkUAjrbYNkZambXGm6exqQWd3MA5dwVZ2lHJjgMkgMfJmI8?= =?utf-8?q?2dsz3M92fM0VrSXwRpqmsXoFTUvEkqf/Kz9sML8YqztfEEW1jkp10Odc/NQEhfPAI?= =?utf-8?q?Gd1kxHGyicwlmi/OIDENMo5nx8bH9nyvj99EGGZM1TUMUrEGnvWdCeDFNa6j3rNlC?= =?utf-8?q?vZXdLoMgr8sxC2fYzNPyMm/TYj4HeL/2B5FZy6z7KhObmBlWqf/TGLv89H4GfAX/x?= =?utf-8?q?T3SeQa4V/6HssZWqujfsKghFRtzotJE4A+FwETMqfcXG4rKgJJTr/AKEcYWgfdWcU?= =?utf-8?q?rMIpqpMPp8m?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(7416014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3UVdDMuJ9aDLhVTvmXf1DynTvri8?= =?utf-8?q?960bt6aW/SHFj2RM7FE1W+9zEQ0VfzEFeOaMgNeWe/rwJKkUJ0/8gq+A+Qy9d8zXO?= =?utf-8?q?JRSnP9snS+kT5wH8Eh01Bt3uPu+DjT98nM6g2sj37kLYL8hjMMy0phmDxr3AmuQa6?= =?utf-8?q?qa4ETwdQrtnVvALrGRGnHwZdyDL2IHnnxQfS6fKtYpdgKrCdEDguXGo5jQTii7xv0?= =?utf-8?q?L7lbuzDWiLMiZiT+zudodiwJ3GOlfwS6ePjmcvVM9maNHAPOwQBEclYqW9MFxtXFF?= =?utf-8?q?PyhUKRMMXIETK9uLQmdZbX9tTZVGREKXy19LqpMiaIQbF+uWmT7Q1NKxIRQu3zgUB?= =?utf-8?q?pC8+lka7ms5XABiAqUrmZKuXn9Uu+k4t3xYZRZp5ll4euG2emEkJj+7UgrUpmzbcm?= =?utf-8?q?5bOasG6ZjP2Xuedb5wmwdKaTxk/UUa5UL0QiZjr8U+bLQjk5fNJ0//KMsi0K25Up3?= =?utf-8?q?xTjdCVA2KoTNgNhT479jgmnhL6IUOFDqn8G5/NGVczfngSWfaGRQCiu3+LW2h9GaT?= =?utf-8?q?PNmOFBZk+FmLWF4xNGA9Lp9idC4gxy/TsVQVxFpWUp4O3oT2aHFeKj8WTqz/ryxHh?= =?utf-8?q?uFJXmyV2cMvfqcHsqo0XYKiWTlaaSiCcARIXPJ5f47XGXcehR4F9+KCfICojy6y1M?= =?utf-8?q?wQtm8iVFIFP7rOqLn4DSSDWvyS2ZuFmhNZ97vxS85k4x/ltR1xL6dIrq8d83U3b4Q?= =?utf-8?q?WVgRaFo/Jtw1ahrjcfQz/UsuVC1fIkhaaFg1YmCAFa/1uXWK7aNLlbO6j7Hw2W8Ip?= =?utf-8?q?WBAIxM7sT0L/ueATV5ZClO74WRV458QVMsYSiovxynHcKlvHd8vfetVIqDc72SxOT?= =?utf-8?q?A4TREtGCrZjydNLvAMzUpNgQvIdT7Fp4OKGNgDslvwkAet1GRzWXryX/YfBQG5SVX?= =?utf-8?q?pt0b4t15/vITEiQOQarWsPcOdxZG37PIma7VBIRPWtN8z19fksNZlINfnHoKOK5L2?= =?utf-8?q?si/pdmy5VqXF1M+do12v++/P06uHUSB/5thUrKjMse+Rt/4jR5lMzgdW+9otsVJD2?= =?utf-8?q?P66gUSwv6Nq4WywN/T7hV70+7PA8gtcKLZ8jHStp5A4vrZRbPeWqHJKWOCRmIaDxJ?= =?utf-8?q?6256J66PA7J46Ijg0taEKLmV3ejMfs32MYQDU8I7Uapx58wI+1kx7pWjR1x8ukI3V?= =?utf-8?q?OGF/RfVEAs4mW3UxEsBLxOTwmZczGc+rBA9woYu63rzRhTnsHya84uSvUh1u1Yf3L?= =?utf-8?q?ZoapQRoHbZeM8psgLNPgsP+GlpWsF2JlUJ62Jku0UwnCmTrQUWaUFvnJ40RDCeASi?= =?utf-8?q?9q/GWufC7KH5dHY0uLvQEAuXxX/Uhrf+jJdufh/zZAmLoRjEknwj89kPgBqL24fxT?= =?utf-8?q?HG76c5UjPKIleSKRic97tzQ6kHRsxxCrPLgu0stv3aXvp3OvDP2GQOjsZhiXhFrLH?= =?utf-8?q?Gef3DyBLKEaZ+uZf/vJdVwwQIy9P1iFYNBU5OeOQxJcdgxqUUfD9sU2tCbmhxkbM6?= =?utf-8?q?7Rzb+0qk3oB1bnK84ESTrDCGzNOafhjHrDtL1KBizXlKEhYM/CcpYsxb2dQLjuRMf?= =?utf-8?q?DHrz1Q8ML4if?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 463e1f84-9e43-45b7-6f5b-08dd6a7b8676 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 02:28:12.7704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iI80whXRIhgrKnK3pEedIMobPZdhw3Sw+ROkGO8bhZHmgU52gR5OJ7kxGGjFCFOJM0JpFYPuOOrYp0E7R5BD+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7036 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_ASIS when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. Signed-off-by: Peng Fan --- sound/soc/codecs/wcd9335.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 7cef43bb2a8800971604b0e1ac55aac26c5919bd..90cf4f79cbde5f704549d41771f085574045ff46 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include @@ -331,7 +331,7 @@ struct wcd9335_codec { int comp_enabled[COMPANDER_MAX]; int intr1; - int reset_gpio; + struct gpio_desc *reset_gpio; struct regulator_bulk_data supplies[WCD9335_MAX_SUPPLY]; unsigned int rx_port_value[WCD9335_RX_MAX]; @@ -4975,12 +4975,11 @@ static const struct regmap_irq_chip wcd9335_regmap_irq1_chip = { static int wcd9335_parse_dt(struct wcd9335_codec *wcd) { struct device *dev = wcd->dev; - struct device_node *np = dev->of_node; int ret; - wcd->reset_gpio = of_get_named_gpio(np, "reset-gpios", 0); - if (wcd->reset_gpio < 0) - return dev_err_probe(dev, wcd->reset_gpio, "Reset GPIO missing from DT\n"); + wcd->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS); + if (IS_ERR(wcd->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd->reset_gpio), "Reset GPIO missing from DT\n"); wcd->mclk = devm_clk_get(dev, "mclk"); if (IS_ERR(wcd->mclk)) @@ -5023,9 +5022,9 @@ static int wcd9335_power_on_reset(struct wcd9335_codec *wcd) */ usleep_range(600, 650); - gpio_direction_output(wcd->reset_gpio, 0); + gpiod_set_value(wcd->reset_gpio, 1); msleep(20); - gpio_set_value(wcd->reset_gpio, 1); + gpiod_set_value(wcd->reset_gpio, 0); msleep(20); return 0;