From patchwork Mon Mar 24 02:26:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 876096 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76D2D176AA1; Mon, 24 Mar 2025 02:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783295; cv=fail; b=TWvFwnQDQEVGsJ3Cc+EzcweOlGnCbhhAeRBM3HqxSCu+affCbvFEVbs32MsQAdJRj2ZmwaMxMkAYQdPDRt/kzpixOq1Z76ZvZehpn0Ql3DirVnM9Cps+5CA0dcWIhnvLSQiawxWEOwhNgIn49CZ/8OvdaFsDAHh9q7Fs1juVQqk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783295; c=relaxed/simple; bh=KBxeSXnXKIjfokub+bLhLidG9dyvfKY3BY7BhN7WgKw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=qNjms2FOW4TaZVE6vT/G6vQZdC/n3KsO3XzbXwtviHrDAv/p8wbnM5DU0AILqmje6lPjQX9HFaCXdsC5/uGtMwrjORwzJvyjGtudjyMxkZGz2wErjpsOIeyIQ7nAmYThWeHQKr7PgYFTl7jlyffUcUaZXkPyqTEuZ2pDl4Y5VxU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Y1jZiPAi; arc=fail smtp.client-ip=40.107.21.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Y1jZiPAi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hv3CcZJCiqnCWFeGmQRGXOaMOrn/QaXDj/rteDAAYtAd5+knpJVUTG80EiQxTBuyibH0877nkIlz0L68FfdA0zJ9G2XxwlQaTZxYLRxA9refANoJUawcy+DIyoTbh8iPAarTyVlMbKpZzNYNVc7prVyGktGi5KnMp56vTlD8dL/LlBfUak6xcgZ9L7BJ6N/pdMXfEn9oV7bAGjET5ywQ7L3OvRQmQMiEZZ4YqNJDKfmV6n7jrVrvQCbedt369Cn2aNKO2I3Vht2nE7rJvdyK+/GZ9dKs0r27HKxa2RU0+LzGQZb0kefuqv5HdJTygr4rp2bBbHB4i1w/PN1OYtaArg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J1aHxFRghZpOloeIDuKT6dsTXgOvoW/mciMTe63j39Y=; b=vdx65RNE3D+nXVn2y0FTHMZF0pU5pb0QQKG3L44zU0apf7PcmPzSSY8YC28BHvXhiIFcLL4nCIZ6opfGILae36/rlwFfF1DnbhpPOlvxMfK5c0HesWQWxBxxvOVaEJZbZvipz3kig072ZkYJwHV5SHQxiuIvWjlh4vxxxjMgQWHu45r1Omr3LAZ79Szed27rZhtgpMEqzGJ3e/UQ344ptFeC/4qFrXh2OSDtvR8gBhboxXLVishhwt4DCrEBAqTb9DZemX5wqE9DJLa0uPsS0LGpGkq2+Egxb3Op8G2u9aAAhqg7O7v9hjFu3uclEkErq2yFmKI8K8yppnn020H3AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J1aHxFRghZpOloeIDuKT6dsTXgOvoW/mciMTe63j39Y=; b=Y1jZiPAiulZEq+6J5VrxhlMZ+9tKkJpAZDtTPFivKcuKxJn3rOKXgpOe5C5odjSp+2tLa3x2PxBVmQLC/Qzy+jCpupBxwib2K70WtSpoVyKKwMIquCZzQLJK/679wDDNeLKKJIWAIv1tRbOlVO3nl+FgJom+E8QUG1GuclJHu2rAnq4C71sRBbd73morBzSVui7kqA/UiHJWFKVk3J55GjkG4kPOHDuqEuL4dXs+K/iYZ5dvQxo4GncGj+1gB0W3omWFIJh7Q85jAdLS1wEFDyht4XKmTX28E29W6OYcfVFtVUxOudKL8cmsjgUL3TxGiww5QJ10ha8k8bTxW2FrkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7036.eurprd04.prod.outlook.com (2603:10a6:10:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 02:28:09 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 02:28:09 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 10:26:55 +0800 Subject: [PATCH 2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v1-2-27afa472e331@nxp.com> References: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742783224; l=2428; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=vXU5oXYDT7pq3hwycqWjcyFZmAO8bXnWtI77J5aaCG8=; b=Fm36vZcx4B+KH/INgDc/rnJ6v+ZEwNV1LwL/9wre18nc6M5z1AONBCk/rurqhQJ214wwBGfvZ N/Dy2rcijNYC8G3Y3Uxc745Lzi17uhHqntYxJyYKfDHVUl3k8B65VBn X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7036:EE_ X-MS-Office365-Filtering-Correlation-Id: affe3574-8ef1-4e6d-080a-08dd6a7b844e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|7416014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?m93OsI9ZFwF19QbhkOYmorFmmKR8QsF?= =?utf-8?q?pKzoV1+aY2gTP3iJENHgz7WF9N6u8bfcflcFoosNNZKm7WMUA0rCt0vmHijvIbkIM?= =?utf-8?q?UwW8cWbLQ9GSqUN0sNDCjI/QfTiolXmsnTOiDPf+ipw0mPFRTn37TV1S76U0cs5cL?= =?utf-8?q?kxhzTxZou7SBHelgGXh4YYj3tgyObAuk/i1N6eteWG3vkCLKl9zwLjTZBk7VvFo5X?= =?utf-8?q?X2eiVw0qlGrJkwS8Wj+jhd0VLDdBC6M+P+7kXHJXVN9NUKH2YqhwHqAfpkF/mwMXN?= =?utf-8?q?30l55eS52Kr+Cr7PFG1jpsMkfyrCGCewutSdXQEtHfc9MGSf59SVvgb+Ppy8PnKQV?= =?utf-8?q?nfU1pwnUlebeIuL6v/UFRL48KGBR+dRTwn7kDJQhC1pB3C+tcnZxp4VG1xGKSTLSO?= =?utf-8?q?/MdJglW1cEaSIbnV9/1k2jftv5egEY3LRVuVfKeF2F+mXoMRrxDB1ZU/OGJtlEg3R?= =?utf-8?q?G55IBb5a+xQRzn1E1Q8MoLF40XzdEptnbA2hu62gfbByznWV3np+7FHynm6lTEbr4?= =?utf-8?q?JqRywD8cMpXFiyJMC7KWCSOxeLsZuakCPsCAHknFX6LJkDrv/EbyhcZRwP3UADXNs?= =?utf-8?q?hs1ZYGmMwc9zqeDM1E9QIDSuWCpXjuBqawDLXpj+3R1VDdrxt3synkn9lOEGauj0t?= =?utf-8?q?TxbquCVIg/x4lzz7ONbZWF+uemqM6/ci1PUNwr5uA1hdi+CuKd74Z4Y5ZUTm3flQk?= =?utf-8?q?Bla0yS/L4El1+3UT9vUKiaa6zPmKxLnDBxBBcgpBHYd3BJurn8I3lR786dUs+82K4?= =?utf-8?q?B+MLo3sFgI4G5dwGoOPMEAT5iQbWa+uPsdwrL4FAxn74eajrU9wItXUxh68sPWYy6?= =?utf-8?q?IUJLNZceHYDZEeQvq1TpD92TAGgHXGN2yLqG/TpkS8n3InYW85AO50tZk4osK8MRe?= =?utf-8?q?XuuzSPyysJMRMZ2AM5hOV2TMaibsUjOA0NEaM+M2vBuJEm8643LoQ2h2d+CPpXvcV?= =?utf-8?q?abqYDPq8JLO8rWoQ3dBzYDk0s+DAoMSaasgbNl4EP9/mvmJCCMaXUrmguK/anR4y+?= =?utf-8?q?n4uZcMRxHgrfBH3OV17ZAPe3nDUx82M1ORL5FDf/TH+dB8Qk/HGWwfDd5nE7xasXm?= =?utf-8?q?hPaQ1BsWia6E+uy0eIPMwJkWjRGWz9lpQol6Y/xV6niB4GheBhQchykHdoNPogY/g?= =?utf-8?q?DmSn9+Bxhlcyx+dU076x4sTSz2pNE+BR2k4YtwW85GWFa0GujOt2qmtwQByCL6ctJ?= =?utf-8?q?PBt754N75YHMjrg/kSRps+rm/2N1joj/xEQQxu+rrQQnz0QAiheOwQ9vOF5hdgakJ?= =?utf-8?q?UXL5gBLVkditlKJxmSfLwq433XPsRv9qCJajSaw0p3PskAKeWJyGnoX9LBo6/Gvgm?= =?utf-8?q?C43/EbavmUrhNCdfrFiFqru3DrKCQXCxkqqJxQeIozOg/5rt18eTMLTYmwqwZHvmH?= =?utf-8?q?b3+6KlkNSvs?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(7416014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?gDE04ax21gNt5RE+Q012XSkm+GU1?= =?utf-8?q?F12vQMQ4R++G7Q/r6geX1Cc90dwzWkDvejRP33q/lCEllTHqzmYCw82U2M0z6Wb96?= =?utf-8?q?yCS+thyBRw5Kx84YNmLs92l5JuxNWt4Rh/79iBF5V4ZQ8U8spDCmklLXaAiYGF8Yu?= =?utf-8?q?XvA2dEMh9mwrVSUMCTrawB3nA3cAMY6k0Ir8o/OzFr4zzDpULtk+m9nIM+tMoEi0s?= =?utf-8?q?Tqch0uRzEOL18SduMUs/NuZ2YNlwC1ZR+Ah40E983CGjSY9fZgtrZy+bqV3o1pg1S?= =?utf-8?q?2J6TtzHc+0RVGdez/Ra063IRbtjfa8A9uUC/6ouwK7hT0xWPuUwavl8bKN7zWNC4Y?= =?utf-8?q?DAXtnb3Y6niJ+J/ReReIQHRLyRjMQPXyRIzd3AEJZuMth0o/IqfD6eVb2qIYwp4MO?= =?utf-8?q?RGGZZM2+Eh5xLNiwq0qba0DK0OCskOPYCYI/wCQqP0XF92080JbEBBYsaPGFVnBkQ?= =?utf-8?q?Wtfn2h9Hl8W4jgNE2u7JaEvhT6RZQRW7mA5qUsgEy6UYsRdQ+l+HSR3bhnm5vltpP?= =?utf-8?q?yc1hZD30AI5II782MhA8lrm7lWgTk55ipwf+EiaGrU9QVtRxhzArHsVNn3GMWCUfB?= =?utf-8?q?CrmGKBY4JhQ4HDkOK02HlFARljQ0lE8EVJUGD/332eXcUM6Q/S9+fpXZQk0+R4suN?= =?utf-8?q?7g8rzE22hTHeLGa1m5cXiL3vxBz/Dv4tKoeIM90sKnGrcfBlp/ypJGcVhI3Ktc/39?= =?utf-8?q?q71hgz+W9LceCbni5wRm3QorgUhLAvo6aGBF2r3qQMKQaMKaoP8t/nTbaS7Q3AUSR?= =?utf-8?q?kw/flclhu7SOxIhQRmJroCm6GgxKQB7+QER9nAFYo7S8ZsKD5Rz8pkbyBW1ey/R8m?= =?utf-8?q?qqMc+FsFi+yTQqrFEmytauCF1yDY9ZQ+aGZf89+7uA0dkJ+Poehi5xzrOPzjnF194?= =?utf-8?q?ww6vBDgy+LqlutEsXmjC/uBRabtn7hsRdQoHy6IBwFTO/fL8TK8pn3GI9PhpoitLC?= =?utf-8?q?MyCDJP0c6sJBv2iva6lZsgrRSDlrB7eEhZ2bM1LxjdoLtUcQdKLjRFYRXwwZeUG7j?= =?utf-8?q?jDvSJ47hwKrpggSgROPX/w2v26CiFPZEjFDm1ew9wXpLhCERul80vib7B228S/7nV?= =?utf-8?q?LtwmZVxaYybKBEQo7aW9YZubaMnX6CaJDNi5fOd7wzffT15hzYtA8kQg8RTquHU5E?= =?utf-8?q?99+9mKwiLLAL0y9uhAfHuxKnGfuoc9zsPLHsqaSql4tWtvY/Rn7ONqUjV/XGBx4U6?= =?utf-8?q?R0rvR31tofH/RTZQMH0w4c0fs0mD8vtzhQGs/s5bFCUsuzLbYJpDDApUiO0ONVTVa?= =?utf-8?q?1EMwUxJpoBpAGQgo9+tOMPgj9dwT81oE6F95q021PuJ6L1hWP7nqC2FFaDdvFiFlN?= =?utf-8?q?uCcjGSnz4e05Caku7dHXfMVdkFTeP5hlZnP4Y364u7Xr5SOCzy8C1dx5TvkxPHv9v?= =?utf-8?q?qvh8NXe+2W0cDFu0IZx1k9ceRlXq2QhvqIiJpGTiSxhjj+4bJH5Ue8jzc+y00Qa6Z?= =?utf-8?q?YNEIV0ijuoRWy8RpSMUWetgtgQh4sjlQcvjNIJVkE6wCbmlRnNC37OY2MBGYxVTjO?= =?utf-8?q?HxfOLUeLGIsa?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: affe3574-8ef1-4e6d-080a-08dd6a7b844e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 02:28:09.0778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ris/F3gmZ4u7INJ0utGpETmaefcL1brK8NOdsIC/7b1rRKJhToeBO+qzKsndpWY0bN9KVuEYtC1jOf/y0bts/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7036 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_ASIS when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. Signed-off-by: Peng Fan --- sound/soc/codecs/wcd938x.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 1ae498c323912ed799dcc033e7777936d90c9284..c70da29406f36883e4926eca40ab5ba5df02c383 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -171,7 +170,7 @@ struct wcd938x_priv { int flyback_cur_det_disable; int ear_rx_path; int variant; - int reset_gpio; + struct gpio_desc *reset_gpio; struct gpio_desc *us_euro_gpio; u32 micb1_mv; u32 micb2_mv; @@ -3251,9 +3250,9 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device struct wcd_mbhc_config *cfg = &wcd938x->mbhc_cfg; int ret; - wcd938x->reset_gpio = of_get_named_gpio(dev->of_node, "reset-gpios", 0); - if (wcd938x->reset_gpio < 0) - return dev_err_probe(dev, wcd938x->reset_gpio, + wcd938x->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS); + if (IS_ERR(wcd938x->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd938x->reset_gpio), "Failed to get reset gpio\n"); wcd938x->us_euro_gpio = devm_gpiod_get_optional(dev, "us-euro", @@ -3297,10 +3296,10 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device static int wcd938x_reset(struct wcd938x_priv *wcd938x) { - gpio_direction_output(wcd938x->reset_gpio, 0); + gpiod_set_value(wcd938x->reset_gpio, 1); /* 20us sleep required after pulling the reset gpio to LOW */ usleep_range(20, 30); - gpio_set_value(wcd938x->reset_gpio, 1); + gpiod_set_value(wcd938x->reset_gpio, 0); /* 20us sleep required after pulling the reset gpio to HIGH */ usleep_range(20, 30);