| Message ID | 20240816-qcm6490-lpass-reset-v1-1-a11f33cad3c5@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Update LPASS Audio clock driver for QCM6490 board | expand |
On 16/08/2024 10:32, Taniya Das wrote: > Add the new QCM6490 compatible to support the reset functionality for > Low Power Audio subsystem. > > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> Subject is odd - I do not see here anything related to boards. Anyway, this is incomplete. Look at the rest of the binding - you did not update any part related to proper clock constraints. Best regards, Krzysztof
On 8/17/2024 2:51 PM, Krzysztof Kozlowski wrote: > On 16/08/2024 10:32, Taniya Das wrote: >> Add the new QCM6490 compatible to support the reset functionality for >> Low Power Audio subsystem. >> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > > Subject is odd - I do not see here anything related to boards. > > Anyway, this is incomplete. Look at the rest of the binding - you did > not update any part related to proper clock constraints. > Not sure if I understand the concern, but I was of the opinion that I have added a new compatible for QCM6490 board , but no new clock constraint added. I see a patch from you https://lore.kernel.org/all/20240817094605.27185-1-krzysztof.kozlowski@linaro.org/ and I guess it fixes the constraints. Please help with your comments further. > Best regards, > Krzysztof >
On 13/09/2024 07:18, Taniya Das wrote: > > > On 8/17/2024 2:51 PM, Krzysztof Kozlowski wrote: >> On 16/08/2024 10:32, Taniya Das wrote: >>> Add the new QCM6490 compatible to support the reset functionality for >>> Low Power Audio subsystem. >>> >>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >> >> Subject is odd - I do not see here anything related to boards. >> >> Anyway, this is incomplete. Look at the rest of the binding - you did >> not update any part related to proper clock constraints. >> > > Not sure if I understand the concern, but I was of the opinion that I > have added a new compatible for QCM6490 board , but no new clock > constraint added. > > > I see a patch from you > https://lore.kernel.org/all/20240817094605.27185-1-krzysztof.kozlowski@linaro.org/ > and I guess it fixes the constraints. > Look at entire file. This is incomplete. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml index deee5423d66e..5d6f74cf9c43 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml @@ -26,6 +26,7 @@ properties: compatible: enum: + - qcom,qcm6490-lpassaudiocc - qcom,sc7280-lpassaoncc - qcom,sc7280-lpassaudiocc - qcom,sc7280-lpasscorecc
Add the new QCM6490 compatible to support the reset functionality for Low Power Audio subsystem. Signed-off-by: Taniya Das <quic_tdas@quicinc.com> --- Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscorecc.yaml | 1 + 1 file changed, 1 insertion(+)