| Message ID | 20240506150830.23709-6-johan+linaro@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp-x13s: enable pm8008 camera pmic | expand |
On 06/05/2024 16:08, Johan Hovold wrote: > Use lower case hex notation for consistency. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/mfd/qcom-pm8008.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c > index 42dd4bf039c9..f1c68b3da1b6 100644 > --- a/drivers/mfd/qcom-pm8008.c > +++ b/drivers/mfd/qcom-pm8008.c > @@ -38,8 +38,8 @@ enum { > > #define PM8008_PERIPH_0_BASE 0x900 > #define PM8008_PERIPH_1_BASE 0x2400 > -#define PM8008_PERIPH_2_BASE 0xC000 > -#define PM8008_PERIPH_3_BASE 0xC100 > +#define PM8008_PERIPH_2_BASE 0xc000 > +#define PM8008_PERIPH_3_BASE 0xc100 > > #define PM8008_TEMP_ALARM_ADDR PM8008_PERIPH_1_BASE > #define PM8008_GPIO1_ADDR PM8008_PERIPH_2_BASE > @@ -153,7 +153,7 @@ static const struct regmap_irq_chip pm8008_irq_chip = { > static struct regmap_config qcom_mfd_regmap_cfg = { > .reg_bits = 16, > .val_bits = 8, > - .max_register = 0xFFFF, > + .max_register = 0xffff, > }; > > static int pm8008_probe(struct i2c_client *client) Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Quoting Johan Hovold (2024-05-06 08:08:22) > Use lower case hex notation for consistency. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c index 42dd4bf039c9..f1c68b3da1b6 100644 --- a/drivers/mfd/qcom-pm8008.c +++ b/drivers/mfd/qcom-pm8008.c @@ -38,8 +38,8 @@ enum { #define PM8008_PERIPH_0_BASE 0x900 #define PM8008_PERIPH_1_BASE 0x2400 -#define PM8008_PERIPH_2_BASE 0xC000 -#define PM8008_PERIPH_3_BASE 0xC100 +#define PM8008_PERIPH_2_BASE 0xc000 +#define PM8008_PERIPH_3_BASE 0xc100 #define PM8008_TEMP_ALARM_ADDR PM8008_PERIPH_1_BASE #define PM8008_GPIO1_ADDR PM8008_PERIPH_2_BASE @@ -153,7 +153,7 @@ static const struct regmap_irq_chip pm8008_irq_chip = { static struct regmap_config qcom_mfd_regmap_cfg = { .reg_bits = 16, .val_bits = 8, - .max_register = 0xFFFF, + .max_register = 0xffff, }; static int pm8008_probe(struct i2c_client *client)
Use lower case hex notation for consistency. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/mfd/qcom-pm8008.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)