| Message ID | 20240323-fd-xml-shipped-v4-1-cca5e8457b9e@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm: generate register header files | expand |
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote: > In order to stop patching the mdp5 headers, import definitions for the > writeback blocks. This part is extracted from the old Rob's patch. > > Co-developed-by: Rob Clark <robdclark@gmail.com> > Signed-off-by: Rob Clark <robdclark@gmail.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > This is unused today right? Is it just being migrated now in advance as all the mesa mdp5 headers are moving to kernel? > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h > index 26c5d8b4ab46..4b988e69fbfc 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h > @@ -69,6 +69,16 @@ struct mdp5_mdp_block { > uint32_t caps; /* MDP capabilities: MDP_CAP_xxx bits */ > }; > > +struct mdp5_wb_instance { > + int id; > + int lm; > +}; > + > +struct mdp5_wb_block { > + MDP5_SUB_BLOCK_DEFINITION; > + struct mdp5_wb_instance instances[MAX_BASES]; > +}; > + > #define MDP5_INTF_NUM_MAX 5 > > struct mdp5_intf_block { > @@ -98,6 +108,7 @@ struct mdp5_cfg_hw { > struct mdp5_sub_block pp; > struct mdp5_sub_block dsc; > struct mdp5_sub_block cdm; > + struct mdp5_wb_block wb; > struct mdp5_intf_block intf; > struct mdp5_perf_block perf; > >
On Tue, 26 Mar 2024 at 23:39, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote: > > > > On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote: > > In order to stop patching the mdp5 headers, import definitions for the > > writeback blocks. This part is extracted from the old Rob's patch. > > > > Co-developed-by: Rob Clark <robdclark@gmail.com> > > Signed-off-by: Rob Clark <robdclark@gmail.com> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > This is unused today right? > > Is it just being migrated now in advance as all the mesa mdp5 headers > are moving to kernel? > Exactly. I had three options: pick up this patch, implement applying 'fixup' patches or drop corresponding doffests from the mdp5.xml. I've chosen the first option. -- With best wishes Dmitry
On 3/26/2024 2:52 PM, Dmitry Baryshkov wrote: > On Tue, 26 Mar 2024 at 23:39, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote: >> >> >> >> On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote: >>> In order to stop patching the mdp5 headers, import definitions for the >>> writeback blocks. This part is extracted from the old Rob's patch. >>> >>> Co-developed-by: Rob Clark <robdclark@gmail.com> >>> Signed-off-by: Rob Clark <robdclark@gmail.com> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h | 11 +++++++++++ >>> 1 file changed, 11 insertions(+) >>> >> >> This is unused today right? >> >> Is it just being migrated now in advance as all the mesa mdp5 headers >> are moving to kernel? >> > > Exactly. I had three options: pick up this patch, implement applying > 'fixup' patches or drop corresponding doffests from the mdp5.xml. I've > chosen the first option. > Yes, this is fine Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > > -- > With best wishes > Dmitry
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h index 26c5d8b4ab46..4b988e69fbfc 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h @@ -69,6 +69,16 @@ struct mdp5_mdp_block { uint32_t caps; /* MDP capabilities: MDP_CAP_xxx bits */ }; +struct mdp5_wb_instance { + int id; + int lm; +}; + +struct mdp5_wb_block { + MDP5_SUB_BLOCK_DEFINITION; + struct mdp5_wb_instance instances[MAX_BASES]; +}; + #define MDP5_INTF_NUM_MAX 5 struct mdp5_intf_block { @@ -98,6 +108,7 @@ struct mdp5_cfg_hw { struct mdp5_sub_block pp; struct mdp5_sub_block dsc; struct mdp5_sub_block cdm; + struct mdp5_wb_block wb; struct mdp5_intf_block intf; struct mdp5_perf_block perf;