| Message ID | 20240226195516.174737-1-raihan1999ahamed@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/2] dt-bindings: arm: qcom: Add Lenovo P2 | expand |
On Mon, Feb 26, 2024 at 1:56 PM Raihan Ahamed <raihan1999ahamed@gmail.com> wrote: > > Lenovo P2 is a handset using the MSM8953 SoC released in 2016 > > Add a device tree with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - WCNSS (WiFi/BT) > - Regulators > > Acked-by: Rob Herring <robh+dt@kernel.org> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> We gave no such tag. I'd suggest you go read what these mean. Rob
Sorry, I misunderstood the fact. Is it necessary to change the tags only by sending another version? On Tue, Feb 27, 2024 at 9:25 AM Rob Herring <robh+dt@kernel.org> wrote: > > On Mon, Feb 26, 2024 at 1:56 PM Raihan Ahamed > <raihan1999ahamed@gmail.com> wrote: > > > > Lenovo P2 is a handset using the MSM8953 SoC released in 2016 > > > > Add a device tree with initial support for: > > > > - GPIO keys > > - SDHCI (internal and external storage) > > - USB Device Mode > > - WCNSS (WiFi/BT) > > - Regulators > > > > Acked-by: Rob Herring <robh+dt@kernel.org> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > We gave no such tag. I'd suggest you go read what these mean. > > Rob
On 26/02/2024 20:54, Raihan Ahamed wrote: > Lenovo P2 is a handset using the MSM8953 SoC released in 2016 > > Add a device tree with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - WCNSS (WiFi/BT) > - Regulators > > Acked-by: Rob Herring <robh+dt@kernel.org> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> No, these did not happen! Best regards, Krzysztof
On Tue, 27 Feb 2024 01:24:41 +0530, Raihan Ahamed wrote: > Document the compatible for the MSM8953-based Lenovo P2 smartphone released in 2016. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found new DT warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/msm8953-lenovo-kuntao.dtb' for 20240226195516.174737-1-raihan1999ahamed@gmail.com: arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: gpu@1c00000: clock-names:5: 'anyOf' conditional failed, one must be fixed: 'core' was expected 'iface' was expected 'mem' was expected 'mem_iface' was expected 'alt_mem_iface' was expected 'gfx3d' was expected 'rbbmtimer' was expected 'rbcpr' was expected from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml# arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: iommu@1c48000: compatible: 'oneOf' conditional failed, one must be fixed: 'qcom,msm8953-iommu' is not one of ['qcom,msm8976-iommu'] 'qcom,msm-iommu-v1' was expected from schema $id: http://devicetree.org/schemas/iommu/qcom,iommu.yaml#
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 1a5fb889a444..6cc19c8d116d 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -263,6 +263,7 @@ properties: - items: - enum: + - lenovo,kuntao - motorola,potter - xiaomi,daisy - xiaomi,mido