From patchwork Thu Nov 9 23:54:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Marek X-Patchwork-Id: 742622 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7AE838FAD for ; Thu, 9 Nov 2023 23:56:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="J0p519Rt" Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9765420B for ; Thu, 9 Nov 2023 15:56:50 -0800 (PST) Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-7789577b53fso90478585a.3 for ; Thu, 09 Nov 2023 15:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1699574210; x=1700179010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KOGnrwGuPglkUh0+Fj19u8kSBzGFAbbmPxBOgbMVl8k=; b=J0p519Rt8Ua3wXuRjkUln7egoTJqPVxUaP5G0UQL3yCZQWHi7PYrWPIiafvqqzmjLJ tl8PrcOsxMmKPZbrtNIiqyr9LTn8urLLpyld/AAQ5XxauiA8IB8IOqpSlnBYZd8371na KCYemOqnh4NugGZTtwN1WzckYoY6XeMXOUVQ3Rucu+F8sURvar7t+Zr0CMZquFf4Tm6k 5Mnc2IlL+xubCps0iXc5osf8unoCs8geVlIgmIr4J/h9oS3LwDeOJ4AVRuYv7VIhBe14 tp0zlz520slZNj5fLn0KTXKwB+oJ09EIxkm6AfL2q/BYTIQysCwaBW+D1mYg7hqGYbDu cFFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699574210; x=1700179010; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KOGnrwGuPglkUh0+Fj19u8kSBzGFAbbmPxBOgbMVl8k=; b=AkpullITxUzVKgIInH65WxLQ17qYqcTaq+6VRlVK2dabYhHTdYHqn0V/F9n+GLYRHm HNLOxMKbRR1aD5lZva+mdVwoTnsRsh75bvJU5sMA7DgQDFfqzW3vnjV/VcrOVTGZ9a+m /K+GErLF84UllVDp993vRMRFR0xIwDVeX5cMYWRSCCChiFmDpfdcMEskkozXFtwHZ3zk AZYz1+L8DzUsDM+cNDmGbuqB2PVGCLFv1L41kmOkHkGhOrpavEVNAHvmPAM0GxJlHs8m evWN56R56jycadS0ht+yfZ99VUCIevWDUwCyC6O54aGQFp34oi6L++t8jB74yq3RRdVj Iwbw== X-Gm-Message-State: AOJu0Ywp6akXAccDWKzNv5uGE441qZg5S5qCOdX8SzncbZgmvmUAGgSi IRFAdB6G9VtywVoX4fpOAiEQrA== X-Google-Smtp-Source: AGHT+IGCEs76KiGmSEnDezMN2gqFvgJH8aqukcTT1Et69lNkzS+DPn40neuscPII0MMkpYwp9e1tCQ== X-Received: by 2002:a05:620a:29c9:b0:778:91f0:e541 with SMTP id s9-20020a05620a29c900b0077891f0e541mr7487802qkp.23.1699574210077; Thu, 09 Nov 2023 15:56:50 -0800 (PST) Received: from localhost.localdomain (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id bl1-20020a05620a1a8100b00777063b89casm299211qkb.5.2023.11.09.15.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 15:56:49 -0800 (PST) From: Jonathan Marek To: freedreno@lists.freedesktop.org Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Konrad Dybcio , Robert Foss , Vinod Koul , Neil Armstrong , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM ADRENO GPU), dri-devel@lists.freedesktop.org (open list:DRM DRIVER FOR MSM ADRENO GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy Date: Thu, 9 Nov 2023 18:54:10 -0500 Message-Id: <20231109235412.29343-1-jonathan@marek.ca> X-Mailer: git-send-email 2.26.1 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use the same value as the downstream driver. This change is needed for CPHY mode to work correctly. Fixes: 93f0ca6fd61c ("drm/msm/dsi: fix VREG_CTRL_1 value for 4nm cphy") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c index 3b1ed02f644d..89a6344bc865 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -918,7 +918,7 @@ static int dsi_7nm_phy_enable(struct msm_dsi_phy *phy, if ((phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V5_2)) { if (phy->cphy_mode) { vreg_ctrl_0 = 0x45; - vreg_ctrl_1 = 0x45; + vreg_ctrl_1 = 0x41; glbl_rescode_top_ctrl = 0x00; glbl_rescode_bot_ctrl = 0x00; } else {