| Message ID | 20231031163104.112469-20-benjamin.gaignard@collabora.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add DELETE_BUF ioctl | expand |
Hi Benjamin, W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze: > The above memset already zeroed all the ctx fields, it is useless > to do it here again. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> > --- > drivers/media/dvb-core/dvb_vb2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/dvb-core/dvb_vb2.c b/drivers/media/dvb-core/dvb_vb2.c > index 3a966fdf814c..a731b755a0b9 100644 > --- a/drivers/media/dvb-core/dvb_vb2.c > +++ b/drivers/media/dvb-core/dvb_vb2.c > @@ -177,7 +177,6 @@ int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int nonblocking) > q->ops = &dvb_vb2_qops; > q->mem_ops = &vb2_vmalloc_memops; > q->buf_ops = &dvb_vb2_buf_ops; > - q->num_buffers = 0; A few lines above this one is this: q->is_output = 0; Can this also be included in this (cleanup) patch? Regards, Andrzej > ret = vb2_core_queue_init(q); > if (ret) { > ctx->state = DVB_VB2_STATE_NONE;
Le 09/11/2023 à 10:50, Andrzej Pietrasiewicz a écrit : > Hi Benjamin, > > W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze: >> The above memset already zeroed all the ctx fields, it is useless >> to do it here again. >> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> >> --- >> drivers/media/dvb-core/dvb_vb2.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/dvb-core/dvb_vb2.c >> b/drivers/media/dvb-core/dvb_vb2.c >> index 3a966fdf814c..a731b755a0b9 100644 >> --- a/drivers/media/dvb-core/dvb_vb2.c >> +++ b/drivers/media/dvb-core/dvb_vb2.c >> @@ -177,7 +177,6 @@ int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const >> char *name, int nonblocking) >> q->ops = &dvb_vb2_qops; >> q->mem_ops = &vb2_vmalloc_memops; >> q->buf_ops = &dvb_vb2_buf_ops; >> - q->num_buffers = 0; > > A few lines above this one is this: > > q->is_output = 0; > > Can this also be included in this (cleanup) patch? Nice catch, I will add it. Thanks, Benjamin > > Regards, > > Andrzej > >> ret = vb2_core_queue_init(q); >> if (ret) { >> ctx->state = DVB_VB2_STATE_NONE; > > _______________________________________________ > Kernel mailing list -- kernel@mailman.collabora.com > To unsubscribe send an email to kernel-leave@mailman.collabora.com
diff --git a/drivers/media/dvb-core/dvb_vb2.c b/drivers/media/dvb-core/dvb_vb2.c index 3a966fdf814c..a731b755a0b9 100644 --- a/drivers/media/dvb-core/dvb_vb2.c +++ b/drivers/media/dvb-core/dvb_vb2.c @@ -177,7 +177,6 @@ int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int nonblocking) q->ops = &dvb_vb2_qops; q->mem_ops = &vb2_vmalloc_memops; q->buf_ops = &dvb_vb2_buf_ops; - q->num_buffers = 0; ret = vb2_core_queue_init(q); if (ret) { ctx->state = DVB_VB2_STATE_NONE;
The above memset already zeroed all the ctx fields, it is useless to do it here again. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> --- drivers/media/dvb-core/dvb_vb2.c | 1 - 1 file changed, 1 deletion(-)