From patchwork Fri Oct 13 11:48:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 733932 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B52CDB484 for ; Fri, 13 Oct 2023 11:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbjJMLtB (ORCPT ); Fri, 13 Oct 2023 07:49:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231451AbjJMLs6 (ORCPT ); Fri, 13 Oct 2023 07:48:58 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2743FD7 for ; Fri, 13 Oct 2023 04:48:57 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40572aeb6d0so20606485e9.1 for ; Fri, 13 Oct 2023 04:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1697197735; x=1697802535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4lyOHM/RBgmuxKTo/vmZ0oW2gfmzXsxTpr43TXFONHQ=; b=IyxTQBNUBn8rmejfIc3BIopFVVYZSzIjPk7Zzne3yZWknhQWh1wcuglbAY+wjrwBPi 3ChInU7QiVVar6M8joo3dFQFzPSKRWmerovkTWESEnsbov+hnUNsKRZaMTek8ZzLSXSF UTf78hCuZSACvwzb68f4Ci8flA4plebbWtnvYrMboHmKfpTNa/3/KUg53A+67gk5Q6TI 9QcLbb13o0QqmS9AF+j27lnJmKW1pYJziZ0uYOtKhU6VPUkfv8PsSuAq5SQYNlqwIA8M g5IvDn8R8eleUZly9qLG1a9HDN2Ma9aoqcZWqW3r15Pvpqu/+uDjiI64wMINMdgKJAag EX4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697197735; x=1697802535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4lyOHM/RBgmuxKTo/vmZ0oW2gfmzXsxTpr43TXFONHQ=; b=bFGiURW5x9PVTppZFoJtEXCK0DOH/363vU3b2k94FZtP5KQYwL9OmIXeTtRtRrKTKB f12YuPBhk/QlFT23JsjqW71h4AKWbeManf0/g9mrv0HrzIBDqkI1LkXGaJ4QMoeM9LE3 RneUfeWKW74y8E6rkJjehGBMWtH3S16ozNnNcFiN4B/8MF51gW5ZiTtL+oode2G/lKyf KTAOoPkgTXTVhORuSX0V/lCVRW6K4NhrL7sCOUNatZfsPIWCLnMiruRIX5+DLCZ9OiNZ paxNj82u/WcVp8C9WQ1+WRnxNkj/EvIemZyRb/WKsoIvZ4pHGeakqXJIo56MqlGIlDLJ FS5g== X-Gm-Message-State: AOJu0YyCAx3vJ+PIXCjeaxJzQP+YBtv9XUt5kZVj6PbEtudIZWeauZoJ 8XuGtVJWJs4b8+2xvM1boo5N0Q== X-Google-Smtp-Source: AGHT+IGwfVRxhdaPcrTgZudW4uBmd9NjhkZBeH0ym5/LLLLuWLxGrB4YZsbUy/eulNORH0ETqJvBVg== X-Received: by 2002:a05:600c:2a4e:b0:3fe:fc0f:52e2 with SMTP id x14-20020a05600c2a4e00b003fefc0f52e2mr23680112wme.37.1697197735644; Fri, 13 Oct 2023 04:48:55 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:4209:13a:988d:80be]) by smtp.gmail.com with ESMTPSA id j23-20020a05600c1c1700b00407754b998dsm974509wms.27.2023.10.13.04.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 04:48:55 -0700 (PDT) From: Bartosz Golaszewski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Elliot Berman , Krzysztof Kozlowski , Guru Das Srinagesh , Andrew Halaney , Maximilian Luz , Alex Elder , Srini Kandagatla Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@quicinc.com, Bartosz Golaszewski Subject: [PATCH v4 03/15] firmware: qcom: scm: remove unneeded 'extern' specifiers Date: Fri, 13 Oct 2023 13:48:31 +0200 Message-Id: <20231013114843.63205-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231013114843.63205-1-brgl@bgdev.pl> References: <20231013114843.63205-1-brgl@bgdev.pl> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Bartosz Golaszewski 'extern' specifiers do nothing for function declarations. Remove them from the private qcom-scm header. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Halaney --- drivers/firmware/qcom/qcom_scm.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/qcom/qcom_scm.h b/drivers/firmware/qcom/qcom_scm.h index c88e29051d20..4532907e8489 100644 --- a/drivers/firmware/qcom/qcom_scm.h +++ b/drivers/firmware/qcom/qcom_scm.h @@ -66,18 +66,17 @@ int qcom_scm_wait_for_wq_completion(u32 wq_ctx); int scm_get_wq_ctx(u32 *wq_ctx, u32 *flags, u32 *more_pending); #define SCM_SMC_FNID(s, c) ((((s) & 0xFF) << 8) | ((c) & 0xFF)) -extern int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc, - enum qcom_scm_convention qcom_convention, - struct qcom_scm_res *res, bool atomic); +int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc, + enum qcom_scm_convention qcom_convention, + struct qcom_scm_res *res, bool atomic); #define scm_smc_call(dev, desc, res, atomic) \ __scm_smc_call((dev), (desc), qcom_scm_convention, (res), (atomic)) #define SCM_LEGACY_FNID(s, c) (((s) << 10) | ((c) & 0x3ff)) -extern int scm_legacy_call_atomic(struct device *dev, - const struct qcom_scm_desc *desc, - struct qcom_scm_res *res); -extern int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, +int scm_legacy_call_atomic(struct device *dev, const struct qcom_scm_desc *desc, struct qcom_scm_res *res); +int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, + struct qcom_scm_res *res); #define QCOM_SCM_SVC_BOOT 0x01 #define QCOM_SCM_BOOT_SET_ADDR 0x01