diff mbox series

[v2,1/2] arm64: dts: qcom: sdm845: Fix PSCI power domain names

Message ID 20230912071205.11502-1-david@ixit.cz
State Accepted
Commit a5f01673d3946e424091e6b8ff274716f9c21454
Headers show
Series [v2,1/2] arm64: dts: qcom: sdm845: Fix PSCI power domain names | expand

Commit Message

David Heidelberg Sept. 12, 2023, 7:12 a.m. UTC
The original commit hasn't been updated according to
refactoring done in sdm845.dtsi.

Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
v2:
 - removed power-domains from apps_rsc

 arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

Comments

Abel Vesa Sept. 12, 2023, 9:51 a.m. UTC | #1
On 23-09-12 12:42:03, David Heidelberg wrote:
> The original commit hasn't been updated according to
> refactoring done in sdm845.dtsi.
> 
> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

> ---
> v2:
>  - removed power-domains from apps_rsc
> 
>  arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> index 50934d4ab3bc..e0ee91225eec 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> @@ -144,15 +144,15 @@ panel_in_edp: endpoint {
>  };
>  
>  &psci {
> -	/delete-node/ cpu0;
> -	/delete-node/ cpu1;
> -	/delete-node/ cpu2;
> -	/delete-node/ cpu3;
> -	/delete-node/ cpu4;
> -	/delete-node/ cpu5;
> -	/delete-node/ cpu6;
> -	/delete-node/ cpu7;
> -	/delete-node/ cpu-cluster0;
> +	/delete-node/ power-domain-cpu0;
> +	/delete-node/ power-domain-cpu1;
> +	/delete-node/ power-domain-cpu2;
> +	/delete-node/ power-domain-cpu3;
> +	/delete-node/ power-domain-cpu4;
> +	/delete-node/ power-domain-cpu5;
> +	/delete-node/ power-domain-cpu6;
> +	/delete-node/ power-domain-cpu7;
> +	/delete-node/ power-domain-cluster;
>  };
>  
>  &cpus {
> @@ -338,6 +338,8 @@ flash@0 {
>  
>  
>  &apps_rsc {
> +	/delete-property/ power-domains;
> +
>  	regulators-0 {
>  		compatible = "qcom,pm8998-rpmh-regulators";
>  		qcom,pmic-id = "a";
> -- 
> 2.40.1
>
Stephen Boyd Sept. 12, 2023, 6:09 p.m. UTC | #2
Quoting David Heidelberg (2023-09-12 00:12:03)
> The original commit hasn't been updated according to
> refactoring done in sdm845.dtsi.
>
> Fixes: a1ade6cac5a2 ("arm64: dts: qcom: sdm845: Switch PSCI cpu idle states from PC to OSI")
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Bjorn Andersson Sept. 14, 2023, 4:04 p.m. UTC | #3
On Tue, 12 Sep 2023 12:42:03 +0530, David Heidelberg wrote:
> The original commit hasn't been updated according to
> refactoring done in sdm845.dtsi.
> 
> 

Applied, thanks!

[1/2] arm64: dts: qcom: sdm845: Fix PSCI power domain names
      commit: a5f01673d3946e424091e6b8ff274716f9c21454
[2/2] arm64: dts: qcom: sdm845: cheza doesn't support LMh node
      commit: 197ae69d1caedb3203e0b189a39efb820675fd5c

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index 50934d4ab3bc..e0ee91225eec 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -144,15 +144,15 @@  panel_in_edp: endpoint {
 };
 
 &psci {
-	/delete-node/ cpu0;
-	/delete-node/ cpu1;
-	/delete-node/ cpu2;
-	/delete-node/ cpu3;
-	/delete-node/ cpu4;
-	/delete-node/ cpu5;
-	/delete-node/ cpu6;
-	/delete-node/ cpu7;
-	/delete-node/ cpu-cluster0;
+	/delete-node/ power-domain-cpu0;
+	/delete-node/ power-domain-cpu1;
+	/delete-node/ power-domain-cpu2;
+	/delete-node/ power-domain-cpu3;
+	/delete-node/ power-domain-cpu4;
+	/delete-node/ power-domain-cpu5;
+	/delete-node/ power-domain-cpu6;
+	/delete-node/ power-domain-cpu7;
+	/delete-node/ power-domain-cluster;
 };
 
 &cpus {
@@ -338,6 +338,8 @@  flash@0 {
 
 
 &apps_rsc {
+	/delete-property/ power-domains;
+
 	regulators-0 {
 		compatible = "qcom,pm8998-rpmh-regulators";
 		qcom,pmic-id = "a";