diff mbox series

[1/7] dt-bindings: arm: qcom,ids: Add SoC ID for SM7125

Message ID 20230704163848.169853-3-davidwronek@gmail.com
State Superseded
Headers show
Series Add initial support for SM7125 and Xiaomi SM7125 platform | expand

Commit Message

David Wronek July 4, 2023, 4:31 p.m. UTC 
From: map220v <map220v300@gmail.com>

Add the SoC ID for Qualcomm SM7125.

Signed-off-by: map220v <map220v300@gmail.com>
Signed-off-by: David Wronek <davidwronek@gmail.com>
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski July 5, 2023, 9:46 a.m. UTC | #1 
On 04/07/2023 18:31, David Wronek wrote:
> From: map220v <map220v300@gmail.com>
> 
> Add the SoC ID for Qualcomm SM7125.
> 
> Signed-off-by: map220v <map220v300@gmail.com>

We accept known identities, but this looks like a nickname/pseudonym.
Are you sure you got such SoB from map220v?

None of the commits here:
https://github.com/map220v/sm7125-mainline/commits/a72q-6.0
have signed-off-by. Did you add it by yourself?

Best regards,
Krzysztof
David Wronek July 5, 2023, 3:48 p.m. UTC | #2 
On Wed, Jul 5, 2023 at 11:46 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 04/07/2023 18:31, David Wronek wrote:
> > From: map220v <map220v300@gmail.com>
> >
> > Add the SoC ID for Qualcomm SM7125.
> >
> > Signed-off-by: map220v <map220v300@gmail.com>
>
> We accept known identities, but this looks like a nickname/pseudonym.
> Are you sure you got such SoB from map220v?
>
> None of the commits here:
> https://github.com/map220v/sm7125-mainline/commits/a72q-6.0
> have signed-off-by. Did you add it by yourself?
>
> Best regards,
> Krzysztof
>
(Please ignore my E-Mail from before, I forgot to click "reply all")

I have asked map220v for permission to add their Signed-off-by to the commits
and this is the one they gave me. Is the nickname a problem?

Sincerely,
David
Krzysztof Kozlowski July 6, 2023, 6:09 a.m. UTC | #3 
On 05/07/2023 17:48, David Wronek wrote:
> On Wed, Jul 5, 2023 at 11:46 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 04/07/2023 18:31, David Wronek wrote:
>>> From: map220v <map220v300@gmail.com>
>>>
>>> Add the SoC ID for Qualcomm SM7125.
>>>
>>> Signed-off-by: map220v <map220v300@gmail.com>
>>
>> We accept known identities, but this looks like a nickname/pseudonym.
>> Are you sure you got such SoB from map220v?
>>
>> None of the commits here:
>> https://github.com/map220v/sm7125-mainline/commits/a72q-6.0
>> have signed-off-by. Did you add it by yourself?
>>
>> Best regards,
>> Krzysztof
>>
> (Please ignore my E-Mail from before, I forgot to click "reply all")
> 
> I have asked map220v for permission to add their Signed-off-by to the commits
> and this is the one they gave me. Is the nickname a problem?

Yes, because it looks anonymous. We need known identity. Just take the
ownership of the patches...

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index bcbe9ee2cdaf..6a8dd2e42b24 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -215,6 +215,7 @@ 
 #define QCOM_ID_SDA429W			437
 #define QCOM_ID_SM8350			439
 #define QCOM_ID_QCM2290			441
+#define QCOM_ID_SM7125			443
 #define QCOM_ID_SM6115			444
 #define QCOM_ID_IPQ5010			446
 #define QCOM_ID_IPQ5018			447