| Message ID | 20230628-topic-a7xx_drmmsm-v1-2-a7f4496e0c12@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | A7xx support | expand |
On 28/06/2023 22:35, Konrad Dybcio wrote: > When booting the GMU, the QMP mailbox should be pinged about some tunables > (e.g. adaptive clock distribution state). To achieve that, a reference to > it is necessary. Allow it and require it with A730. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/gmu.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml > index 20ddb89a4500..9e6c4e0ab071 100644 > --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml > +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml > @@ -64,6 +64,10 @@ properties: > iommus: > maxItems: 1 > > + qcom,qmp: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Phandle to the QMP mailbox mailbox would suggest you should use mailbox properties. Instead maybe "Always On Subsystem (AOSS)" or just use existing description. I assume it's exactly the same. Best regards, Krzysztof
On 4.07.2023 10:29, Krzysztof Kozlowski wrote: > On 28/06/2023 22:35, Konrad Dybcio wrote: >> When booting the GMU, the QMP mailbox should be pinged about some tunables >> (e.g. adaptive clock distribution state). To achieve that, a reference to >> it is necessary. Allow it and require it with A730. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> Documentation/devicetree/bindings/display/msm/gmu.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml >> index 20ddb89a4500..9e6c4e0ab071 100644 >> --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml >> @@ -64,6 +64,10 @@ properties: >> iommus: >> maxItems: 1 >> >> + qcom,qmp: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Phandle to the QMP mailbox > > mailbox would suggest you should use mailbox properties. That won't be a very strong argument at all, but the Linux mailbox framework did not at all fit the JSON-like nature of this mbox and it ended up being its own thing.. > Instead maybe > "Always On Subsystem (AOSS)" or just use existing description. I assume > it's exactly the same. I don't think I quite get what you mean. Konrad > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml index 20ddb89a4500..9e6c4e0ab071 100644 --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml @@ -64,6 +64,10 @@ properties: iommus: maxItems: 1 + qcom,qmp: + $ref: /schemas/types.yaml#/definitions/phandle + description: Phandle to the QMP mailbox + operating-points-v2: true opp-table: @@ -251,6 +255,9 @@ allOf: - const: hub - const: demet + required: + - qcom,qmp + - if: properties: compatible:
When booting the GMU, the QMP mailbox should be pinged about some tunables (e.g. adaptive clock distribution state). To achieve that, a reference to it is necessary. Allow it and require it with A730. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 7 +++++++ 1 file changed, 7 insertions(+)