| Message ID | 20230620-topic-dsiphy_rpm-v2-2-a11a751f34f0@linaro.org |
|---|---|
| State | Accepted |
| Commit | 6ab502bc1cf3147ea1d8540d04b83a7a4cb6d1f1 |
| Headers | show |
| Series | DSIPHY RPM | expand |
On 20/06/2023 14:43, Konrad Dybcio wrote: > Some devices power the DSI PHY/PLL through a power rail that we model > as a GENPD. Enable runtime PM to make it suspendable. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> So, we were calling pm_runtime_get/put, but we didn't have runtime PM enabled for this device? It might be a nice place for dev_warn() in the driver core. Nevertheless: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index 2f319e0eb74f..22431e106529 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -689,6 +689,10 @@ static int dsi_phy_driver_probe(struct platform_device *pdev) > return dev_err_probe(dev, PTR_ERR(phy->ahb_clk), > "Unable to get ahb clk\n"); > > + ret = devm_pm_runtime_enable(&pdev->dev); > + if (ret) > + return ret; > + > /* PLL init will call into clk_register which requires > * register access, so we need to enable power and ahb clock. > */ >
diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index 2f319e0eb74f..22431e106529 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c @@ -689,6 +689,10 @@ static int dsi_phy_driver_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(phy->ahb_clk), "Unable to get ahb clk\n"); + ret = devm_pm_runtime_enable(&pdev->dev); + if (ret) + return ret; + /* PLL init will call into clk_register which requires * register access, so we need to enable power and ahb clock. */
Some devices power the DSI PHY/PLL through a power rail that we model as a GENPD. Enable runtime PM to make it suspendable. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 ++++ 1 file changed, 4 insertions(+)