diff mbox series

[v8,01/11] dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs

Message ID 20230526192210.3146896-2-bhupesh.sharma@linaro.org
State Superseded
Headers show
Series arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs | expand

Commit Message

Bhupesh Sharma May 26, 2023, 7:22 p.m. UTC 
Add new compatible for BAM DMA engine version v1.7.4 which is
found on Qualcomm SM6115 and QCM2290 SoCs. Since its very similar
to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme
accordingly.

While at it, also update qcom,bam-dma bindings to add comments
which describe the BAM DMA versions used in SM8150 and SM8250 SoCs.
This provides an easy reference for identifying the actual BAM DMA
version available on Qualcomm SoCs.

Acked-by: Rob Herring <robh@kernel.org>
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 .../devicetree/bindings/dma/qcom,bam-dma.yaml | 20 ++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

Comments

Bhupesh Sharma June 6, 2023, 8:14 a.m. UTC | #1 
On Mon, 29 May 2023 at 11:43, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
>
> Hi Vinod,
>
> > On Sat, 27 May 2023 at 00:52, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
> >
> > Add new compatible for BAM DMA engine version v1.7.4 which is
> > found on Qualcomm SM6115 and QCM2290 SoCs. Since its very similar
> > to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme
> > accordingly.
> >
> > While at it, also update qcom,bam-dma bindings to add comments
> > which describe the BAM DMA versions used in SM8150 and SM8250 SoCs.
> > This provides an easy reference for identifying the actual BAM DMA
> > version available on Qualcomm SoCs.
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> > Tested-by: Anders Roxell <anders.roxell@linaro.org>
> > Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
> >  .../devicetree/bindings/dma/qcom,bam-dma.yaml | 20 ++++++++++++-------
> >  1 file changed, 13 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> > index f1ddcf672261..c663b6102f50 100644
> > --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> > @@ -15,13 +15,19 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    enum:
> > -        # APQ8064, IPQ8064 and MSM8960
> > -      - qcom,bam-v1.3.0
> > -        # MSM8974, APQ8074 and APQ8084
> > -      - qcom,bam-v1.4.0
> > -        # MSM8916 and SDM845
> > -      - qcom,bam-v1.7.0
> > +    oneOf:
> > +      - enum:
> > +          # APQ8064, IPQ8064 and MSM8960
> > +          - qcom,bam-v1.3.0
> > +          # MSM8974, APQ8074 and APQ8084
> > +          - qcom,bam-v1.4.0
> > +          # MSM8916, SDM630
> > +          - qcom,bam-v1.7.0
> > +      - items:
> > +          - enum:
> > +              # SDM845, SM6115, SM8150, SM8250 and QCM2290
> > +              - qcom,bam-v1.7.4
> > +          - const: qcom,bam-v1.7.0
> >
> >    clocks:
> >      maxItems: 1
> > --
> > 2.38.1
>
> Bjorn has applied the dts patches from this series to his tree.
> As suggested by him, can you please pick patches [PATCH 1/11] and
> [PATCH 2/11] from this series via the 'dmaengine' tree.
>
> Seems some Cc fields got messed up while sending the patchset, so
> Cc'ing the dmaengine list again.

Ping. Any updates on these two patches?

Thanks.
Vinod Koul June 8, 2023, 12:32 p.m. UTC | #2 
On 29-05-23, 11:43, Bhupesh Sharma wrote:
> Hi Vinod,
> 
> > On Sat, 27 May 2023 at 00:52, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
> >
> > Add new compatible for BAM DMA engine version v1.7.4 which is
> > found on Qualcomm SM6115 and QCM2290 SoCs. Since its very similar
> > to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme
> > accordingly.
> >
> > While at it, also update qcom,bam-dma bindings to add comments
> > which describe the BAM DMA versions used in SM8150 and SM8250 SoCs.
> > This provides an easy reference for identifying the actual BAM DMA
> > version available on Qualcomm SoCs.
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> > Tested-by: Anders Roxell <anders.roxell@linaro.org>
> > Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
> >  .../devicetree/bindings/dma/qcom,bam-dma.yaml | 20 ++++++++++++-------
> >  1 file changed, 13 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> > index f1ddcf672261..c663b6102f50 100644
> > --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> > @@ -15,13 +15,19 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    enum:
> > -        # APQ8064, IPQ8064 and MSM8960
> > -      - qcom,bam-v1.3.0
> > -        # MSM8974, APQ8074 and APQ8084
> > -      - qcom,bam-v1.4.0
> > -        # MSM8916 and SDM845
> > -      - qcom,bam-v1.7.0
> > +    oneOf:
> > +      - enum:
> > +          # APQ8064, IPQ8064 and MSM8960
> > +          - qcom,bam-v1.3.0
> > +          # MSM8974, APQ8074 and APQ8084
> > +          - qcom,bam-v1.4.0
> > +          # MSM8916, SDM630
> > +          - qcom,bam-v1.7.0
> > +      - items:
> > +          - enum:
> > +              # SDM845, SM6115, SM8150, SM8250 and QCM2290
> > +              - qcom,bam-v1.7.4
> > +          - const: qcom,bam-v1.7.0
> >
> >    clocks:
> >      maxItems: 1
> > --
> > 2.38.1
> 
> Bjorn has applied the dts patches from this series to his tree.
> As suggested by him, can you please pick patches [PATCH 1/11] and
> [PATCH 2/11] from this series via the 'dmaengine' tree.

I dont have this series in my inbox or dmaengine pw

> Seems some Cc fields got messed up while sending the patchset, so
> Cc'ing the dmaengine list again.

not just list but mine too..

Please rebase and resend
Bhupesh Sharma June 30, 2023, 8:30 a.m. UTC | #3 
On 6/8/23 6:02 PM, Vinod Koul wrote:
> On 29-05-23, 11:43, Bhupesh Sharma wrote:
>> Hi Vinod,
>>
>>> On Sat, 27 May 2023 at 00:52, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
>>>
>>> Add new compatible for BAM DMA engine version v1.7.4 which is
>>> found on Qualcomm SM6115 and QCM2290 SoCs. Since its very similar
>>> to v1.7.0 used on SM8150 like SoCs, mark the comptible scheme
>>> accordingly.
>>>
>>> While at it, also update qcom,bam-dma bindings to add comments
>>> which describe the BAM DMA versions used in SM8150 and SM8250 SoCs.
>>> This provides an easy reference for identifying the actual BAM DMA
>>> version available on Qualcomm SoCs.
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> Tested-by: Anders Roxell <anders.roxell@linaro.org>
>>> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
>>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>>> ---
>>>   .../devicetree/bindings/dma/qcom,bam-dma.yaml | 20 ++++++++++++-------
>>>   1 file changed, 13 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>>> index f1ddcf672261..c663b6102f50 100644
>>> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>>> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>>> @@ -15,13 +15,19 @@ allOf:
>>>
>>>   properties:
>>>     compatible:
>>> -    enum:
>>> -        # APQ8064, IPQ8064 and MSM8960
>>> -      - qcom,bam-v1.3.0
>>> -        # MSM8974, APQ8074 and APQ8084
>>> -      - qcom,bam-v1.4.0
>>> -        # MSM8916 and SDM845
>>> -      - qcom,bam-v1.7.0
>>> +    oneOf:
>>> +      - enum:
>>> +          # APQ8064, IPQ8064 and MSM8960
>>> +          - qcom,bam-v1.3.0
>>> +          # MSM8974, APQ8074 and APQ8084
>>> +          - qcom,bam-v1.4.0
>>> +          # MSM8916, SDM630
>>> +          - qcom,bam-v1.7.0
>>> +      - items:
>>> +          - enum:
>>> +              # SDM845, SM6115, SM8150, SM8250 and QCM2290
>>> +              - qcom,bam-v1.7.4
>>> +          - const: qcom,bam-v1.7.0
>>>
>>>     clocks:
>>>       maxItems: 1
>>> --
>>> 2.38.1
>>
>> Bjorn has applied the dts patches from this series to his tree.
>> As suggested by him, can you please pick patches [PATCH 1/11] and
>> [PATCH 2/11] from this series via the 'dmaengine' tree.
> 
> I dont have this series in my inbox or dmaengine pw
> 
>> Seems some Cc fields got messed up while sending the patchset, so
>> Cc'ing the dmaengine list again.
> 
> not just list but mine too..
> 
> Please rebase and resend

Sure, I have sent a v9, which can be seen here: 
<https://lore.kernel.org/linux-arm-msm/20230630082230.2264698-1-bhupesh.sharma@linaro.org/>
Please help review.

Thanks,
Bhupesh
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
index f1ddcf672261..c663b6102f50 100644
--- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
@@ -15,13 +15,19 @@  allOf:
 
 properties:
   compatible:
-    enum:
-        # APQ8064, IPQ8064 and MSM8960
-      - qcom,bam-v1.3.0
-        # MSM8974, APQ8074 and APQ8084
-      - qcom,bam-v1.4.0
-        # MSM8916 and SDM845
-      - qcom,bam-v1.7.0
+    oneOf:
+      - enum:
+          # APQ8064, IPQ8064 and MSM8960
+          - qcom,bam-v1.3.0
+          # MSM8974, APQ8074 and APQ8084
+          - qcom,bam-v1.4.0
+          # MSM8916, SDM630
+          - qcom,bam-v1.7.0
+      - items:
+          - enum:
+              # SDM845, SM6115, SM8150, SM8250 and QCM2290
+              - qcom,bam-v1.7.4
+          - const: qcom,bam-v1.7.0
 
   clocks:
     maxItems: 1