| Message ID | 20230405060906.143058-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | add214009d0632bf3f28158f81e4d202d8c9aa0e |
| Headers | show |
| Series | [1/5] arm64: dts: qcom: sc8280xp: label the Soundwire nodes | expand |
On 5.04.2023 08:09, Krzysztof Kozlowski wrote: > Use labels, instead of comments, for Soundwire controllers. Naming them > is useful, because they are specialized and have also naming in > datasheet/programming guide. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index ce4b7d0a09ab..1dd000748f9e 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -2153,13 +2153,13 @@ wsa2macro: codec@31e0000 { > #sound-dai-cells = <1>; > }; > > - /* WSA2 */ > swr4: soundwire-controller@31f0000 { > compatible = "qcom,soundwire-v1.7.0"; > reg = <0 0x031f0000 0 0x2000>; > interrupts = <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&wsa2macro>; > clock-names = "iface"; > + label = "WSA2"; > > qcom,din-ports = <2>; > qcom,dout-ports = <6>; > @@ -2268,13 +2268,13 @@ wsamacro: codec@3240000 { > #sound-dai-cells = <1>; > }; > > - /* WSA */ > swr0: soundwire-controller@3250000 { > compatible = "qcom,soundwire-v1.7.0"; > reg = <0 0x03250000 0 0x2000>; > interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&wsamacro>; > clock-names = "iface"; > + label = "WSA"; > > qcom,din-ports = <2>; > qcom,dout-ports = <6>;
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index ce4b7d0a09ab..1dd000748f9e 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -2153,13 +2153,13 @@ wsa2macro: codec@31e0000 { #sound-dai-cells = <1>; }; - /* WSA2 */ swr4: soundwire-controller@31f0000 { compatible = "qcom,soundwire-v1.7.0"; reg = <0 0x031f0000 0 0x2000>; interrupts = <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>; clocks = <&wsa2macro>; clock-names = "iface"; + label = "WSA2"; qcom,din-ports = <2>; qcom,dout-ports = <6>; @@ -2268,13 +2268,13 @@ wsamacro: codec@3240000 { #sound-dai-cells = <1>; }; - /* WSA */ swr0: soundwire-controller@3250000 { compatible = "qcom,soundwire-v1.7.0"; reg = <0 0x03250000 0 0x2000>; interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>; clocks = <&wsamacro>; clock-names = "iface"; + label = "WSA"; qcom,din-ports = <2>; qcom,dout-ports = <6>;
Use labels, instead of comments, for Soundwire controllers. Naming them is useful, because they are specialized and have also naming in datasheet/programming guide. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)