| Message ID | 20230329-dt-cpu-header-cleanups-v1-8-581e2605fe47@kernel.org |
|---|---|
| State | Accepted |
| Commit | a0418108d7e1299b3fb696de96981c3bc05a040f |
| Headers | show |
| Series | DT header disentangling, part 1 | expand |
On Wed, 29 Mar 2023 08:52:05 PDT (-0700), robh@kernel.org wrote: > Removing the include of cpu.h from of_device.h (included by > of_platform.h) causes an error in setup.c: > > arch/riscv/kernel/setup.c:313:22: error: arithmetic on a pointer to an incomplete type 'typeof(struct cpu)' (aka 'struct cpu') > > The of_platform.h header is not necessary either, so it can be dropped. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Please ack and I will take the series via the DT tree. > --- > arch/riscv/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > index 376d2827e736..dcfa4b6fa4b1 100644 > --- a/arch/riscv/kernel/setup.c > +++ b/arch/riscv/kernel/setup.c > @@ -8,6 +8,7 @@ > * Nick Kossifidis <mick@ics.forth.gr> > */ > > +#include <linux/cpu.h> > #include <linux/init.h> > #include <linux/mm.h> > #include <linux/memblock.h> > @@ -15,7 +16,6 @@ > #include <linux/console.h> > #include <linux/screen_info.h> > #include <linux/of_fdt.h> > -#include <linux/of_platform.h> > #include <linux/sched/task.h> > #include <linux/smp.h> > #include <linux/efi.h> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c index 376d2827e736..dcfa4b6fa4b1 100644 --- a/arch/riscv/kernel/setup.c +++ b/arch/riscv/kernel/setup.c @@ -8,6 +8,7 @@ * Nick Kossifidis <mick@ics.forth.gr> */ +#include <linux/cpu.h> #include <linux/init.h> #include <linux/mm.h> #include <linux/memblock.h> @@ -15,7 +16,6 @@ #include <linux/console.h> #include <linux/screen_info.h> #include <linux/of_fdt.h> -#include <linux/of_platform.h> #include <linux/sched/task.h> #include <linux/smp.h> #include <linux/efi.h>
Removing the include of cpu.h from of_device.h (included by of_platform.h) causes an error in setup.c: arch/riscv/kernel/setup.c:313:22: error: arithmetic on a pointer to an incomplete type 'typeof(struct cpu)' (aka 'struct cpu') The of_platform.h header is not necessary either, so it can be dropped. Signed-off-by: Rob Herring <robh@kernel.org> --- Please ack and I will take the series via the DT tree. --- arch/riscv/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)