From patchwork Mon Feb 6 19:37:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 651367 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB69C636D3 for ; Mon, 6 Feb 2023 19:38:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbjBFTiL (ORCPT ); Mon, 6 Feb 2023 14:38:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjBFTiK (ORCPT ); Mon, 6 Feb 2023 14:38:10 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B11D913D69; Mon, 6 Feb 2023 11:38:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EAB060FFD; Mon, 6 Feb 2023 19:38:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BB14C433D2; Mon, 6 Feb 2023 19:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675712288; bh=bG9YLGEhBjFz6zXj4NzQ4x+3+ALPum4dN/AWK0u8uEg=; h=From:To:Cc:Subject:Date:From; b=FYMLuiiXykEsb6hGNWJG9d5xTC+yMuyR45nOkmcZ/Hib+HGgsTHqrhMPDSYKnjg0f osNS8re5r97xLusDW5Rhu6Ri95Gti5Av+ba2JQ+bR4qt4EjAg1GOF+L7CjqZ8lnnkf cjleuAKlvdGXWP/sUk3TFnfbze7mKEMczoWI9cl7BH1oEa+v5eKWpHizHDFGfgA56X nwwHmPwoUtIPdceMrS5EzNkBF4kaDtJS6dPcRneJIOkcyuttAT6Jn6iDzIpts0/T/L 5Vy0IHurU6VdArKoFoAoJ3MblCIcZGItnT+xGL1Ax4QsuNDh5+mrZODiBae4z61BN0 yit3H4d2MCq5Q== From: Arnd Bergmann To: Andy Gross , Bjorn Andersson , Neil Armstrong Cc: Arnd Bergmann , Konrad Dybcio , Krzysztof Kozlowski , Manivannan Sadhasivam , AngeloGioacchino Del Regno , Souradeep Chowdhury , YueHaibing , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: qcom: pmic_glink: add CONFIG_NET/CONFIG_OF dependencies Date: Mon, 6 Feb 2023 20:37:58 +0100 Message-Id: <20230206193804.191343-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Arnd Bergmann QMI is a network protocol, so anything using requires CONFIG_NET to be enabled as well: WARNING: unmet direct dependencies detected for QCOM_QMI_HELPERS Depends on [n]: NET [=n] Selected by [m]: - QCOM_PDR_HELPERS [=m] arm-linux-gnueabi-ld: drivers/soc/qcom/qmi_interface.o: in function `qmi_send_new_lookup': qmi_interface.c:(.text+0xf0): undefined reference to `kernel_sendmsg' Add the dependency to both QCOM_PDR_HELPERS and QCOM_PMIC_GLINK to make it clearly what the dependency is when another PDR user is added. pmic_glink also needs CONFIG_OF: drivers/soc/qcom/pmic_glink_altmode.c: In function 'pmic_glink_altmode_probe': drivers/soc/qcom/pmic_glink_altmode.c:418:33: error: 'struct drm_bridge' has no member named 'of_node' Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") Signed-off-by: Arnd Bergmann --- drivers/soc/qcom/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index 348fde2a8aae..a8f283086a21 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -91,12 +91,15 @@ config QCOM_OCMEM config QCOM_PDR_HELPERS tristate select QCOM_QMI_HELPERS + depends on NET config QCOM_PMIC_GLINK tristate "Qualcomm PMIC GLINK driver" depends on RPMSG depends on TYPEC depends on DRM + depends on NET + depends on OF select AUXILIARY_BUS select QCOM_PDR_HELPERS help