diff mbox series

[2/5] dt-bindings: leds: pm8058: convert from txt to YAML format

Message ID 20221201202144.448694-3-dmitry.baryshkov@linaro.org
State New
Headers show
Series dt-bindings: add missing subdevices to qcom-pm8xxx schema | expand

Commit Message

Dmitry Baryshkov Dec. 1, 2022, 8:21 p.m. UTC 
Convert the bindings for the leds subdevice of Qualcomm PM8058 PMIC
from text to YAML format.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../devicetree/bindings/leds/leds-pm8058.txt  | 67 ---------------
 .../devicetree/bindings/leds/leds-pm8058.yaml | 81 +++++++++++++++++++
 2 files changed, 81 insertions(+), 67 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/leds/leds-pm8058.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-pm8058.yaml

Comments

Dmitry Baryshkov Dec. 4, 2022, 6:12 a.m. UTC | #1 
On 02/12/2022 10:30, Krzysztof Kozlowski wrote:
> On 01/12/2022 21:21, Dmitry Baryshkov wrote:
>> Convert the bindings for the leds subdevice of Qualcomm PM8058 PMIC
>> from text to YAML format.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   .../devicetree/bindings/leds/leds-pm8058.txt  | 67 ---------------
>>   .../devicetree/bindings/leds/leds-pm8058.yaml | 81 +++++++++++++++++++
>>   2 files changed, 81 insertions(+), 67 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/leds/leds-pm8058.txt
>>   create mode 100644 Documentation/devicetree/bindings/leds/leds-pm8058.yaml
>>
> 
> This is already done:
> 
> https://lore.kernel.org/all/20221201131505.42292-1-krzysztof.kozlowski@linaro.org/

I'll post next version, rebased on top of your patch

> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/leds/leds-pm8058.txt b/Documentation/devicetree/bindings/leds/leds-pm8058.txt
deleted file mode 100644
index 89584c49aab2..000000000000
--- a/Documentation/devicetree/bindings/leds/leds-pm8058.txt
+++ /dev/null
@@ -1,67 +0,0 @@ 
-Qualcomm PM8058 LED driver
-
-The Qualcomm PM8058 is a multi-functional device which contains
-an LED driver block for up to six LEDs: three normal LEDs, two
-"flash" LEDs and one "keypad backlight" LED. The names are
-quoted because sometimes these LED drivers are used for wildly
-different things than flash or keypad backlight: their names
-are more of a suggestion than a hard-wired usecase.
-
-Hardware-wise the different LEDs support slightly different
-output currents. The "flash" LEDs do not need to charge nor
-do they support external triggers. They are just powerful LED
-drivers.
-
-The LEDs appear as children to the PM8058 device, with the
-proper compatible string. For the PM8058 bindings see:
-mfd/qcom-pm8xxx.txt.
-
-Each LED is represented as a sub-node of the syscon device. Each
-node's name represents the name of the corresponding LED.
-
-LED sub-node properties:
-
-Required properties:
-- compatible: one of
-  "qcom,pm8058-led" (for the normal LEDs at 0x131, 0x132 and 0x133)
-  "qcom,pm8058-keypad-led" (for the "keypad" LED at 0x48)
-  "qcom,pm8058-flash-led" (for the "flash" LEDs at 0x49 and 0xFB)
-
-Optional properties:
-- label: see Documentation/devicetree/bindings/leds/common.txt
-- default-state: see Documentation/devicetree/bindings/leds/common.txt
-- linux,default-trigger: see Documentation/devicetree/bindings/leds/common.txt
-
-Example:
-
-qcom,ssbi@500000 {
-	pmicintc: pmic@0 {
-		compatible = "qcom,pm8058";
-		led@48 {
-			compatible = "qcom,pm8058-keypad-led";
-			reg = <0x48>;
-			label = "pm8050:white:keypad";
-			default-state = "off";
-		};
-		led@131 {
-			compatible = "qcom,pm8058-led";
-			reg = <0x131>;
-			label = "pm8058:red";
-			default-state = "off";
-		};
-		led@132 {
-			compatible = "qcom,pm8058-led";
-			reg = <0x132>;
-			label = "pm8058:yellow";
-			default-state = "off";
-			linux,default-trigger = "mmc0";
-		};
-		led@133 {
-			compatible = "qcom,pm8058-led";
-			reg = <0x133>;
-			label = "pm8058:green";
-			default-state = "on";
-			linux,default-trigger = "heartbeat";
-		};
-	};
-};
diff --git a/Documentation/devicetree/bindings/leds/leds-pm8058.yaml b/Documentation/devicetree/bindings/leds/leds-pm8058.yaml
new file mode 100644
index 000000000000..a73bffb36808
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-pm8058.yaml
@@ -0,0 +1,81 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/leds-pm8058.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PM8058 LED driver
+
+maintainers:
+  - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
+
+description: |
+  The Qualcomm PM8058 is a multi-functional device which contains
+  an LED driver block for up to six LEDs: three normal LEDs, two
+  "flash" LEDs and one "keypad backlight" LED. The names are
+  quoted because sometimes these LED drivers are used for wildly
+  different things than flash or keypad backlight: their names
+  are more of a suggestion than a hard-wired usecase.
+
+  Hardware-wise the different LEDs support slightly different
+  output currents. The "flash" LEDs do not need to charge nor
+  do they support external triggers. They are just powerful LED
+  drivers.
+
+  The LEDs appear as children to the PM8058 device, with the
+  proper compatible string. For the PM8058 bindings see:
+  mfd/qcom-pm8xxx.txt.
+
+  Each LED is represented as a sub-node of the syscon device. Each
+  node's name represents the name of the corresponding LED.
+
+$ref: common.yaml#
+
+properties:
+  compatible:
+    enum:
+      - qcom,pm8058-led
+      - qcom,pm8058-keypad-led
+      - qcom,pm8058-flash-led
+
+  reg:
+    description: resource address
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/leds/common.h>
+    pmic {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        led@48 {
+            compatible = "qcom,pm8058-keypad-led";
+            reg = <0x48>;
+            label = "pm8050:white:keypad";
+            default-state = "off";
+        };
+        led@131 {
+            compatible = "qcom,pm8058-led";
+            reg = <0x131>;
+            label = "pm8058:red";
+            default-state = "off";
+        };
+        led@132 {
+            compatible = "qcom,pm8058-led";
+            reg = <0x132>;
+            label = "pm8058:yellow";
+            default-state = "off";
+            linux,default-trigger = "mmc0";
+        };
+        led@133 {
+            compatible = "qcom,pm8058-led";
+            reg = <0x133>;
+            label = "pm8058:green";
+            default-state = "on";
+            linux,default-trigger = "heartbeat";
+        };
+    };
+...