| Message ID | 20221127181835.806410-1-luca@z3ntu.xyz |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: arm: qcom: Document oneplus,bacon device | expand |
On 27/11/2022 19:18, Luca Weiss wrote: > From: Julian Goldsmith <julian@juliangoldsmith.com> > > OnePlus One is a smartphone launched in 2014 and is based on the > Snapdragon 801 SoC (-AC variant). > Thank you for your patch. There is something to discuss/improve. > + > +&blsp1_uart2 { > + status = "okay"; > +}; > + > +&gcc { > + compatible = "qcom,gcc-msm8974pro-ac"; > +}; > + > +&otg { > + phys = <&usb_hs1_phy>; > + phy-select = <&tcsr 0xb000 0>; > + extcon = <&smbb>, <&usb_id>; > + vbus-supply = <&chg_otg>; > + > + hnp-disable; > + srp-disable; > + adp-disable; > + > + status = "okay"; > + > + ulpi { > + phy@a { > + status = "okay"; Override by label (usb_hs1_phy). If the labels are named similarly, e.g. usb_oth and usb_hs1_phy, then they will appear next to each other during override/extend. Best regards, Krzysztof
On 27/11/2022 22:25, Dmitry Baryshkov wrote: > On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@z3ntu.xyz> wrote: >> >> Document the OnePlus One ("bacon") which is a smartphone based on the >> Snapdragon 801 SoC. >> >> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. > > The patch itself is good. However it raised a broader question for me. > Up to now all msm8974pro devices use qcom,msm8974 as a top-level > compatibility string. Should it be changed to use pro-specific one > (e.g. qcom,msm8974pro)? Yes, makes sense. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 463509f0f23a..3d2cc8ae34d8 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -167,6 +167,7 @@ properties: - enum: - fairphone,fp2 - lge,hammerhead + - oneplus,bacon - samsung,klte - sony,xperia-amami - sony,xperia-castor @@ -896,6 +897,7 @@ allOf: - qcom,apq8026 - qcom,apq8094 - qcom,apq8096 + - qcom,msm8974 - qcom,msm8992 - qcom,msm8994 - qcom,msm8996
Document the OnePlus One ("bacon") which is a smartphone based on the Snapdragon 801 SoC. Also allow msm8974 devices to use qcom,msm-id and qcom,board-id. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ 1 file changed, 2 insertions(+)