| Message ID | 20221110133512.478831-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 817e981736d27731adb9d7ca11eb8069d1ee569d |
| Headers | show |
| Series | [v2,1/2] ASoC: dt-bindings: qcom,wsa883x: Use correct SD_N polarity | expand |
On 10/11/2022 13:35, Krzysztof Kozlowski wrote: > Use correct polarity in example and powerdown-gpios description. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > > Changes since v1: > 1. New patch. > --- > Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml > index 6113f65f2990..99f9c10bbc83 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml > @@ -23,7 +23,7 @@ properties: > maxItems: 1 > > powerdown-gpios: > - description: GPIO spec for Powerdown/Shutdown line to use > + description: GPIO spec for Powerdown/Shutdown line to use (pin SD_N) > maxItems: 1 > > vdd-supply: > @@ -47,6 +47,8 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/gpio/gpio.h> > + > soundwire-controller@3250000 { > #address-cells = <2>; > #size-cells = <0>; > @@ -55,7 +57,7 @@ examples: > speaker@0,1 { > compatible = "sdw10217020200"; > reg = <0 1>; > - powerdown-gpios = <&tlmm 1 0>; > + powerdown-gpios = <&tlmm 1 GPIO_ACTIVE_LOW>; > vdd-supply = <&vreg_s10b_1p8>; > #thermal-sensor-cells = <0>; > #sound-dai-cells = <0>; > @@ -64,7 +66,7 @@ examples: > speaker@0,2 { > compatible = "sdw10217020200"; > reg = <0 2>; > - powerdown-gpios = <&tlmm 89 0>; > + powerdown-gpios = <&tlmm 89 GPIO_ACTIVE_LOW>; > vdd-supply = <&vreg_s10b_1p8>; > #thermal-sensor-cells = <0>; > #sound-dai-cells = <0>;
diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml index 6113f65f2990..99f9c10bbc83 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml @@ -23,7 +23,7 @@ properties: maxItems: 1 powerdown-gpios: - description: GPIO spec for Powerdown/Shutdown line to use + description: GPIO spec for Powerdown/Shutdown line to use (pin SD_N) maxItems: 1 vdd-supply: @@ -47,6 +47,8 @@ additionalProperties: false examples: - | + #include <dt-bindings/gpio/gpio.h> + soundwire-controller@3250000 { #address-cells = <2>; #size-cells = <0>; @@ -55,7 +57,7 @@ examples: speaker@0,1 { compatible = "sdw10217020200"; reg = <0 1>; - powerdown-gpios = <&tlmm 1 0>; + powerdown-gpios = <&tlmm 1 GPIO_ACTIVE_LOW>; vdd-supply = <&vreg_s10b_1p8>; #thermal-sensor-cells = <0>; #sound-dai-cells = <0>; @@ -64,7 +66,7 @@ examples: speaker@0,2 { compatible = "sdw10217020200"; reg = <0 2>; - powerdown-gpios = <&tlmm 89 0>; + powerdown-gpios = <&tlmm 89 GPIO_ACTIVE_LOW>; vdd-supply = <&vreg_s10b_1p8>; #thermal-sensor-cells = <0>; #sound-dai-cells = <0>;
Use correct polarity in example and powerdown-gpios description. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. New patch. --- Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)