From patchwork Wed Oct 26 20:03:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 618841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7B2C433FE for ; Wed, 26 Oct 2022 20:04:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235100AbiJZUEg (ORCPT ); Wed, 26 Oct 2022 16:04:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233779AbiJZUES (ORCPT ); Wed, 26 Oct 2022 16:04:18 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38CA811DAA7 for ; Wed, 26 Oct 2022 13:04:17 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id z17so8874358qkj.8 for ; Wed, 26 Oct 2022 13:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pco6XP3zzlzKkHJ/8k4uES/pSob9fk0mMY+1kXvS6TY=; b=JwHHwywsMb9iQbsPockEFVNMIDxExD2U8RnZfFgB5sQQbVmOePQhpU9USsB3t6B4/G zkJ3CUAaXNGbx7oJwoAUfWQV7Un5b1XTA3KE6NIZKMy31msSxtkbl/Oz2hbvWn6DSPhg OKS8lKgs2mmDQydn+5wXf+POR5Xxmt7cRj9uhLrvE5RZ8BDRn/eB4VnauOM1i+XixRWS flCvJGUQAQTvC6QWgTxiQ4gBzNzqKTyN74UeL+tpHpOUb5NRuhTPg/vPh/8rpPEGY0Ha TKnai6UGH+K8DOJE2r7vPETcoOjka7kmBg6S5PlWlOAlC5/x8JoaDg3VTYS5mDtywi2I AVuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pco6XP3zzlzKkHJ/8k4uES/pSob9fk0mMY+1kXvS6TY=; b=5ZXyJGglYldC+RP49BRdoCeZUnxCe+CW51+blBUrpF4ZFixcuMyerVeHIuYVN3NZQA cxXM8VRujdoRrsgkvxcWjTW2L/qFqlZVOOiSACO8oST/ddMXTpRivHXzlCUGHctDhk6l CedZX1OV16F/+HOZ681LlwmNSuk9PfchlDwXGT9zyeIcQFHGlCD1w4FASO/UJVVdiITf kfFhwgGUY7L1naORI34uuuRMfmnrI8WUDP+gguNJUQAV4KpWdUbML6lbIpokJt61pUo/ +iquW2N+aIAb7STANIfm9iG92L3PqI+OmH4JzdRnZdGPgIJCKErAN9HsQ6R3YHmDT2C1 n6TA== X-Gm-Message-State: ACrzQf10gVgq9O2pm1N8dnVkquGMjSRUgjU/OnaqaR/ZgddRGIo49+MW AGxC/Ad25GAFo31ztbaF3Tk+kQM/evu8uw== X-Google-Smtp-Source: AMsMyM6IbRSXEB6Fmc2djOZ0B0rJEV/aVUdSza0WpoDlkxwlChcr7aww0a6H3dSgeptN56TRdQMPyg== X-Received: by 2002:a05:620a:13b6:b0:6ee:cf79:bfa1 with SMTP id m22-20020a05620a13b600b006eecf79bfa1mr32285840qki.15.1666814645256; Wed, 26 Oct 2022 13:04:05 -0700 (PDT) Received: from krzk-bin.. ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id de30-20020a05620a371e00b006e99290e83fsm2942089qkb.107.2022.10.26.13.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 13:04:04 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Dmitry Baryshkov Subject: [PATCH 2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards Date: Wed, 26 Oct 2022 16:03:55 -0400 Message-Id: <20221026200357.391635-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221026200357.391635-1-krzysztof.kozlowski@linaro.org> References: <20221026200357.391635-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org SDHCI on SM8450 HDK also has problems with SDR104/SDR50: mmc0: card never left busy state mmc0: error -110 whilst initialising SD card so I think it is safe to assume this issue affects all SM8450 boards. Move the quirk disallowing these modes to the SoC DTSI, to spare people working on other boards the misery of debugging this issue. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts | 2 -- arch/arm64/boot/dts/qcom/sm8450.dtsi | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts index 718c690af8ad..ae8ba297b0b6 100644 --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts @@ -556,8 +556,6 @@ &sdhc_2 { pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>; vmmc-supply = <&pm8350c_l9>; vqmmc-supply = <&pm8350c_l6>; - /* Forbid SDR104/SDR50 - broken hw! */ - sdhci-caps-mask = <0x3 0x0>; no-sdio; no-mmc; status = "okay"; diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 1df5c964c6f7..6800e05a549d 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -3412,6 +3412,9 @@ sdhc_2: sdhci@8804000 { bus-width = <4>; dma-coherent; + /* Forbid SDR104/SDR50 - broken hw! */ + sdhci-caps-mask = <0x3 0x0>; + status = "disabled"; sdhc2_opp_table: opp-table {