From patchwork Tue Oct 18 23:03:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 616105 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA18C43217 for ; Tue, 18 Oct 2022 23:04:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229922AbiJRXEI (ORCPT ); Tue, 18 Oct 2022 19:04:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbiJRXEC (ORCPT ); Tue, 18 Oct 2022 19:04:02 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9F5ABCBBF for ; Tue, 18 Oct 2022 16:03:58 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id x13so9678792qkg.11 for ; Tue, 18 Oct 2022 16:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rDE2/66UDa0hDLDqGdcC3HGG8N6jl6s2qDtARs18Pls=; b=yXgA+qYbSAVhoX3vmAKigDAkRu2K24kIHV9Q3YO/fSgj7Dfow/WN4Vq0mpghp9/cF0 zeTrol5i50aU49KgS+3toEMFfReqARWJx5Dm6eMAqhTYgxnwzfGujFd8AH26MqPbKxBz p9K/S+E0rNkFyhW4EadPxbyN6vVw5FnImBQay9Wo15XyDYPlU949LJ52rIemjxMoww0v dtarmNaaf0IZE3qBkqgMwAei49Z0ZLnaLpVJbHSbggYMI+JJlOEPObwqd7Syb2DpfOxy r56qOpkjFGAS6c90LZUf1LxVW0Z6SzzVnBTXmpCEn0zD50/pOKzLt4LCC/y6jJry64i0 jRNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rDE2/66UDa0hDLDqGdcC3HGG8N6jl6s2qDtARs18Pls=; b=KlalVdgJg9dDduzC9DoIojQlOfo/nOlYgenZEc8VYem1KexIOt4Vw7IRceq4aKi8de z6wAiQACDWqxG6j5kZm3CRH0gg+SzPkuP0C81M/S/ZZrCLuEOtozzKGlIbkiLHUu6bGW uHp4HCD09ybLZJzHJY0wRmWVWUdA10ohCr1aeOU2yi13UW0iUULzDs0+QmxiU3rtr699 UVV9RJFZ8Nipi58Pj0FK+8hhB0XVf6gxsNlkoWJ1MAU6GPugGXO23lcFWjvz+Kp9jLQ4 YuaPO92Z0LaeFREsxyKJsceWGOchiqnTa0pJqV+RnqABj/fGUi5RE9H2Z0ZP/9iSKsNB pvww== X-Gm-Message-State: ACrzQf2SN97qAU6fsl1ud8Ja1MkZ9XWWV+uAPJJg6s74snP46PJObAlR rGkxPKm6C17K789qxCT4/NzHeA== X-Google-Smtp-Source: AMsMyM7cVGVccXv1BO6ML81Bf1aWBaWaYXay5h0optGTArAokntZrhqF1SXoF01onu/mGa/hmyLO+A== X-Received: by 2002:a05:620a:2b85:b0:6ee:cc4a:de6 with SMTP id dz5-20020a05620a2b8500b006eecc4a0de6mr3536822qkb.458.1666134237725; Tue, 18 Oct 2022 16:03:57 -0700 (PDT) Received: from krzk-bin.MSRM (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id 134-20020a370a8c000000b006cbcdc6efedsm3279010qkk.41.2022.10.18.16.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 16:03:57 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Richard Acayan Subject: [PATCH v2 2/5] dmaengine: qcom: gpi: Document preferred SM6350 binding Date: Tue, 18 Oct 2022 19:03:49 -0400 Message-Id: <20221018230352.1238479-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221018230352.1238479-1-krzysztof.kozlowski@linaro.org> References: <20221018230352.1238479-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Devices with ee offset of 0x10000 should rather bind with SM6350 compatible, so the list will not unnecessarily grow for compatible devices. Signed-off-by: Krzysztof Kozlowski Acked-by: Richard Acayan --- drivers/dma/qcom/gpi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c index f8e19e6e6117..061add832295 100644 --- a/drivers/dma/qcom/gpi.c +++ b/drivers/dma/qcom/gpi.c @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) } static const struct of_device_id gpi_of_match[] = { - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, /* - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as - * fallback and not need their own entries here. + * Do not grow the list for compatible devices. Instead use + * qcom,sdm845-gpi-dma (for ee_offset = 0x0) or qcom,sm6350-gpi-dma + * (for ee_offset = 0x10000). */ + { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },