| Message ID | 20220922195651.345369-9-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | pinctrl/arm64: qcom: continued - fix Qualcomm LPASS pinctrl schema warnings | expand |
On 23/09/2022 11:31, Krzysztof Kozlowski wrote: > On Thu, 22 Sep 2022 21:56:47 +0200, Krzysztof Kozlowski wrote: >> The existing SC7280 LPASS pin controller nodes use bias-bus-hold and >> input-enable, so allow them. Squash also blank lines for readability. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1681325 > > > pinctrl@33c0000: 'dmic01-active-pins', 'dmic01-sleep-pins', 'rx_swr-active-pins', 'tx_swr-active-pins', 'tx_swr-sleep-pins', 'wsa-swr-active-pins', 'wsa-swr-sleep-pins' do not match any of the regexes: '-state$', 'pinctrl-[0-9]+' This is being fixed in next DTS patches. I'll reorganize them if there is going to be a resubmit. Best regards, Krzysztof
On Thu, 22 Sep 2022 21:56:47 +0200, Krzysztof Kozlowski wrote: > The existing SC7280 LPASS pin controller nodes use bias-bus-hold and > input-enable, so allow them. Squash also blank lines for readability. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml index 9640d1110fdd..2427da7c20d3 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml @@ -96,13 +96,11 @@ $defs: 3: Reserved (No adjustments) bias-pull-down: true - bias-pull-up: true - + bias-bus-hold: true bias-disable: true - + input-enable: true output-high: true - output-low: true required:
The existing SC7280 LPASS pin controller nodes use bias-bus-hold and input-enable, so allow them. Squash also blank lines for readability. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)