| Message ID | 20220830175207.13315-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/3] slimbus: qcom-ngd: use correct error in message of pdr_add_lookup() failure | expand |
On 30/08/2022 18:52, Krzysztof Kozlowski wrote: > Use correct error code, instead of previous 'ret' value, when printing > error from pdr_add_lookup() failure. > > Cc: <stable@vger.kernel.org> > Fixes: e1ae85e1830e ("slimbus: qcom-ngd-ctrl: add Protection Domain Restart Support") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > Applied all thanks, --srini > Changes since v1: > 1. Correct typo > 2. Return 'ret' instead of again PTR_ERR > --- > drivers/slimbus/qcom-ngd-ctrl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c > index 0aa8408464ad..f4f330b9fa72 100644 > --- a/drivers/slimbus/qcom-ngd-ctrl.c > +++ b/drivers/slimbus/qcom-ngd-ctrl.c > @@ -1581,8 +1581,9 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) > > pds = pdr_add_lookup(ctrl->pdr, "avs/audio", "msm/adsp/audio_pd"); > if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) { > + ret = PTR_ERR(pds); > dev_err(dev, "pdr add lookup failed: %d\n", ret); > - return PTR_ERR(pds); > + return ret; > } > > platform_driver_register(&qcom_slim_ngd_driver);
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 0aa8408464ad..f4f330b9fa72 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1581,8 +1581,9 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) pds = pdr_add_lookup(ctrl->pdr, "avs/audio", "msm/adsp/audio_pd"); if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) { + ret = PTR_ERR(pds); dev_err(dev, "pdr add lookup failed: %d\n", ret); - return PTR_ERR(pds); + return ret; } platform_driver_register(&qcom_slim_ngd_driver);
Use correct error code, instead of previous 'ret' value, when printing error from pdr_add_lookup() failure. Cc: <stable@vger.kernel.org> Fixes: e1ae85e1830e ("slimbus: qcom-ngd-ctrl: add Protection Domain Restart Support") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. Correct typo 2. Return 'ret' instead of again PTR_ERR --- drivers/slimbus/qcom-ngd-ctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)