| Message ID | 20220710084133.30976-8-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: msm/dp: cleanup Qualcomm DP and eDP bidndings | expand |
On 10/07/2022 10:41, Dmitry Baryshkov wrote: > The commit fa384dd8b9b8 ("drm/msm/dp: delete vdda regulator related > functions from eDP/DP controller") removed support for VDDA supplies No such commit exists in next. Do not reference unpublished commits. If this is your tree, be sure that it is in next. > from the DP controller driver. These supplies are now handled by the eDP > or QMP PHYs. Mark these properties as deprecated and drop them from the > example. Right now I cannot judge whether this is correct or not. I don't know what's in that commit, but in general driver implementation changes do not warrant changes in the binding. Best regards, Krzysztof
On 14/07/2022 12:38, Krzysztof Kozlowski wrote: > On 10/07/2022 10:41, Dmitry Baryshkov wrote: >> The commit fa384dd8b9b8 ("drm/msm/dp: delete vdda regulator related >> functions from eDP/DP controller") removed support for VDDA supplies > > No such commit exists in next. Do not reference unpublished commits. If > this is your tree, be sure that it is in next. Excuse me. It might have changed at some point. I will update the patch description in the next revision. The commit in question is 7516351bebc1 ("drm/msm/dp: delete vdda regulator related functions from eDP/DP controller") > >> from the DP controller driver. These supplies are now handled by the eDP >> or QMP PHYs. Mark these properties as deprecated and drop them from the >> example. > > Right now I cannot judge whether this is correct or not. I don't know > what's in that commit, but in general driver implementation changes do > not warrant changes in the binding. The vdda supplies were initially made a part of DP controller binding, however lately they were moved to be a part of eDP/DP PHY binding (as this better reflects the hardware). DP driver dropped support for these supplies too. Thus I wanted to mark these supplies as deprecated to discourage using them in the DTS files.
On 14/07/2022 12:15, Dmitry Baryshkov wrote: > On 14/07/2022 12:38, Krzysztof Kozlowski wrote: >> On 10/07/2022 10:41, Dmitry Baryshkov wrote: >>> The commit fa384dd8b9b8 ("drm/msm/dp: delete vdda regulator related >>> functions from eDP/DP controller") removed support for VDDA supplies >> >> No such commit exists in next. Do not reference unpublished commits. If >> this is your tree, be sure that it is in next. > > Excuse me. It might have changed at some point. I will update the patch > description in the next revision. The commit in question is 7516351bebc1 > ("drm/msm/dp: delete vdda regulator related functions from eDP/DP > controller") > >> >>> from the DP controller driver. These supplies are now handled by the eDP >>> or QMP PHYs. Mark these properties as deprecated and drop them from the >>> example. >> >> Right now I cannot judge whether this is correct or not. I don't know >> what's in that commit, but in general driver implementation changes do >> not warrant changes in the binding. > > The vdda supplies were initially made a part of DP controller binding, > however lately they were moved to be a part of eDP/DP PHY binding (as > this better reflects the hardware). DP driver dropped support for these > supplies too. Thus I wanted to mark these supplies as deprecated to > discourage using them in the DTS files. OK. Just better to reference the commit which adds them to PHY binding. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index 94bc6e1b6451..391910d91e43 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -76,8 +76,10 @@ properties: "#sound-dai-cells": const: 0 - vdda-0p9-supply: true - vdda-1p2-supply: true + vdda-0p9-supply: + deprecated: true + vdda-1p2-supply: + deprecated: true ports: $ref: /schemas/graph.yaml#/properties/ports @@ -140,9 +142,6 @@ examples: power-domains = <&rpmhpd SC7180_CX>; - vdda-0p9-supply = <&vdda_usb_ss_dp_core>; - vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; - ports { #address-cells = <1>; #size-cells = <0>;
The commit fa384dd8b9b8 ("drm/msm/dp: delete vdda regulator related functions from eDP/DP controller") removed support for VDDA supplies from the DP controller driver. These supplies are now handled by the eDP or QMP PHYs. Mark these properties as deprecated and drop them from the example. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- .../devicetree/bindings/display/msm/dp-controller.yaml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)