From patchwork Tue May 17 19:09:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 573944 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1556BC433FE for ; Tue, 17 May 2022 19:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352513AbiEQTJz (ORCPT ); Tue, 17 May 2022 15:09:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349575AbiEQTJx (ORCPT ); Tue, 17 May 2022 15:09:53 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C775811A03 for ; Tue, 17 May 2022 12:09:51 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id ev18so7623811pjb.4 for ; Tue, 17 May 2022 12:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WX9lP7cN1XhMLxAyp1fuinpNzyHjtW9iix4zXAbknMw=; b=Z8ufLbQ+4mZKJyLdDDFC62aZ5/hDqWVFsdPEZUe33bzH3AdGyPj61awGDS5cNbbHDg W0naIEoFAgkHlY99tWGdn5v6aLiFChtOCWg8sJMnXMl7EZ0442nl51aORC6xH7dmy/JF XiGHxnjy8cCUW0mftFfTsk9zgCOzTxU4pzhd0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WX9lP7cN1XhMLxAyp1fuinpNzyHjtW9iix4zXAbknMw=; b=pubdnjqEHuT0qVwv1ZKzVev8gjdObZC9YZLfZfhPa52fMgkfnigFmnVUV0enNgDhLs rUjIoURC5JX0Ijr1In4UQnnMn2raAvJaoiR7i9kYe8wrMQJQ43E7jxcb+rgx33hIaZnY FEVkxkbeA/P6kuV7zaZue3lMzM9dSW/ZrEN8aujolAG+auxu+dcTKEQ37I+/0D2VcgzT HJ+PVX2CG9uJJxtgLnw+Z/6SLdEosViZvlrKfPSsQhWk4vT69bwdosNiBXQLCNW07ZtI ZSC+3vssfcOkShdXzlU1THMo41ISVxQcfz7Y8+ngsxY7Od/ma2rz2+2ypQMlRHnVdWQ4 pArA== X-Gm-Message-State: AOAM530y1kbJr8s2mNzMhoSW3E+dKJNnj3lCLSSSBRX8C1ZRU4b3aEIK WOrbd4v23qoiqkBH/HX7J/S9yw== X-Google-Smtp-Source: ABdhPJx+Bj9KO0Av1JRLZUrA6agVbkgI6FASmev7Quni+bS7dw7sIuv6+UWHsrp4bEZdBmdbt5QrIA== X-Received: by 2002:a17:903:1211:b0:15e:8208:8cc0 with SMTP id l17-20020a170903121100b0015e82088cc0mr23524064plh.52.1652814591197; Tue, 17 May 2022 12:09:51 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:be81:6c26:5643:b3d9]) by smtp.gmail.com with ESMTPSA id f16-20020a170902ab9000b0015e8d4eb246sm9498265plr.144.2022.05.17.12.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 12:09:50 -0700 (PDT) From: Stephen Boyd To: Michael Turquette , Stephen Boyd , Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, linux-arm-msm@vger.kernel.org, Alex Elder , Taniya Das Subject: [PATCH] clk: qcom: rpmh: Add note about sleep/wake state for BCMs Date: Tue, 17 May 2022 12:09:49 -0700 Message-Id: <20220517190949.2922197-1-swboyd@chromium.org> X-Mailer: git-send-email 2.36.0.550.gb090851708-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The sleep/wake state doesn't need to be set here because of specific RPMh behavior that carries over the active state when sleep/wake state hasn't been modified. Add a note to the code so we aren't tempted to set the sleep/wake states. Cc: Alex Elder Cc: Taniya Das Signed-off-by: Stephen Boyd Reviewed-by: Bjorn Andersson --- This superseedes a previous patch[1] I sent that tried to fix this. drivers/clk/qcom/clk-rpmh.c | 5 +++++ 1 file changed, 5 insertions(+) base-commit: 42226c989789d8da4af1de0c31070c96726d990c diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index aed907982344..c07cab6905cb 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -274,6 +274,11 @@ static int clk_rpmh_bcm_send_cmd(struct clk_rpmh *c, bool enable) cmd.addr = c->res_addr; cmd.data = BCM_TCS_CMD(1, enable, 0, cmd_state); + /* + * Send only an active only state request. RPMh continues to + * use the active state when we're in sleep/wake state as long + * as the sleep/wake state has never been set. + */ ret = clk_rpmh_send(c, RPMH_ACTIVE_ONLY_STATE, &cmd, enable); if (ret) { dev_err(c->dev, "set active state of %s failed: (%d)\n",