From patchwork Sat May 7 19:49:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 570754 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09043C433EF for ; Sat, 7 May 2022 19:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1447018AbiEGTxb (ORCPT ); Sat, 7 May 2022 15:53:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1446952AbiEGTxX (ORCPT ); Sat, 7 May 2022 15:53:23 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6951186C1 for ; Sat, 7 May 2022 12:49:30 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id i5so14226178wrc.13 for ; Sat, 07 May 2022 12:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=muzSmk4HxrsIFmpzKu6rGnfQn249TNHvGp/FqIyK43w=; b=KPftFVj2wgxX8C02mxFoARQwk0V476TUyK139A8Wd93ZvqhkkiAVO93ODAwoEH8ap7 3Pd6nmxqiSqbo6Dx3sZjLNlzd5jQPXB2f3SvdrOOuKfuXWFpDW7a72SMnFxM3f6TIy9Z G0c3LyAgcyC6GVsvHg0pORfDNnGqSN6VZtIjyfO+k90DJGWN8gVJ7a2dvyCTfn8Cf1Id 9xzzR9K16ikCM6SGNtYrfI5OuUcGmIgvocIY140cW44lLV1XWq/e3ldunBHEgoQP0Cuq QqbzAUR076WLoaS7t2cbbwZbS2ZPKJytlQmaOPLI2eMLlv6qckjb0foDKDZ0u/ZDLELo 81pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=muzSmk4HxrsIFmpzKu6rGnfQn249TNHvGp/FqIyK43w=; b=nLVdUyfBQoan0/rsOdcGQYBwbXQmO+GgiA7TUwC4fiAXVLF2kzTJ1tJPBCim/Orh4n mAGpkPxzSTiMm5ccY7XpNGgZCy1Qr8FBmTpVeqJablkCV52XJXDJi6PjmUpeCogpap4R Uu1Y3S/ScLbzewLNauNX8lDZfcnZZPk7Q9Df3A0yBhPXwIxccnmd0WgMFc+ZBQPh/8m/ OcXtbs5tmDen7EXOaOvw389YxF2S/sAPhppeM+JYz8OXdnDQ9C5QJKvqakwTQQPyFAaB 47z4RzUi79/jT69QwtR9oiT2/n0ikQpL3wG8gabEeyF0r6tV0s+/MW7GKz/ologq789C 9u2A== X-Gm-Message-State: AOAM5310AviqIzwL+CwDRkhzWBEngu4BMiU4I1TpK98lV8LEpLbXSDhM pLGhYhVMZrGV/G286nk6uI0Tvw== X-Google-Smtp-Source: ABdhPJw4a64BTiPPtVqCq4tVSggp892p05eZRr6miMyOtU/Bck3iGmFAEFv2OSfIK4a12mA0wCXyHA== X-Received: by 2002:adf:eac6:0:b0:20a:e096:c4 with SMTP id o6-20020adfeac6000000b0020ae09600c4mr7507435wrn.139.1651952969051; Sat, 07 May 2022 12:49:29 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id j6-20020a05600c1c0600b003942a244ec4sm8535027wms.9.2022.05.07.12.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 May 2022 12:49:28 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Neil Armstrong , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Luca Weiss , David Heidelberg , Konrad Dybcio , Krzysztof Kozlowski Subject: [PATCH 08/11] arm64: dts: qcom: msm8994-msft-lumia-octagon: add PM8994 pin properties Date: Sat, 7 May 2022 21:49:10 +0200 Message-Id: <20220507194913.261121-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220507194913.261121-1-krzysztof.kozlowski@linaro.org> References: <20220507194913.261121-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The bindings require that every pin configuration comes with 'function' property. There is also no 'drive-strength' property but 'qcom,drive-strength': msm8994-msft-lumia-octagon-cityman.dtb: gpios@c000: amsel-high-state: 'oneOf' conditional failed, one must be fixed: 'drive-strength' does not match any of the regexes: 'pinctrl-[0-9]+' 'bias-pull-up', 'drive-strength', 'function', 'pins' do not match any of the regexes: '(pinconf|-pins)$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- Not tested on hardware. --- arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi index 9161b9e1bda1..abe746e88ce1 100644 --- a/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi @@ -521,19 +521,22 @@ &pmi8994_gpios { */ hd3ss460_pol: pol-low-state { pins = "gpio8"; - drive-strength = <3>; + function = PMIC_GPIO_FUNC_NORMAL; + qcom,drive-strength = <3>; bias-pull-down; }; hd3ss460_amsel: amsel-high-state { pins = "gpio9"; - drive-strength = <1>; + function = PMIC_GPIO_FUNC_NORMAL; + qcom,drive-strength = <1>; bias-pull-up; }; hd3ss460_en: en-high-state { pins = "gpio10"; - drive-strength = <1>; + function = PMIC_GPIO_FUNC_NORMAL; + qcom,drive-strength = <1>; bias-pull-up; }; };