From patchwork Thu Aug 19 13:36:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Foss X-Patchwork-Id: 499753 Delivered-To: patch@linaro.org Received: by 2002:a02:6f15:0:0:0:0:0 with SMTP id x21csp535474jab; Thu, 19 Aug 2021 06:36:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDEbGUkHDrchSU2e4DwI2GUQB8DLVtxBdfi/OmlbuCW3Qv1gKKYNYq/PzD3jeWPVJMKjCE X-Received: by 2002:a92:ad12:: with SMTP id w18mr9646946ilh.3.1629380208069; Thu, 19 Aug 2021 06:36:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629380208; cv=none; d=google.com; s=arc-20160816; b=Ob0ZL8uYJe8is4mGcd3xQmvJC539F3m+p9+rnZcUhlaNQ9zba3MqoaNZu8FCGJWSVn 1DcS/kcF7IBXmkBa8ESFHSbk4Pe9e4dcDd/RE0tA0Q7rUutOjadzJjcmTQ/SR+kV81hS cnw01wB309RCMMestGcHoSUA/qqgTxNpNiBrogUQgjP8GvXUon70KpfKo44cqjzjiq/H 5JT+TVgn4aRcCxooiHeQmyZuMqeYMW2af1A8XCCd2N6M2URLSuob3F6MIcpIuTC6Lax4 I9nwN0CDD1vDwTEOBjNv3KRmZFIwDSyJjPlG1L/pWt7nnwadN3KSU8VVdSFJRT6b0Gke Qahg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/BAopytyK/R8bUpbK+b7Q0+6GCUrOVsER44boOsZ9dQ=; b=RVQ4Vx2F6Boyqq4mngDCzWf5PImRrzNp6FW+j5Y6Gca3uD14JBkKwiMPccpHY0AaDG V45GVJrauEvw74TVwcYH9qgTealaMbpfVpogcayscOGm5pTh5aD4UATS/ETmEHIaX7+r eS/VJeoDDZLv0Xvk4FNd36GC+8T7WQExs1MFXC5hzyDWn+SDJwypbBU1oQP+Zf1cFnuI p7eK6yLtz+I5tvsC0eNB8ZTjRcrQxFBDWNv7IOQP74OVJFIwxS1vsx8lfJZ/BeTM8GKv NYANSOPGqcZukdnS52bqsL4+abCRi/yfPr/8QLHFDwumgzsGQQOHJHg/2o2WJ2m6ixYu 3zzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UeVsli6Z; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p6si3102680ilj.154.2021.08.19.06.36.47; Thu, 19 Aug 2021 06:36:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UeVsli6Z; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240152AbhHSNhW (ORCPT + 16 others); Thu, 19 Aug 2021 09:37:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240141AbhHSNhV (ORCPT ); Thu, 19 Aug 2021 09:37:21 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C755EC061756 for ; Thu, 19 Aug 2021 06:36:44 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id x11so13137443ejv.0 for ; Thu, 19 Aug 2021 06:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/BAopytyK/R8bUpbK+b7Q0+6GCUrOVsER44boOsZ9dQ=; b=UeVsli6ZqeVfyxuDP82l6Qchdxd0SS9uCWKergbqRpdGjWukw6CdmP19lDB0j6CeHc kZoC1YnwRSRcSKTrfDIP46iuVub+8E5lBPazngHEZVtCxE8Dt99wvylfuFdsJxJTKcei tgQwEKfYgXVjIv1RvlErvCsIk0WxVwr8WrCI74L3F26QlW7QyC7Y5NRDLhGrdVguY501 hB6uoV6dn4V6XN/KCizDVURHciZZrB8Qcjs7iROlCpv14cTfzS2vaZ8BbBqS+9lSDE8U 6DP4dPYFalWvW/zQpp560Ne0VjzaY5T/Db8Zn2uCZAWs0Ei5wlpAYXCdvXYO30jaIqBe /I0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/BAopytyK/R8bUpbK+b7Q0+6GCUrOVsER44boOsZ9dQ=; b=OXBprblO6gLIKxauQDiJJj1NxAkvIHpwayUwArpROUNWS3tyT+d4SBmYc3CkNVMeXL qU4pqCq3KM2P2qAoXZuuJzvHc/zrym/7Fv0sIG3nC95ge138aHMZdg47y8JU5OTq4iku v+45DCy57RjxSob5PTMWxGSCYP36zWx5UjCO5Yfw4KsOk5t0nGBDXdKprJBi26BI01fX o1odGdoHetddksnVcP/HprMKv54umQKzXJIv67MFS7mBydd0XiLWFJc50PaTv40vRuNP ERqlLXq7epjy3JXmlRWsOxcs6CnpKM4nixMu7BqETfA0MLvr0k++jlZ0SP/MuX6GvmoG e8+g== X-Gm-Message-State: AOAM532sM5VcvII3AQ+6CR5kYcTWh8ZuesmsZTnOZNNsixbke3f6OFWg X03+rqkLPbNlbIJSPWYLvn0MFQ== X-Received: by 2002:a17:906:ad7:: with SMTP id z23mr16114025ejf.419.1629380203406; Thu, 19 Aug 2021 06:36:43 -0700 (PDT) Received: from xps7590.fritz.box ([2a02:2454:3e5:b700:eb3d:3695:30c3:3572]) by smtp.gmail.com with ESMTPSA id ay20sm1770138edb.91.2021.08.19.06.36.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 06:36:43 -0700 (PDT) From: Robert Foss To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, dmitry.baryshkov@linaro.org, abhinavk@codeaurora.org, angelogioacchino.delregno@somainline.org, mkrishn@codeaurora.org, kalyan_t@codeaurora.org, lee.jones@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Robert Foss Subject: [PATCH v1] drm/msm/dpu: Fix address of SM8150 PINGPONG5 IRQ register Date: Thu, 19 Aug 2021 15:36:36 +0200 Message-Id: <20210819133636.2045766-1-robert.foss@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Both PINGPONG4 and PINGPONG5 IRQ registers are using the same address, which is incorrect. PINGPONG4 should use the register offset 30, and PINGPONG5 should use the register offset 31 according to the downstream driver. Fixes: 667e9985ee24 ("drm/msm/dpu: replace IRQ lookup with the data in hw catalog") Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 Reviewed-by: Dmitry Baryshkov diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index 2e482cdd7b3c5..420d78cfce8af 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c @@ -794,7 +794,7 @@ static const struct dpu_pingpong_cfg sm8150_pp[] = { DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 30), -1), PP_BLK("pingpong_5", PINGPONG_5, 0x72800, MERGE_3D_2, sdm845_pp_sblk, - DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 30), + DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 31), -1), };