From patchwork Thu Apr 8 06:45:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 417405 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp276559jai; Wed, 7 Apr 2021 23:46:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy413A06uphTWlXIgueOpKqj+ESbsWSWfDlEV78xUBDJLVd1uyFExma7jEyhk0fOac2X4os X-Received: by 2002:a17:906:2e9a:: with SMTP id o26mr8360121eji.357.1617864360118; Wed, 07 Apr 2021 23:46:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617864360; cv=none; d=google.com; s=arc-20160816; b=aqmjbb2qpnDeGj9xGQfhpZ4BV3iNEkuBSS51LFKDYl2onYAMQmtoT5PvT71t8+CaLm 4BwcjFMPFnQjXjW41KE54Z02XfVQh+OvR2ylawQ+pcy2jaMAL/Mrg9AXAxO2IM8j7wyG 4WsUFMVYzAXZ+Za207lBVRLcsHqMfu7hyNYRjgXnrnhYKPNvPGZ7dxM+2cuT0IrSvb6H 3LS4oZcwqXfPlvWukDi68wWlh//dopHwOMmLlLCgoUnvfQjP3KYPOZD8wEyN6iSwlI0s a2gPXSXquHQa3wyEmuI0uTZnEQ19aMMRyqp9qR8BEWmEu5YV6DlYGpFeQljH+gI+OJpv 6XqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ZIYfXAXPOp7ZatAz23o3vJ3662QuBOhC/c1rjTDCIu0=; b=UtwpdbgSQcoYZSLkIEY2NYNxUdGbWqllyHIYdy8l4LCCCfpIa3tEW89Y+dLgVtwNhN pmHZ+n7+7ZcM2XyFRUK9bqv8o6Hhb/ppEgh5f1HxNvLbpnnkzTLCWRj+Jcia4Lr8F203 G8w1Yk0nV9kaUHKK1KtzC509vpsBPynS4T2XUs/E8s+4VC2k/r0mk5Wj0RRFlrAu6OXD vB++XkLyRDniA8GU3Nv7lk3KehEja6Fe/w9ibUtUZXVY6SLFpeQ62sKRRTMTlk3VbT24 u0Z8omaxPRBuMC8v7/FhtLG2qsAdYEPk96Gc4l3BLYj0jZ4n873W+OeC1KlQfm8VDsQB CxBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=POhQHZ7X; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si2745960edd.228.2021.04.07.23.45.59; Wed, 07 Apr 2021 23:46:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=POhQHZ7X; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229505AbhDHGqD (ORCPT + 16 others); Thu, 8 Apr 2021 02:46:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbhDHGqD (ORCPT ); Thu, 8 Apr 2021 02:46:03 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32C87C061761 for ; Wed, 7 Apr 2021 23:45:51 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id h20so513499plr.4 for ; Wed, 07 Apr 2021 23:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZIYfXAXPOp7ZatAz23o3vJ3662QuBOhC/c1rjTDCIu0=; b=POhQHZ7X/bDZKkqiIHdXpytiko3Kg763WFx1IAWlLE676y/Kxj40Nksj6yvpi4tCKj 8BxHTQ4jAaf5OTRh3geuw4K0b0yedRVEdw0GuuBt0dxAgB19N7zIGi6jNm9Do77LEJ79 l5IGIZT8559uENOV9umiXVkt/gudM6BKg606+MsIHLl2dQEImGTSYHE2GnJtgqZxfBw6 fMMwlercmku+uNiwYHDI1pd5gTjT7EdBRvHmC6HZBVBswatcSX7E43PiprEp3G/kk2Xk +NRTyMKzjFYGya89nu3a/NBDAnw3Ftb8TIlApZV8MEGecwK3jFOc/rIMZhRCy/GoUxhi SKBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZIYfXAXPOp7ZatAz23o3vJ3662QuBOhC/c1rjTDCIu0=; b=uTN3w1EncTy4RJTWLbhHHbvrSCAMe8gmSHENSTAsCX+7MA0uypoLyCHIwMFVo80Edr i2s0gp5z+NhRuy1nplU0N7TyfDXD7SUXHXcVCBzxpmNd/c8s76zGegosMLl0cuSNuJHn HcQnYrmCfGU9enNvhrcqXVvomDDGV7iGShOOQ1TUnedjNixB9BLogUVIegnNZJnJVDs7 429UOIRpjQEp/y4IEezocvdUcYW8aRchKiFTWMae037F9+oIzqYxJcCje5IbdxvDUH+Y i34q24cKEN3aja/G77TzuB5AILknjKw3m+H2im4erjITRS275mot8JfqxLtDUpguulX+ UFIw== X-Gm-Message-State: AOAM532kT+Js5JukmPEOyHmZ6YC/cNmgsls2mdHzDoD1WIrphKBITMgp 0Ec+M2p7NaBM7m1k0UZlJjYmKDcFujmFWbo= X-Received: by 2002:a17:902:748c:b029:e9:3d7e:7894 with SMTP id h12-20020a170902748cb02900e93d7e7894mr6609634pll.51.1617864350335; Wed, 07 Apr 2021 23:45:50 -0700 (PDT) Received: from localhost.localdomain ([2409:4072:6e85:565f:2e19:9e93:4526:a814]) by smtp.gmail.com with ESMTPSA id q9sm4604672pfn.19.2021.04.07.23.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 23:45:49 -0700 (PDT) From: Manivannan Sadhasivam To: linux-arm-msm@vger.kernel.org Cc: hemantk@codeaurora.org, linux-kernel@vger.kernel.org, bbhatt@codeaurora.org, Manivannan Sadhasivam Subject: [PATCH] bus: mhi: core: Fix shadow declarations Date: Thu, 8 Apr 2021 12:15:42 +0530 Message-Id: <20210408064542.22451-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This commit fixes below sparse warnings with W=2 about shadow declarations: drivers/bus/mhi/core/main.c: In function ‘parse_xfer_event’: drivers/bus/mhi/core/main.c:667:17: warning: declaration of ‘flags’ shadows a previous local [-Wshadow] 667 | unsigned long flags; | ^~~~~ drivers/bus/mhi/core/main.c:565:16: note: shadowed declaration is here 565 | unsigned long flags = 0; | ^~~~~ drivers/bus/mhi/core/main.c: In function ‘mhi_process_ctrl_ev_ring’: drivers/bus/mhi/core/main.c:856:23: warning: declaration of ‘new_state’ shadows a previous local [-Wshadow] 856 | enum mhi_pm_state new_state; | ^~~~~~~~~ drivers/bus/mhi/core/main.c:837:19: note: shadowed declaration is here 837 | enum mhi_state new_state; | ^~~~~~~~~ Signed-off-by: Manivannan Sadhasivam --- drivers/bus/mhi/core/main.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.25.1 Reported-by: kernel test robot diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c index b0c8afe16e3a..8e28e4a3ab4b 100644 --- a/drivers/bus/mhi/core/main.c +++ b/drivers/bus/mhi/core/main.c @@ -664,8 +664,6 @@ static int parse_xfer_event(struct mhi_controller *mhi_cntrl, case MHI_EV_CC_OOB: case MHI_EV_CC_DB_MODE: { - unsigned long flags; - mhi_chan->db_cfg.db_mode = 1; read_lock_irqsave(&mhi_cntrl->pm_lock, flags); if (tre_ring->wp != tre_ring->rp && @@ -853,8 +851,6 @@ int mhi_process_ctrl_ev_ring(struct mhi_controller *mhi_cntrl, break; case MHI_STATE_SYS_ERR: { - enum mhi_pm_state new_state; - dev_dbg(dev, "System error detected\n"); write_lock_irq(&mhi_cntrl->pm_lock); new_state = mhi_tryset_pm_state(mhi_cntrl,